From 0768d4820665dae1df1a51124f509ec62f7b5cfd Mon Sep 17 00:00:00 2001 From: Alex Reinking Date: Thu, 3 Sep 2026 17:46:38 -0400 Subject: [PATCH] Stop overriding GitHubStatusPush's default generators The explicit `generators=[BuildStartEndStatusGenerator(...)]` here dropped buildbot's own default `BuildRequestGenerator`, which posts a "pending" GitHub status as soon as a build is queued. Without it, a builder has no status at all until a worker actually starts it, so PRs could look all-green while several buildbots hadn't begun -- and merges landed before the builders ever ran. The `context=` override was also identical to the library default. Removing both restores the queued-state status and trims config that no longer needs to exist. Co-Authored-By: Claude Sonnet 5 --- master/master.cfg | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/master/master.cfg b/master/master.cfg index daa6b9b..8685881 100644 --- a/master/master.cfg +++ b/master/master.cfg @@ -17,9 +17,7 @@ from buildbot.config import BuilderConfig from buildbot.locks import WorkerLock from buildbot.process.factory import BuildFactory from buildbot.process.properties import Interpolate, Properties, Property, Transform, renderer -from buildbot.reporters.generators.build import BuildStartEndStatusGenerator from buildbot.reporters.github import GitHubStatusPush -from buildbot.reporters.message import MessageFormatterRenderable from buildbot.schedulers.basic import AnyBranchScheduler from buildbot.schedulers.canceller import OldBuildCanceller from buildbot.schedulers.forcesched import ForceScheduler @@ -1281,14 +1279,6 @@ c["logCompressionMethod"] = "zstd" c["services"] = [ GitHubStatusPush( token=GITHUB_TOKEN, - context=Interpolate("buildbot/%(prop:buildername)s"), - generators=[ - BuildStartEndStatusGenerator( - builders=[b.name for b in c["builders"]], - start_formatter=MessageFormatterRenderable("Build started."), - end_formatter=MessageFormatterRenderable("Build done."), - ) - ], verbose=True, ), OldBuildCanceller(