From 42d7ba8d52e34f3a2f7b153b8e74f399d7081c7e Mon Sep 17 00:00:00 2001 From: ZainnQureshii <43629888+ZainnQureshii@users.noreply.github.com> Date: Thu, 24 Sep 2026 23:32:53 +0200 Subject: [PATCH] docs(vue): fix dead links in vue testing docs and README Co-Authored-By: Claude Opus 5.5 --- docs/vue/testing.md | 2 +- packages/vue/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/vue/testing.md b/docs/vue/testing.md index 1f4fffdc372..df0f4e432a4 100644 --- a/docs/vue/testing.md +++ b/docs/vue/testing.md @@ -10,7 +10,7 @@ Run `npm run typecheck` in `packages/vue` to check types. The rollup build only The Vue test app supports syncing your locally built changes for validation. -1. [Build](../README.md#building) the `core`, `packages/vue`, and `packages/vue-router` projects using `npm run build`. +1. [Build](../../packages/vue/README.md#building) the `core`, `packages/vue`, and `packages/vue-router` projects using `npm run build`. 2. [Build the Vue test app](#test-app-build-structure). 3. Navigate to the built test app directory (e.g. `packages/vue/test/build/vue3`). 4. Install dependencies using `npm install`. diff --git a/packages/vue/README.md b/packages/vue/README.md index 13fd8c4b145..626f873dd4c 100644 --- a/packages/vue/README.md +++ b/packages/vue/README.md @@ -44,7 +44,7 @@ npm run build * Run `npm run typecheck` to check types. Run it in `packages/vue-router` too when you change `@ionic/vue-router`. The rollup build only reports type errors as warnings, so a passing build does not mean the types are clean. * E2E Tests are found in the `packages/vue/test/base/tests` directory and use Cypress. -* When making changes to `@ionic/vue` or `@ionic/vue-router` you can run `npm run sync` in the [test-app directory](test/README.md#syncing-local-changes) to ensure that the test application is using your built changes. Be sure to build in the `vue` and `vue-router` directories first. +* When making changes to `@ionic/vue` or `@ionic/vue-router` you can run `npm run sync` in the test app directory (see [Syncing Local Changes](https://github.com/ionic-team/ionic-framework/blob/main/docs/vue/testing.md#syncing-local-changes)) to ensure that the test application is using your built changes. Be sure to build in the `vue` and `vue-router` directories first. * Tests can be run in headless mode by running `npm run cypress`. * If you want to open the Cypress test runner, you can run `node_modules/.bin/cypress open`. * Bug fix and feature PRs should have new tests verifying the PR functionality.