From f2005b98a252ada090a9a9eaa8b97fc7723b4d24 Mon Sep 17 00:00:00 2001 From: Vishal Rana Date: Tue, 6 Oct 2026 22:14:58 -0700 Subject: [PATCH] cookbook: apply review suggestions from #443 Log "read" on the read path of the net websocket example (the docs page renders this file), and use a deferred server.Close() in its test, matching the gorilla test. Follow-up to #443 by @wakqasahmed. Claude-Session: https://claude.ai/code/session_01QKDYQr53zNKkR7nif2CAAq --- cookbook/websocket/net/server.go | 2 +- cookbook/websocket/net/server_test.go | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/cookbook/websocket/net/server.go b/cookbook/websocket/net/server.go index cbda78a3..dbdb34f1 100644 --- a/cookbook/websocket/net/server.go +++ b/cookbook/websocket/net/server.go @@ -22,7 +22,7 @@ func hello(c *echo.Context) error { // Read msg := "" if err := websocket.Message.Receive(ws, &msg); err != nil { - c.Logger().Error("failed to write WS message", "error", err) + c.Logger().Error("failed to read WS message", "error", err) return } fmt.Printf("%s\n", msg) diff --git a/cookbook/websocket/net/server_test.go b/cookbook/websocket/net/server_test.go index bc82da37..d7d61b55 100644 --- a/cookbook/websocket/net/server_test.go +++ b/cookbook/websocket/net/server_test.go @@ -22,20 +22,19 @@ func TestHelloReturnsAfterClientDisconnect(t *testing.T) { }) server := httptest.NewServer(e) + defer server.Close() + wsURL := "ws" + strings.TrimPrefix(server.URL, "http") + "/ws" ws, err := websocket.Dial(wsURL, "", server.URL) if err != nil { - server.Close() t.Fatalf("failed to connect websocket client: %v", err) } if err := ws.Close(); err != nil { - server.CloseClientConnections() t.Fatalf("failed to close websocket client: %v", err) } select { case <-handlerReturned: - server.Close() case <-time.After(2 * time.Second): t.Fatal("websocket handler did not return after client disconnected") }