Skip to content

Include timestamp in FollowNotification #154

Description

@iPaulPro

Problem

FollowNotification returns an array of profiles that followed, but no timestamps for the follow events. The other batched notifications, ReactionNotification and ActedNotification, both include timestamps for the respective events.

Right now it's not possible to do something like query for the number of followers gained in the past 24 hours.

export type OpenActionProfileActedFragment = {
    actedAt: string;
    by: ProfileFragment;
    action: OpenActionResult_KnownCollectOpenActionResult_Fragment | OpenActionResult_UnknownOpenActionResult_Fragment;
};
export type ActedNotificationFragment = {
    __typename: 'ActedNotification';
    id: string;
    actions: Array<OpenActionProfileActedFragment>;
    publication: CommentFragment | MirrorFragment | PostFragment | QuoteFragment;
};
export type FollowNotificationFragment = {
    __typename: 'FollowNotification';
    id: string;
    followers: Array<ProfileFragment>;
};

Proposed solution

Follow the pattern of other batched notifications and include the timestamp of follows.

export type FollowNotificationFragment = {
    __typename: 'FollowNotification';
    id: string;
    follows: Array<{
        follower: ProfileFragment;
        followedAt: string;
    }>
};

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions