From 4acf44787ae575b1fa54998bafa28c198ea28b6f Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 9 Oct 2026 01:34:02 +0000 Subject: [PATCH 1/6] Update go version --- go.mod | 2 +- mise.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/go.mod b/go.mod index df0a73d8..d1903121 100644 --- a/go.mod +++ b/go.mod @@ -2,7 +2,7 @@ module github.com/linode/linode-cloud-controller-manager go 1.26.0 -toolchain go1.26.7 +toolchain go1.26.9 require ( github.com/appscode/go v0.0.0-20201105063637-5613f3b8169f diff --git a/mise.toml b/mise.toml index caee33b5..9fbb9666 100644 --- a/mise.toml +++ b/mise.toml @@ -6,7 +6,7 @@ EXP_CLUSTER_RESOURCE_SET = "true" GOTOOLCHAIN = "auto" [tools] -go = "1.26.7" +go = "1.27.2" golangci-lint = "2.11.4" helm = "3.16.3" kubectl = "1.36.2" From 5b69a6feefbcb61ab7d7f8976ca0622965cc0baa Mon Sep 17 00:00:00 2001 From: Ashley Dumaine Date: Fri, 9 Oct 2026 10:26:18 -0400 Subject: [PATCH 2/6] bump golanci-lint to work with new go version, ignore goconst linter in tests and ignore the analyzer complaining about parameter inference not being supported yet since it's a false positive and not an issue with our code --- .golangci.yml | 4 ++++ mise.toml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 7697944a..b802f639 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -142,6 +142,7 @@ linters: - dupl - errcheck - gocognit + - goconst - gocritic - gocyclo - gosec @@ -159,6 +160,9 @@ linters: - linters: - gosec text: 'G104:' + - linters: + - govet + text: "cannot inline" paths: - zz_generated\..+\.go$ - third_party$ diff --git a/mise.toml b/mise.toml index 9fbb9666..2e1d29c7 100644 --- a/mise.toml +++ b/mise.toml @@ -7,7 +7,7 @@ GOTOOLCHAIN = "auto" [tools] go = "1.27.2" -golangci-lint = "2.11.4" +golangci-lint = "2.14.0" helm = "3.16.3" kubectl = "1.36.2" kustomize = "5.8.1" From 101b0ecf7e907f24ad777245bb665b88d3cb8ec2 Mon Sep 17 00:00:00 2001 From: Ashley Dumaine Date: Fri, 9 Oct 2026 10:37:10 -0400 Subject: [PATCH 3/6] group golangci-lint and go updates together --- renovate.json5 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/renovate.json5 b/renovate.json5 index 9ef89ef7..8acb34ac 100644 --- a/renovate.json5 +++ b/renovate.json5 @@ -94,9 +94,9 @@ "groupName": "mise tools", }, { - "description": "Keep the Go version in sync between go.mod and mise.toml.", + "description": "Group Go version and golangci-lint which needs to update with Go version bumps", "matchManagers": ["mise", "gomod"], - "matchDepNames": ["go"], + "matchDepNames": ["go", "golangci-lint"], "groupName": "go version", "groupSlug": "go-version", } From be1c7e9fafcda40de32c9aea972185662a606f9a Mon Sep 17 00:00:00 2001 From: Ashley Dumaine Date: Fri, 9 Oct 2026 10:42:48 -0400 Subject: [PATCH 4/6] for some reason renovate did not actually make mise.toml go match go.mod --- go.mod | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/go.mod b/go.mod index d1903121..47e1a330 100644 --- a/go.mod +++ b/go.mod @@ -1,8 +1,8 @@ module github.com/linode/linode-cloud-controller-manager -go 1.26.0 +go 1.27.0 -toolchain go1.26.9 +toolchain go1.27.2 require ( github.com/appscode/go v0.0.0-20201105063637-5613f3b8169f From 982e2fe3242186c5e6d19898520cfb4bd24132a6 Mon Sep 17 00:00:00 2001 From: Ashley Dumaine Date: Fri, 9 Oct 2026 11:09:59 -0400 Subject: [PATCH 5/6] make custom gcl use mise golangci-lint version, remove deprecated file --- .custom-gcl.yaml | 3 +-- cloud/api.go | 8 -------- mise.toml | 2 +- 3 files changed, 2 insertions(+), 11 deletions(-) delete mode 100644 cloud/api.go diff --git a/.custom-gcl.yaml b/.custom-gcl.yaml index f9900157..d0031a80 100644 --- a/.custom-gcl.yaml +++ b/.custom-gcl.yaml @@ -1,7 +1,6 @@ -version: v2.5.0 name: golangci-lint-nilaway destination: ./bin plugins: - module: "go.uber.org/nilaway" import: "go.uber.org/nilaway/cmd/gclplugin" - version: "v0.0.0-20250821055425-361559d802f0" + version: "acb8859b9031bb9496be97e027df5573f9fb5340" diff --git a/cloud/api.go b/cloud/api.go deleted file mode 100644 index f39a4b56..00000000 --- a/cloud/api.go +++ /dev/null @@ -1,8 +0,0 @@ -package cloud - -import "errors" - -var ( - ErrNotImplemented = errors.New("not implemented") - ErrLBUnsupported = errors.New("loadbalancer unsupported") -) diff --git a/mise.toml b/mise.toml index 2e1d29c7..f4338354 100644 --- a/mise.toml +++ b/mise.toml @@ -98,7 +98,7 @@ run = "make lint-fix" [tasks.build-nilaway] description = "Build the custom NilAway-enabled golangci-lint binary" hide = true -run = "mkdir -p ./bin && golangci-lint custom" +run = "mkdir -p ./bin && golangci-lint custom --version v$(mise current golangci-lint)" [tasks.nilcheck] description = "Run nilaway lint checks" From b968443549ca50eabcbcfc3e035e029684b1626b Mon Sep 17 00:00:00 2001 From: Ashley Dumaine Date: Fri, 9 Oct 2026 11:32:11 -0400 Subject: [PATCH 6/6] take nilaway out of GHA for now, too many false positives --- .github/workflows/go-analyze.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/go-analyze.yml b/.github/workflows/go-analyze.yml index 0b19a249..64c54945 100644 --- a/.github/workflows/go-analyze.yml +++ b/.github/workflows/go-analyze.yml @@ -87,8 +87,5 @@ jobs: - name: Helm Lint run: mise run helm-lint - - name: Nilcheck - run: mise run nilcheck - - name: Vulncheck run: mise run vulncheck