From 440668f2d517e01ec00649665ef65065a88ee875 Mon Sep 17 00:00:00 2001 From: LoopX Agent <337587101+loopx-agent@users.noreply.github.com> Date: Tue, 17 Nov 2026 23:44:20 +0800 Subject: [PATCH 1/2] fix(chat): retain independent task checks through readback Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com> --- .../smoke/goal-created-session-smoke.ts | 29 ++++++++- apps/presentation/dashboard/src/data/chat.ts | 29 +++++++++ .../personal-workspace/goal-loopx-mode.css | 2 + .../personal-workspace/goal-loopx-mode.tsx | 11 +++- .../src/features/personal-workspace/i18n.tsx | 8 +++ .../reference/goal-acceptance-observations.md | 15 +++++ loopx/chat/coordination.py | 34 ++++++---- .../coordination/todo_terminal_lifecycle.ts | 12 +++- .../control_plane/goals/acceptance_actions.py | 14 ++-- .../goals/acceptance_contract.ts | 27 +++++++- .../control_plane/goals/acceptance_oracle.ts | 9 ++- .../goals/acceptance_oracle_io.py | 20 +++++- .../test_goal_session_check_preparation.py | 65 ++++++++++++++++--- .../goal_acceptance_oracle.test.ts | 10 +++ .../goal_acceptance_runtime.test.ts | 53 +++++++++++++++ 15 files changed, 300 insertions(+), 38 deletions(-) diff --git a/apps/presentation/dashboard/smoke/goal-created-session-smoke.ts b/apps/presentation/dashboard/smoke/goal-created-session-smoke.ts index ede6569481..9956ae76ab 100644 --- a/apps/presentation/dashboard/smoke/goal-created-session-smoke.ts +++ b/apps/presentation/dashboard/smoke/goal-created-session-smoke.ts @@ -1,6 +1,7 @@ import assert from "node:assert/strict"; import {goalCreatedManagedSession} from "../src/features/personal-workspace/goal-created-session"; -import {conversationChannelId, conversationContextKey, createChatSession, fetchChatHistory, type TypedActionProposal} from "../src/data/chat"; +import {conversationChannelId, conversationContextKey, createChatSession, fetchChatHistory, + readManagedTaskValidation, type ManagedTaskTurn, type TypedActionProposal} from "../src/data/chat"; const resources = {goal_id: "research", goal_instance_id: null, agent_id: "codex", managed_agent_id: "codex", channel_id: "agent.codex", session_id: "original-session"}; @@ -76,4 +77,30 @@ try { assert.equal((await fetchChatHistory({channelId: conversationContextKey(context), managed: target}, unavailable)).messages[0].text, "Original result 原始结果"); assert.ok(requests.every(path => path.startsWith("/api/chat/sessions"))); } finally {globalThis.fetch = originalFetch;} + +const lineage = {goal_id: target.goalId, agent_id: target.agentId, todo_id: "cart-repair"}; +const turn: ManagedTaskTurn = {session_id: target.sessionId, turn_id: "first-task", client_turn_id: "managed.first-task", + status: "completed", origin: "native_loopx", loopx_execution: true, loopx_request: { + operation: "native_turn", todo_id: lineage.todo_id, + actor: {goal_id: target.goalId, agent_id: target.agentId, session_id: target.sessionId}, + }}; +const postcondition = {schema_version: "loopx_turn_execution_v0", dry_run: false, + validation_stage: "task_postcondition", receipt: {ok: true, lineage}}; +const passingCheck = {schema_version: "loopx_turn_task_validation_v0", ok: true, status: "passed", summary: "Checks passed"}; +const checkedTurn = {...turn, response: {native_loopx: {...postcondition, validation: passingCheck}}}; +assert.equal(readManagedTaskValidation(checkedTurn)?.status, "passed"); +assert.equal(readManagedTaskValidation({...turn, response: {native_loopx: {...postcondition, + validation: {...passingCheck, ok: false, status: "failed", summary: "One required check failed"}}}})?.status, "failed", + "A terminal conversation receipt can carry a failed independent check"); +for (const native_loopx of [ + {...postcondition, dry_run: true, validation: passingCheck}, + {...postcondition, validation_stage: "host_result_contract", validation: passingCheck}, + {...postcondition, validation: {...passingCheck, ok: false}}, + {...postcondition, receipt: {ok: true, lineage: {...lineage, todo_id: "another-task"}}, validation: passingCheck}, +]) { + assert.equal(readManagedTaskValidation({...turn, response: {native_loopx}}), undefined, + "Simulation, unrelated lineage and inconsistent receipts cannot certify the selected Task"); +} +assert.equal(readManagedTaskValidation(turn), undefined, "Legacy responses cannot attest a check"); +assert.equal(readManagedTaskValidation({...checkedTurn, status: "running"}), undefined); console.log("goal-created-session: original owner/history, replay, legacy parity and identity failure/recovery passed"); diff --git a/apps/presentation/dashboard/src/data/chat.ts b/apps/presentation/dashboard/src/data/chat.ts index 8488f528ef..e111a157a0 100644 --- a/apps/presentation/dashboard/src/data/chat.ts +++ b/apps/presentation/dashboard/src/data/chat.ts @@ -1751,6 +1751,35 @@ const managedTaskEntrySchema = z.object({ok: z.literal(true), session_id: z.stri export type ManagedTaskEntry = z.infer; export type ManagedTaskTurn = z.infer; +const managedTaskValidationSchema = z.object({ + native_loopx: z.object({ + schema_version: z.literal("loopx_turn_execution_v0"), + dry_run: z.literal(false), + validation_stage: z.literal("task_postcondition"), + receipt: z.object({ok: z.literal(true), lineage: z.object({ + goal_id: z.string(), agent_id: z.string(), todo_id: z.string(), + })}), + validation: z.object({ + schema_version: z.literal("loopx_turn_task_validation_v0"), + status: z.enum(["passed", "failed", "inconclusive", "unavailable"]), + ok: z.boolean(), + summary: z.string().trim().min(1).max(240), + }), + }), +}); + +/** Read independent checks from an already verified managed Task turn. */ +export function readManagedTaskValidation(turn: ManagedTaskTurn) { + if (turn.status !== "completed") return undefined; + const parsed = managedTaskValidationSchema.safeParse(turn.response); + if (!parsed.success) return undefined; + const {receipt: {lineage}, validation} = parsed.data.native_loopx; + const {actor, todo_id: todoId} = turn.loopx_request; + if (lineage.goal_id !== actor.goal_id || lineage.agent_id !== actor.agent_id || lineage.todo_id !== todoId + || validation.ok !== (validation.status === "passed")) return undefined; + return validation; +} + function verifyManagedTaskTurn(turn: ManagedTaskTurn, target: ManagedConversationTarget, operationId: string, todoId?: string) { const actor = turn.loopx_request.actor; if (turn.session_id !== target.sessionId || turn.client_turn_id !== `managed.${operationId}` diff --git a/apps/presentation/dashboard/src/features/personal-workspace/goal-loopx-mode.css b/apps/presentation/dashboard/src/features/personal-workspace/goal-loopx-mode.css index 6852f7c918..e044a35be1 100644 --- a/apps/presentation/dashboard/src/features/personal-workspace/goal-loopx-mode.css +++ b/apps/presentation/dashboard/src/features/personal-workspace/goal-loopx-mode.css @@ -6,6 +6,8 @@ .goal-loopx-mode-status[data-active="true"] > i { background: var(--pw-green, #13804a); } .goal-loopx-mode p { font-size: var(--text-caption); color: var(--pw-muted, #666); margin: 8px 0; line-height: var(--leading-caption); } .goal-loopx-mode .personal-composer-error { color: var(--pw-red, #b42318); } +.goal-loopx-task-check { font-weight: 500; } +.goal-loopx-mode .goal-loopx-task-check[data-status="failed"] { color: var(--pw-red, #b42318); } .goal-loopx-mode button { display: inline-flex; align-items: center; justify-content: center; gap: 6px; min-width: 44px; min-height: 44px; border: 1px solid var(--pw-line, #ebebeb); background: var(--pw-surface, #fff); color: inherit; border-radius: 6px; padding: 8px 12px; font: inherit; cursor: pointer; } .goal-loopx-mode .goal-loopx-primary { font-weight: 500; border-color: var(--pw-line-strong, #ddd); } .goal-loopx-mode .goal-loopx-team-trigger { border-color: transparent; background: transparent; } diff --git a/apps/presentation/dashboard/src/features/personal-workspace/goal-loopx-mode.tsx b/apps/presentation/dashboard/src/features/personal-workspace/goal-loopx-mode.tsx index 37a2787989..ee966692b0 100644 --- a/apps/presentation/dashboard/src/features/personal-workspace/goal-loopx-mode.tsx +++ b/apps/presentation/dashboard/src/features/personal-workspace/goal-loopx-mode.tsx @@ -1,7 +1,7 @@ import {ContextHelp} from "./context-help"; import {useEffect, useRef, useState} from "react"; import {Pause, Play, Settings2, Users, X} from "lucide-react"; -import {fetchLoopXMode, updateLoopXMode, fetchManagedTaskEntry, startManagedTaskTurn, +import {fetchLoopXMode, updateLoopXMode, fetchManagedTaskEntry, readManagedTaskValidation, startManagedTaskTurn, type ManagedConversationTarget, type ManagedTaskEntry, type ManagedTaskTurn, type LoopXModeSnapshot, type LoopXModeSettings} from "../../data/chat"; import {useWorkspaceI18n} from "./i18n"; import {GoalTeamWork} from "./goal-team-work"; @@ -43,7 +43,8 @@ function observedTaskTurn(read: ManagedTaskEntry | null, attempt: TaskAttempt | } function ManagedTaskMode({target, onObserve}: NonNullable) { - const zh = useWorkspaceI18n().locale === "zh-CN"; + const {locale, t} = useWorkspaceI18n(); + const zh = locale === "zh-CN"; const storageKey = `loopx-managed-task:${JSON.stringify([target.goalId, target.agentId, target.sessionId])}`; const [retained, setRetained] = useState<{attempt: TaskAttempt | null; unreadable: boolean}>(() => { try {return {attempt: readTaskAttempt(storageKey), unreadable: false};} catch {return {attempt: null, unreadable: true};} @@ -123,6 +124,8 @@ function ManagedTaskMode({target, onObserve}: NonNullable

{zh ? "在原会话推进当前任务,使用已确认的检查和现有额度。" : "Advance the current Task in its original conversation using its confirmed checks and existing allowance."}

{read?.task.state === "ready" ?

{zh ? `${read.task.observation.check_count} 项检查 · ${read.task.observation.pinned_file_count} 个固定来源文件` : `${read.task.observation.check_count} checks · ${read.task.observation.pinned_file_count} pinned source files`}

: null} + {validation && validation.status !== "passed" ?

{validation.summary}

: null}