From b511d09b0d5a00f23556f19202fbac46504ac2de Mon Sep 17 00:00:00 2001 From: LoopX Agent <337587101+loopx-agent@users.noreply.github.com> Date: Wed, 18 Nov 2026 05:23:33 +0800 Subject: [PATCH] test(quota,dsh): lock in paused-goal non-admission for unsettled turns Verify #8577 (77eece8676) and #8879 (3d6fd2e0ce) on main against DSH pause/unsettled-recovery regressions across file and sqlite providers: - Paused Goals (goal_stopped and compute_quota_zero) must keep should_run=False and pause_cause without projecting unsettled_host_turn_recovery, setting closeout_required=True, setting a settlement_effect_id/recovery_effect_id, or consuming the bounded 3-admission recovery budget. - Resuming restores unsettled_host_turn_recovery with admissions_without_progress == 0. Closes #8505 Closes #8563 Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com> --- ...test_unsettled_recovery_admission_bound.py | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/tests/control_plane/test_unsettled_recovery_admission_bound.py b/tests/control_plane/test_unsettled_recovery_admission_bound.py index e75dfefa25..90734635d7 100644 --- a/tests/control_plane/test_unsettled_recovery_admission_bound.py +++ b/tests/control_plane/test_unsettled_recovery_admission_bound.py @@ -322,3 +322,75 @@ def claim_last(turn: str) -> tuple[str, dict]: ] assert sorted(grants) == sorted(["prior-recovery-0", "prior-recovery-1", winner]) assert _spend_run_count(runtime) == 0 + + +@pytest.mark.parametrize("provider", ["file", "sqlite"]) +@pytest.mark.parametrize("pause_mode", ["goal_stopped", "compute_zero"]) +def test_paused_goal_blocks_unsettled_recovery_without_fabricating_receipts( + tmp_path: Path, monkeypatch: pytest.MonkeyPatch, provider: str, pause_mode: str, +) -> None: + isolate_sqlite_runtime(tmp_path, monkeypatch) + _, runtime, registry = _write_fixture(tmp_path, provider=provider) + guard = ("quota", "should-run", "--codex-app", "--goal-id", GOAL_ID, "--agent-id", AGENT_ID) + rc, first = _run_cli( + registry, runtime, *guard, "--turn-instance-id", "owed-original", "--todo-id", TODO_ID, + ) + assert rc == 0 and first["should_run"] is True and first["heartbeat_receipt"]["closeout_required"], first + effect = first["heartbeat_receipt"]["settlement_identity"]["effect_id"] + + if pause_mode == "goal_stopped": + rc, stopped = _run_cli( + registry, runtime, "goal-lifecycle", "--goal-id", GOAL_ID, + "--operation", "stop", "--actor-kind", "owner", "--execute", + ) + assert rc == 0 and stopped["written"] is True, stopped + else: + raw_registry = json.loads(registry.read_text(encoding="utf-8")) + raw_registry["goals"][0]["quota"]["compute"] = 0 + raw_registry["goals"][0]["quota"]["allowed_slots"] = 0 + registry.write_text(json.dumps(raw_registry, indent=2) + "\n", encoding="utf-8") + + log = rollout_event_log_path(runtime, GOAL_ID) + expected_cause = "goal_stopped" if pause_mode == "goal_stopped" else "compute_quota_zero" + for pause_turn in ("pause-poll-1", "pause-poll-2"): + rc, paused = _run_cli(registry, runtime, *guard, "--turn-instance-id", pause_turn) + assert rc == 0, paused + assert paused["should_run"] is False, paused + assert (paused.get("quota") or {}).get("state") == "paused", paused + assert paused.get("pause_cause") == expected_cause, paused + assert "unsettled_host_turn_recovery" not in paused, paused + receipt = paused.get("heartbeat_receipt") or {} + assert not receipt.get("closeout_required"), receipt + assert "settlement_identity" not in receipt, receipt + + paused_events = [ + event for event in load_rollout_events(log) + if event.get("run_id") in {"pause-poll-1", "pause-poll-2"} + ] + assert len(paused_events) == 2 + for event in paused_events: + details = event.get("details") or {} + assert details.get("should_run") is False, event + assert not details.get("closeout_required"), event + assert not str(details.get("recovery_effect_id") or "").strip(), event + assert not str(details.get("settlement_effect_id") or "").strip(), event + + if pause_mode == "goal_stopped": + rc, resumed = _run_cli( + registry, runtime, "goal-lifecycle", "--goal-id", GOAL_ID, + "--operation", "resume", "--actor-kind", "owner", "--execute", + ) + assert rc == 0 and resumed["written"] is True, resumed + else: + raw_registry = json.loads(registry.read_text(encoding="utf-8")) + raw_registry["goals"][0]["quota"]["compute"] = 1 + raw_registry["goals"][0]["quota"]["allowed_slots"] = 4 + registry.write_text(json.dumps(raw_registry, indent=2) + "\n", encoding="utf-8") + + rc, recovered = _run_cli(registry, runtime, *guard, "--turn-instance-id", "after-resume") + assert rc == 0 and recovered["should_run"] is True, recovered + debt = recovered["unsettled_host_turn_recovery"] + assert debt["prior_turn_instance_id"] == "owed-original" + assert debt["settlement_effect_id"] == effect + assert debt["admissions_without_progress"] == 0, debt + assert _spend_run_count(runtime) == 0