Skip to content

Popup not closing on Save & Exit. Also, small bug found. #89

Description

@indianacraig

Our server info: REDCap 17.0.0 · PHP 8.4.15 (Linux/Unix OS) · MySQL 8.0.42
We are currently using the latest version: Instance Table 1.13.5.

The issue that we thought was fixed in this version of Instance Table is where the popup should close after clicking Save & Exit. It is still very random where it closes sometimes and other times it doesn't. Also, when it doesn't close, it takes you to the Record Home page within the popup. So I did some troubleshooting and here is what I found.

I found a small bug where line 1019, "window.setTimeout( actuallyRefreshTables(), 1500);", should not have the brackets after "actuallyRefreshTables". From what I read, it will cause the function to be called immediately instead of waiting 1.5 seconds. The line should be "window.setTimeout( actuallyRefreshTables, 1500);". After I fixed this in my version, it still did not fix the popup closing issue.

I did some more troubleshooting and I found that by removing line 1131, "window.opener.refreshTables();", the issue is fixed. The table is still getting refreshed without this line. I did several tests in both Firefox and Edge and I no longer see an issue. It could be that line 1102, "window.onunload = function(){window.opener.refreshTables();};", is taking care of the table refresh instead and therefore line 1131 is no longer needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions