From 68b7bc086b4688ecc1c6f80653b8b268e7750a87 Mon Sep 17 00:00:00 2001 From: Tyrie Vella Date: Fri, 14 Aug 2026 15:06:51 -0700 Subject: [PATCH] Return DownloadAttemptResult from the malformed-SHA guard The malformed-SHA guard in TryDownloadAndSaveObject returned the bare DownloadAndSaveObjectResult enum. The method now returns DownloadAttemptResult (the enum plus an HTTP status code), so the build failed with CS0029. Wrap the error in a DownloadAttemptResult with a null status code, matching the AllZeroSha guard just below it. Assisted-by: Claude Opus 4.8 Signed-off-by: Tyrie Vella --- GVFS/GVFS.Common/Git/GVFSGitObjects.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GVFS/GVFS.Common/Git/GVFSGitObjects.cs b/GVFS/GVFS.Common/Git/GVFSGitObjects.cs index f02af5817..06a1af990 100644 --- a/GVFS/GVFS.Common/Git/GVFSGitObjects.cs +++ b/GVFS/GVFS.Common/Git/GVFSGitObjects.cs @@ -264,7 +264,7 @@ private DownloadAttemptResult TryDownloadAndSaveObject( metadata.Add(TracingConstants.MessageKey.WarningMessage, nameof(this.TryDownloadAndSaveObject) + ": Refusing to download object with malformed SHA"); this.Tracer.RelatedEvent(EventLevel.Warning, nameof(this.TryDownloadAndSaveObject) + "_MalformedBlobSha", metadata, Keywords.Telemetry); - return DownloadAndSaveObjectResult.Error; + return new DownloadAttemptResult(DownloadAndSaveObjectResult.Error, httpStatusCode: null); } if (objectId == GVFSConstants.AllZeroSha)