diff --git a/quest/m0/ci/release-pr-after-release.md b/quest/m0/ci/release-pr-after-release.md index 5f8724c99cd..9c03fece812 100644 --- a/quest/m0/ci/release-pr-after-release.md +++ b/quest/m0/ci/release-pr-after-release.md @@ -9,33 +9,33 @@ merge doesn't produce a stale release PR. ## Plan -Planned 2026-11-03 (maintainer, `/quest-plan`). The ordering cause is -confirmed by the [release run](https://github.com/moq-dev/moq/actions/runs/41704418718/job/126155827712) -from [moq-dev/moq#7651](https://github.com/moq-dev/moq/pull/7651): - -- 19:56:23Z: `release-plz release-pr` starts. -- 19:56:50Z: moq-tokio's local 0.19.33 exceeds registry 0.19.32, so only its - changelog will be updated. -- 19:57:17Z: it opens [moq-dev/moq#7750](https://github.com/moq-dev/moq/pull/7750), - after warning about duplicate 0.19.33 release notes. -- 19:57:18Z: `release-plz release` starts; 0.19.33 publishes at 20:01:14Z. - -[moq-dev/moq#7818](https://github.com/moq-dev/moq/pull/7818) reverses the -recipe's order, preserving failure propagation. It changes neither credentials -nor the workflow, so [Rust releases publish through OIDC](/quest/m1/release-rs-oidc.md) -can keep using the recipe. - -The [upstream action source](https://github.com/release-plz/action/blob/c19c3f863fe52ef2b1bfa99904581992314021bf/action.yml#L157) -also runs `release-pr` first; the original plan's assumption that its order -would solve this was wrong. The dev shell's release-plz 0.3.172 has no -`release-pr --dry-run`. Recorded events and a command stub verified the cause, -new order, and failure propagation without publishing packages or tags. +Planned 2026-11-03 (maintainer, `/quest-plan`). The +[release run](https://github.com/moq-dev/moq/actions/runs/41704418718/job/126155827712) +from [moq-dev/moq#7651](https://github.com/moq-dev/moq/pull/7651) ran +`release-plz release-pr` before `release-plz release`, so it opened +[moq-dev/moq#7750](https://github.com/moq-dev/moq/pull/7750) for moq-tokio +0.19.33 four minutes before publishing it. + +The fix is deployed: `just rs release` now publishes first, then proposes. + +- [moq-dev/moq#7818](https://github.com/moq-dev/moq/pull/7818) landed it on + `main` on 2026-11-04. +- [moq-dev/moq#7842](https://github.com/moq-dev/moq/pull/7842) backported only + the recipe to `release` the same day. +- The backport merge's own + [Release RS run](https://github.com/moq-dev/moq/actions/runs/41857741087) + ran `release` (every crate already published) before `release-pr` (every + crate up to date) and opened no PR. Its merge changed no crate, so it + exercised the order but not a publishing release. + +What remains is evidence from a release merge that publishes. ## Waiting -- moq-dev/moq: land the ordering fix on `main`, then backport only the release - recipe to `release` in a separate PR. Verify the next approved release merge's - Release RS log publishes before proposing and opens no stale PR, then delete - this quest. No post-fix release has run; local checks do not prove deployment. +- moq-dev/moq: the next approved release-plz release PR merges into `release`; + agents never merge into `release`. Check that merge's Release RS log: every + `release-plz release` publish finishes before `release-plz release-pr` starts, + and the run opens no release PR proposing the versions it just published. + If so, delete this quest; if not, rewrite its Plan around that run. Public API: none. Wire: none.