From cf86e185acf1639cf4ea3d24ba2a82cc16f16afe Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 05:11:25 -0800 Subject: [PATCH 1/3] chore(quest): claim quest/m0/studio-builds-alone.md Quest-Claim: eeec9752898e0ef9 From 21a754ecda99268df1a44e4ab7e492aec9a3a8f0 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 06:04:25 -0800 Subject: [PATCH 2/3] fix(studio): enable moq-stats' async on the studio's own dependency Co-Authored-By: Claude Opus 5.5 --- quest/m0/README.md | 1 - quest/m0/studio-builds-alone.md | 20 -------------------- rs/moq-studio/Cargo.toml | 2 +- 3 files changed, 1 insertion(+), 22 deletions(-) delete mode 100644 quest/m0/studio-builds-alone.md diff --git a/quest/m0/README.md b/quest/m0/README.md index fd6cd60..038a103 100644 --- a/quest/m0/README.md +++ b/quest/m0/README.md @@ -102,7 +102,6 @@ repository. - [Browser sources on the GPU under Mesa](/quest/m0/cef-headless.md) - shared-texture pages paint on Intel and AMD under Wayland, and a page that cannot paint fails loudly - [The program reaches a relay on every runner](/quest/m0/relay-test-flake.md) - the relay engine test stops failing the nightly on GitHub's runner - [Browser sources make no outside requests](/quest/m0/browser-offline.md) - no component updates, spellcheck downloads, or network time from the helper -- [moq-studio builds on its own](/quest/m0/studio-builds-alone.md) - `cargo build -p moq-studio` no longer leans on a test dependency's features - [The Apple signing identity is available](/quest/m0/signing.md) - the Apple credentials packaging and the macOS camera need; Windows ships unsigned - [Packaging](/quest/m0/packaging.md) - a signed macOS app, a Windows installer, and a Flatpak for Linux - [The persistable portal restore token is pinned](/quest/m0/pin-portal-token.md) - moq-video's restore token, for Wayland sources diff --git a/quest/m0/studio-builds-alone.md b/quest/m0/studio-builds-alone.md deleted file mode 100644 index e004243..0000000 --- a/quest/m0/studio-builds-alone.md +++ /dev/null @@ -1,20 +0,0 @@ -# [XS] moq-studio builds on its own - -## Goal - -`cargo build -p moq-studio` succeeds on its own, not only inside a workspace -build, because every feature the studio uses is enabled by its own -dependencies. - -## Plan - -From [moq-dev/studio#84](https://github.com/moq-dev/studio/pull/84), picked -2026-11-07 (maintainer away under /afk, recommended option), m0 by the rule -that fixes join m0. - -`rs/moq-studio/src/health.rs` awaits moq-stats' async wrappers, but only a -test dependency turns on moq-stats' `async` feature, so the workspace build -and CI unify it in and never notice. Enable `async` on the studio's own -moq-stats dependency, and check the other moq crates the studio awaits for -the same gap. Recommendation, not settled: have `just check` build -`moq-studio` on its own so CI catches the next one. diff --git a/rs/moq-studio/Cargo.toml b/rs/moq-studio/Cargo.toml index 6049f79..e5abb62 100644 --- a/rs/moq-studio/Cargo.toml +++ b/rs/moq-studio/Cargo.toml @@ -63,7 +63,7 @@ moq-net = { workspace = true } # The guest room: its path convention, roster, and token claims. moq-room = { workspace = true, features = ["async"] } moq-scene = { workspace = true } -moq-stats = { workspace = true } +moq-stats = { workspace = true, features = ["async"] } moq-tokio = { workspace = true, default-features = false, features = ["net"] } moq-video = { workspace = true } pollster = { workspace = true } From 90c818d710edb970b5e6d731ccd2ccd7f592eef8 Mon Sep 17 00:00:00 2001 From: Luke Curley Date: Sat, 7 Nov 2026 06:11:29 -0800 Subject: [PATCH 3/3] build: just check builds the studio alone Co-Authored-By: Claude Opus 5.5 --- justfile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/justfile b/justfile index 0a8f431..31fd2f9 100644 --- a/justfile +++ b/justfile @@ -24,6 +24,9 @@ check: cargo fmt --all --check cargo clippy --locked --workspace --all-targets -- -D warnings cargo clippy --locked --workspace --all-targets --features {{ features }} -- -D warnings + # The studio as `cargo run -p moq-studio` builds it: alone, so the features + # only its tests' dependencies turn on cannot hide one it needs. + cargo check --locked -p moq-studio --features {{ features }} # Run the tests. [positional-arguments]