From 032cbed4ad969f2bb5820d522e74a219f0d94984 Mon Sep 17 00:00:00 2001 From: ms609-agent <313734811+ms609-agent@users.noreply.github.com> Date: Mon, 21 Sep 2026 11:34:10 +0100 Subject: [PATCH] ci: run the full and revdepcheck waves outside pull requests Both jobs had `needs: core` and no `if:`, so they took the implicit success(), which is false whenever any job upstream was skipped, even transitively. codemeta runs only on pull_request, so on push to main, the weekly schedule and workflow_dispatch the macOS / ubuntu-release backstop and every revdepcheck leg were skipped, though core passed. First seen on the #206 merge commit (4ef39fcd). Gate on core's result explicitly, as core itself does on sense-check. Co-Authored-By: Claude Opus 5 --- .github/workflows/R-CMD-check.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/R-CMD-check.yml b/.github/workflows/R-CMD-check.yml index 002b0a85..1190a0ef 100644 --- a/.github/workflows/R-CMD-check.yml +++ b/.github/workflows/R-CMD-check.yml @@ -533,6 +533,10 @@ jobs: # --------------------------------------------------------------------------- full: needs: core + # Explicit: the implicit success() fails when any upstream job was skipped, + # and codemeta is skipped outside pull requests, so without this the + # backstop never ran on push, schedule or workflow_dispatch. + if: ${{ !cancelled() && needs.core.result == 'success' }} runs-on: ${{ matrix.config.os }} timeout-minutes: 60 # macOS legs are the slow ones name: ${{ matrix.config.os }} (${{ matrix.config.r }}) @@ -662,6 +666,10 @@ jobs: # --------------------------------------------------------------------------- rev-dep-check: needs: core + # Explicit: the implicit success() fails when any upstream job was skipped, + # and codemeta is skipped outside pull requests, so without this the + # backstop never ran on push, schedule or workflow_dispatch. + if: ${{ !cancelled() && needs.core.result == 'success' }} runs-on: ubuntu-latest timeout-minutes: 120 # revdepchecks are genuinely long