diff --git a/app/src/androidTest/java/com/owncloud/android/operations/DeleteE2ERemoteOperationIT.kt b/app/src/androidTest/java/com/owncloud/android/operations/DeleteE2ERemoteOperationIT.kt index 0140a769c797..79282e382d02 100644 --- a/app/src/androidTest/java/com/owncloud/android/operations/DeleteE2ERemoteOperationIT.kt +++ b/app/src/androidTest/java/com/owncloud/android/operations/DeleteE2ERemoteOperationIT.kt @@ -12,7 +12,7 @@ import com.owncloud.android.lib.resources.e2ee.DeleteEncryptedFilesRemoteOperati import com.owncloud.android.lib.resources.users.DeletePrivateKeyRemoteOperation import com.owncloud.android.lib.resources.users.DeletePublicKeyRemoteOperation import com.owncloud.android.lib.resources.users.GetPrivateKeyRemoteOperation -import com.owncloud.android.lib.resources.users.GetPublicKeyRemoteOperation +import com.owncloud.android.lib.resources.users.GetCertificateRemoteOperation import com.owncloud.android.lib.resources.users.StorePrivateKeyRemoteOperation import com.owncloud.android.ui.dialog.setupEncryption.EncryptionKeyGenerator import com.owncloud.android.utils.EncryptionUtils @@ -58,7 +58,7 @@ class DeleteE2ERemoteOperationIT : AbstractOnServerIT() { val result = sut.execute(nextcloudClient) assertTrue(result.isSuccess) - val getResult = GetPublicKeyRemoteOperation().execute(nextcloudClient) + val getResult = GetCertificateRemoteOperation().execute(nextcloudClient) assertFalse(getResult.isSuccess) } } diff --git a/app/src/main/java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt b/app/src/main/java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt index 80844ecbbff6..d53de7deeee9 100644 --- a/app/src/main/java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt +++ b/app/src/main/java/com/nextcloud/utils/e2ee/E2EEKeyInspector.kt @@ -19,7 +19,7 @@ import com.owncloud.android.lib.common.OwnCloudClientFactory import com.owncloud.android.lib.common.utils.Log_OC import com.owncloud.android.lib.resources.e2ee.GetMetadataRemoteOperation import com.owncloud.android.lib.resources.status.OCCapability -import com.owncloud.android.lib.resources.users.GetPublicKeyRemoteOperation +import com.owncloud.android.lib.resources.users.GetCertificateRemoteOperation import com.owncloud.android.lib.resources.users.GetServerPublicKeyRemoteOperation import com.owncloud.android.operations.GetCapabilitiesOperation import com.owncloud.android.ui.dialog.setupEncryption.CertificateValidator @@ -62,7 +62,7 @@ class E2EEKeyInspector @Inject constructor( val user = accountManager.user - val certificateResult = GetPublicKeyRemoteOperation().executeNextcloudClient(user, context) + val certificateResult = GetCertificateRemoteOperation().executeNextcloudClient(user, context) if (!certificateResult.isSuccess) { return@withContext if (certificateResult.httpCode == HttpStatus.SC_NOT_FOUND) { DownloadKeyResult.NoServerKey diff --git a/app/src/main/java/com/owncloud/android/operations/CreateShareWithShareeOperation.java b/app/src/main/java/com/owncloud/android/operations/CreateShareWithShareeOperation.java index 9f10b762af5e..aa173a6b0fd3 100644 --- a/app/src/main/java/com/owncloud/android/operations/CreateShareWithShareeOperation.java +++ b/app/src/main/java/com/owncloud/android/operations/CreateShareWithShareeOperation.java @@ -31,7 +31,7 @@ import com.owncloud.android.lib.resources.shares.CreateShareRemoteOperation; import com.owncloud.android.lib.resources.shares.OCShare; import com.owncloud.android.lib.resources.shares.ShareType; -import com.owncloud.android.lib.resources.users.GetPublicKeyRemoteOperation; +import com.owncloud.android.lib.resources.users.GetCertificateRemoteOperation; import com.owncloud.android.operations.common.SyncOperation; import com.owncloud.android.utils.EncryptionUtils; import com.owncloud.android.utils.EncryptionUtilsV2; @@ -130,7 +130,7 @@ protected RemoteOperationResult run(OwnCloudClient client) { if (publicKey.isEmpty()) { NextcloudClient nextcloudClient = new ClientFactoryImpl(context).createNextcloudClient(user); - RemoteOperationResult result = new GetPublicKeyRemoteOperation(shareeName).execute(nextcloudClient); + RemoteOperationResult result = new GetCertificateRemoteOperation(shareeName).execute(nextcloudClient); if (result.isSuccess()) { // store it EncryptionUtils.savePublicKey( diff --git a/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt b/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt index 452e9899d581..8c44220d8d80 100644 --- a/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/dialog/setupEncryption/SetupEncryptionDialogFragment.kt @@ -31,7 +31,7 @@ import com.owncloud.android.datamodel.ArbitraryDataProvider import com.owncloud.android.datamodel.ArbitraryDataProviderImpl import com.owncloud.android.lib.common.utils.Log_OC import com.owncloud.android.lib.resources.users.GetPrivateKeyRemoteOperation -import com.owncloud.android.lib.resources.users.GetPublicKeyRemoteOperation +import com.owncloud.android.lib.resources.users.GetCertificateRemoteOperation import com.owncloud.android.lib.resources.users.GetServerPublicKeyRemoteOperation import com.owncloud.android.ui.dialog.extensions.themeButtons import com.owncloud.android.ui.dialog.setupEncryption.model.DownloadKeyResult @@ -267,8 +267,7 @@ class SetupEncryptionDialogFragment : val user = user ?: return@withContext DownloadKeyResult.UnexpectedError() val dataProvider = arbitraryDataProvider ?: return@withContext DownloadKeyResult.UnexpectedError() - // GetPublicKeyRemoteOperation is wrong naming it actually fetches certificate - val certificateOperation = GetPublicKeyRemoteOperation() + val certificateOperation = GetCertificateRemoteOperation() val certificateResult = certificateOperation.executeNextcloudClient(user, weakContext) if (!certificateResult.isSuccess) { // The certificate might not be available on the server yet. diff --git a/app/src/main/java/com/owncloud/android/utils/EncryptionUtils.java b/app/src/main/java/com/owncloud/android/utils/EncryptionUtils.java index c5b8923b5a72..941b3346be29 100644 --- a/app/src/main/java/com/owncloud/android/utils/EncryptionUtils.java +++ b/app/src/main/java/com/owncloud/android/utils/EncryptionUtils.java @@ -115,7 +115,6 @@ public final class EncryptionUtils { private static final String TAG = EncryptionUtils.class.getSimpleName(); // PUBLIC_KEY actually represents certificate this confusion caused by - // backend APIs: GetPublicKeyRemoteOperation() -> returns certificate not public key // later PUBLIC_KEY must rename to CERTIFICATE public static final String PUBLIC_KEY = "PUBLIC_KEY"; diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index a42429b6404e..693a4a9512ee 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -5,7 +5,7 @@ androidCommonLibraryVersion = "0.34.0" androidGifDrawableVersion = "1.2.32" androidImageCropperVersion = "4.7.0" -androidLibraryVersion ="341433fc18b46f7e30a92676741aa44ec987c1f4" +androidLibraryVersion ="c5d456af26" androidOpensslVersion = "3.5.6.1" androidPluginVersion = "9.4.1" androidsvgVersion = "1.4" diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml index 2f47696fd986..5ff3229831fa 100644 --- a/gradle/verification-metadata.xml +++ b/gradle/verification-metadata.xml @@ -23427,6 +23427,14 @@ + + + + + + + +