diff --git a/lib/Activity/DeckProvider.php b/lib/Activity/DeckProvider.php index 78017f3eb5..5ea9a4da82 100644 --- a/lib/Activity/DeckProvider.php +++ b/lib/Activity/DeckProvider.php @@ -183,7 +183,6 @@ protected function setSubjects(IEvent $event, $subject, array $parameters) { $event->setParsedSubject(str_replace($placeholders, $replacements, $subject)) ->setRichSubject($subject, $richParameters); - $event->setSubject($subject, $parameters); } private function getIcon(IEvent $event) { diff --git a/tests/unit/Activity/DeckProviderTest.php b/tests/unit/Activity/DeckProviderTest.php index 18399bc633..ed735d4f67 100644 --- a/tests/unit/Activity/DeckProviderTest.php +++ b/tests/unit/Activity/DeckProviderTest.php @@ -261,6 +261,8 @@ public function testParseObjectTypeCard() { $this->assertEquals('test string Card', $event->getParsedSubject()); $this->assertEquals('test string {card}', $event->getRichSubject()); $this->assertEquals('', $event->getMessage()); + // the subject stays the identifier: notifications reject subjects longer than 64 characters + $this->assertEquals(ActivityManager::SUBJECT_CARD_CREATE, $event->getSubject()); } public function testParseObjectTypeCardWithDiff() { @@ -312,6 +314,7 @@ public function testParseObjectTypeCardWithDiff() { $this->assertEquals('test string {card}', $event->getRichSubject()); $this->assertEquals('BCD', $event->getMessage()); $this->assertEquals('BCD', $event->getParsedMessage()); + $this->assertEquals(ActivityManager::SUBJECT_CARD_UPDATE_DESCRIPTION, $event->getSubject()); } public function testParseParamForBoard() {