From 9281af20d91f274827d4f664784c15eb5baccba0 Mon Sep 17 00:00:00 2001 From: Victor Lin Date: Tue, 3 Nov 2026 15:19:46 -0800 Subject: [PATCH] Harden pytest-forked pin The previous pin assumed that the next release will fix the issue, which is not guaranteed. Instead of allowing another release to potentially break CI, pin to existing versions that are known to work. The pytest and pytest-forked pins are related, so I've added a more detailed comment explaining the situation and what should be done in a likely scenario. --- setup.py | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/setup.py b/setup.py index cd19811d..56046458 100644 --- a/setup.py +++ b/setup.py @@ -132,10 +132,19 @@ def find_namespaced_packages(namespace): "flake8 >=4.0.0", "myst-parser", "nextstrain-sphinx-theme>=2022.5", - # TODO: remove pytest version restriction after pytest-forked fixes compatibility - # + # The pytest and pytest-forked pins are workarounds for two issues + # as of pytest-forked 1.7.5: + # + # 1. incompatibility with pytest≥9.2.0, to be fixed by + # + # 2. a bug that affects our usage, to be fixed by + # + # + # TODO: If all goes well and both are fixed in the same release, we + # can remove the pytest pin and set the newer pytest-forked version + # as minimum. "pytest <9.2.0", - "pytest-forked !=1.7.5", + "pytest-forked <1.7.5", "sphinx>=3", "sphinx-autobuild", "sphinx-markdown-tables !=0.0.16",