# 05ad85d208e64037bd61995f4ba62eac405d4c8c ok 1 assisted-by-is-trailer: no Assisted-by metadata ok 2 co-authored-by-is-trailer: no Co-authored-by metadata ok 3 fixes-url: skipping fixes-url # SKIP ok 4 line-after-title: blank line after title ok 5 line-length: line-lengths are valid not ok 6 signed-off-by: Commit must have a "Signed-off-by" trailer () --- { found: '', compare: '===', wanted: '', at: { line: 0, column: 0, body: [ '', 'PerfettoSessionReader::Deleter issues a final ReadTrace() and then', 'Stop()s the session. Perfetto delivers the read data and the stop', 'notification as independent tasks on its own thread, so the stop could', 'win, close the uv handles and delete the reader while a', 'ReadTraceCallback bound to the raw pointer was still queued. That', 'callback then locked a destroyed mutex and signalled a closed', 'uv_async_t.', '', 'Only tear the reader down once the session has stopped and no read is', 'in flight, and have both Perfetto-thread callbacks update their flag', 'and signal under chunks_mutex_ so the loop thread cannot free the', 'reader in between.', '', 'Refs: https://github.com/nodejs/node/pull/64565' ] } } ... ok 7 subsystem: valid subsystems [src] ok 8 title-format: Title is formatted correctly. ok 9 title-length: Title is <= 50 columns. 0..9 # tests 9 # pass 7 # fail 1 # Please review the commit message guidelines: # https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines npm warn deprecated tap@16.3.10: Versions of tap before v18 are no longer maintained. Please upgrade. npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead npm warn deprecated libtap@1.4.1: This library is no longer used by node-tap, and is unmaintained. npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.