Skip to content

Commit 551eeb6

Browse files
committed
sqlite: use cached strings for property keys
Signed-off-by: Kyungrae Kang <kyungrae2002@gmail.com>
1 parent 6f38736 commit 551eeb6

1 file changed

Lines changed: 6 additions & 18 deletions

File tree

‎src/node_sqlite.cc‎

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,9 +1653,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo<Value>& args) {
16531653
Local<Object> options = args[1].As<Object>();
16541654

16551655
Local<Value> return_arrays_v;
1656-
if (!options
1657-
->Get(env->context(),
1658-
FIXED_ONE_BYTE_STRING(env->isolate(), "returnArrays"))
1656+
if (!options->Get(env->context(), env->return_arrays_string())
16591657
.ToLocal(&return_arrays_v)) {
16601658
return;
16611659
}
@@ -1670,9 +1668,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo<Value>& args) {
16701668
}
16711669

16721670
Local<Value> read_big_ints_v;
1673-
if (!options
1674-
->Get(env->context(),
1675-
FIXED_ONE_BYTE_STRING(env->isolate(), "readBigInts"))
1671+
if (!options->Get(env->context(), env->read_bigints_string())
16761672
.ToLocal(&read_big_ints_v)) {
16771673
return;
16781674
}
@@ -1687,10 +1683,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo<Value>& args) {
16871683
}
16881684

16891685
Local<Value> allow_bare_named_params_v;
1690-
if (!options
1691-
->Get(env->context(),
1692-
FIXED_ONE_BYTE_STRING(env->isolate(),
1693-
"allowBareNamedParameters"))
1686+
if (!options->Get(env->context(), env->allow_bare_named_params_string())
16941687
.ToLocal(&allow_bare_named_params_v)) {
16951688
return;
16961689
}
@@ -1706,10 +1699,7 @@ void DatabaseSync::Prepare(const FunctionCallbackInfo<Value>& args) {
17061699
}
17071700

17081701
Local<Value> allow_unknown_named_params_v;
1709-
if (!options
1710-
->Get(env->context(),
1711-
FIXED_ONE_BYTE_STRING(env->isolate(),
1712-
"allowUnknownNamedParameters"))
1702+
if (!options->Get(env->context(), env->allow_unknown_named_params_string())
17131703
.ToLocal(&allow_unknown_named_params_v)) {
17141704
return;
17151705
}
@@ -4603,10 +4593,8 @@ static void Initialize(Local<Object> target,
46034593
db_tmpl,
46044594
FIXED_ONE_BYTE_STRING(isolate, "isTransaction"),
46054595
DatabaseSync::IsTransactionGetter);
4606-
SetSideEffectFreeGetter(isolate,
4607-
db_tmpl,
4608-
FIXED_ONE_BYTE_STRING(isolate, "limits"),
4609-
DatabaseSync::LimitsGetter);
4596+
SetSideEffectFreeGetter(
4597+
isolate, db_tmpl, env->limits_string(), DatabaseSync::LimitsGetter);
46104598
Local<String> sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type");
46114599
Local<v8::Symbol> sqlite_type_symbol =
46124600
v8::Symbol::For(isolate, sqlite_type_key);

0 commit comments

Comments
 (0)