Skip to content

Commit 6a60729

Browse files
committed
fixup!: broaden LIEF link workaround
Apply the shared LIEF link workaround to major versions >= 1 instead of restricting it to 1.0.0. Keep it until the upstream issue is fixed so a dependency update does not silently reintroduce the link failure. Refs: lief-project/LIEF#1387 Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
1 parent c8b7fb1 commit 6a60729

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/node_sea_bin.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,9 +306,9 @@ InjectOutput InjectIntoPE(const std::vector<uint8_t>& executable,
306306
cfg.resources = true;
307307
cfg.rsrc_section = ".rsrc"; // ensure section name
308308
LIEF::PE::Builder builder(*binary, cfg);
309-
#if LIEF_VERSION_MAJOR == 1 && LIEF_VERSION_MINOR == 0 && \
310-
LIEF_VERSION_PATCH == 0
309+
#if LIEF_VERSION_MAJOR >= 1
311310
// LIEF 1.0.0 does not export the result's bool conversion in shared builds.
311+
// TODO(inoway46): Remove this workaround once the upstream issue is fixed.
312312
// https://github.com/lief-project/LIEF/issues/1387
313313
builder.build();
314314
if (builder.get_build().empty()) {

0 commit comments

Comments
 (0)