test: split test-bench-cli to try deflaking it

I believe the test-bench-cli flakes were just because the
one file was doing too much and on some architectures was
taking too long to complete. This splits up the file.
At the very least, if there's still a flake in here, the
smaller, more focused files should help narrow it down

Signed-off-by: James M Snell <jasnell@gmail.com>

Author: jasnell

test/parallel/test-bench-cli-arguments.js

@@ -0,0 +1,78 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+
+const spawnTimeout = common.platformTimeout(30_000);
+
+function spawnNode(args, options = undefined) {
+  const result = spawnSync(process.execPath, args, {
+    __proto__: null,
+    encoding: 'utf8',
+    timeout: spawnTimeout,
+    ...options,
+  });
+  assert.ifError(result.error);
+  assert.strictEqual(result.signal, null);
+  return result;
+}
+
+function spawnBench(args, options = undefined) {
+  return spawnNode(['--no-warnings', '--bench', ...args], options);
+}
+
+for (const { args, message } of [
+  {
+    args: ['--bench-isolation=invalid', 'unused.js'],
+    message: /invalid value for --bench-isolation/,
+  },
+  {
+    args: ['--bench-samples=0', 'unused.js'],
+    message: /--bench-samples must be greater than 0/,
+  },
+  {
+    args: ['--bench-warmup=4294967296', 'unused.js'],
+    message: /--bench-warmup.*out of range/,
+  },
+  {
+    args: ['--bench-samples=2x', 'unused.js'],
+    message: /invalid value for --bench-samples/,
+  },
+  {
+    args: ['--bench-warmup=abc', 'unused.js'],
+    message: /invalid value for --bench-warmup/,
+  },
+  {
+    args: ['--bench-name-pattern=[', 'unused.js'],
+    message: /invalid regular expression/,
+  },
+  {
+    args: ['--eval=1', 'unused.js'],
+    message: /either --bench or --eval can be used, not both/,
+  },
+  {
+    args: ['--interactive', 'unused.js'],
+    message: /either --bench or --interactive can be used, not both/,
+  },
+  {
+    args: ['--watch', 'unused.js'],
+    message: /either --bench or --watch can be used, not both/,
+  },
+  {
+    args: ['--watch-path=.', 'unused.js'],
+    message: /either --bench or --watch can be used, not both/,
+  },
+  {
+    args: ['--check', 'unused.js'],
+    message: /either --bench or --check can be used, not both/,
+  },
+  {
+    args: ['--test', 'unused.js'],
+    message: /either --bench or --test can be used, not both/,
+  },
+]) {
+  const result = spawnBench(args);
+  assert.notStrictEqual(result.status, 0);
+  assert.match(result.stderr, message);
+}

test/parallel/test-bench-cli-backpressure.js

@@ -0,0 +1,62 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const fixtures = require('../common/fixtures');
+
+const spawnTimeout = common.platformTimeout(30_000);
+
+function spawnNode(args, options = undefined) {
+  const result = spawnSync(process.execPath, args, {
+    __proto__: null,
+    encoding: 'utf8',
+    timeout: spawnTimeout,
+    ...options,
+  });
+  assert.ifError(result.error);
+  assert.strictEqual(result.signal, null);
+  return result;
+}
+
+function spawnBench(args, options = undefined) {
+  return spawnNode(['--no-warnings', '--bench', ...args], options);
+}
+
+function parseRecords(result) {
+  assert.strictEqual(result.stderr, '');
+  return parseOutput(result.stdout);
+}
+
+function parseOutput(output) {
+  return output.trim().split('\n').map((line) => JSON.parse(line));
+}
+
+{
+  const result = spawnBench([
+    `--bench-reporter=${fixtures.fileURL('bench-runner/slow-reporter.cjs')}`,
+    fixtures.path('bench-runner/many-records.cjs'),
+  ]);
+  assert.strictEqual(result.status, 0);
+  assert.strictEqual(result.stderr, '');
+  const report = JSON.parse(result.stdout);
+  assert.strictEqual(report.samples, 30);
+  assert.strictEqual(report.stdout,
+                     Array.from({ length: 30 }, (_, i) => `${i}\n`).join(''));
+}
+
+{
+  const result = spawnBench([
+    '--bench-reporter=json',
+    fixtures.path('bench-runner/acknowledged-records.mjs'),
+  ]);
+  assert.strictEqual(result.status, 0);
+  assert.strictEqual(result.stderr, '');
+  const records = parseRecords(result);
+  const diagnostics = records.filter(
+    ({ type }) => type === 'bench:diagnostic');
+  assert.strictEqual(diagnostics.length, 32);
+  assert(diagnostics.every(
+    ({ data }) => /^acknowledged 10\d{3}$/.test(data.message)));
+  assert.strictEqual(records.at(-1).data.success, true);
+}