Doc on Care Team (Test)

[john-d03]

/document clinical/care team

[github-actions]

✅ Ezhuthachan completed successfully!

[github-actions]

Ezhuthachan

Opened a pull request with all three layers for the encounter care team. I read clinical/care team as the slug clinical/care-team.

• Concept: concepts/clinical/care-team.mdx
• Flow: flows/clinical/manage-encounter-care-team.mdx
• Reference: references/clinical/care-team.mdx

All three are in version-3.0 and mirrored to version-3.1, the flow is listed in both sidebar files, and npm run build is green for en and ml.

A note on scope: the care team is not a standalone model. It is a JSON field on Encounter, written through the set_care_team_members action, so the concept and reference document it as a part of the encounter rather than as its own resource.

Bugs and inconsistencies

1. The care team write path checks the wrong user's permission. In set_care_team_members (care/emr/api/viewsets/encounter.py) the loop over request_data.members calls AuthorizationController.call("can_view_encounter_obj", request.user, encounter) — it passes the requesting user, not user_obj, the member being added. The error message ("Treating doctor does not have permission on encounter") says the intent is to check the member. As written the check is invariant across the loop and can never reject a member. Confidence: high.

2. sync_care_team_users_cache cannot handle the model default. Encounter.care_team defaults to {} (a dict), but sync_care_team_users_cache() in care/emr/models/encounter.py only rebuilds the cache when care_team is a list. The default is therefore never the same type as the stored value, and a JSONField(default=list) would match the real shape. Harmless today, but the dict default contradicts every read and write path. Confidence: high.

3. The primary member is positional and undeclared. The frontend treats care_team[0] as the primary member (CareTeamSheet.tsx, EncounterInfoCard.tsx, PrintChargeItems.tsx), and "Mark as Primary" simply reorders the list. Nothing in the backend spec marks or preserves that meaning, so any client that reorders the list silently changes who is primary. Confidence: medium — the behaviour is intentional, but it is undocumented in the API contract.

Open questions

None blocking. If the intended slug was something other than clinical/care-team, say so and I will rename in the same pull request.

Generated by Ezhuthachan for #58 · opus50 · 276.6 AIC · ⌖ 13.7 AIC · ⊞ 14.4K · ◷
_{Comment /document to run again}

[github-actions]

Comment Memory

# Care team (encounter) — findings

- `/document clinical/care team` (issue #58) was read as slug `clinical/care-team`.
- Care team is NOT a standalone model. It is `Encounter.care_team` (JSONField, list of
  `{user_id: int, role: Coding}`) plus the `care_team_users` int-array cache.
- Write path: `POST /api/v1/encounter/{id}/set_care_team_members/`, full replacement.
  Specs: `EncounterCareTeamMemberSpec` / `EncounterCareTeamMemberWriteSpec`.
- Role value set: `PRACTITIONER_ROLE_VALUESET`, slug `system-practitioner-role-code`,
  SNOMED `223366009` + `224930009`.
- Permissions: no dedicated care team permission. Read = `can_read_encounter`,
  write = `can_write_encounter`, both `CLINICAL_DATA_ACCESS_ROLES`
  (Admin, Doctor, Nurse, Facility Admin). Write blocked on completed encounters.
- Primary member = `care_team[0]`, positional only.
- No keyboard shortcut for the care team action; `Shift + E` opens the command dialog.
- Sidebars differ between versions: 3.0 has a flat `flows/clinical` items list,
  3.1 nests a `Patient` sub-category. Edit each in place; do not copy one over the other.

## Bugs reported on #58
1. `set_care_team_members` passes `request.user` (not `user_obj`) to
   `can_view_encounter_obj` — the per-member check can never reject a member.
2. `Encounter.care_team` defaults to `{}` but `sync_care_team_users_cache()` only
   handles a list.
3. Primary member is positional and undeclared in the API contract.

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

Generated by Ezhuthachan for #58 · opus50 · 276.6 AIC · ⌖ 13.7 AIC · ⊞ 14.4K · ◷
_{Comment /document to run again}