fix(configs): retain optional package update semantics

Author: fullstackjam

src/routes/api/configs/+server.ts

@@ -146,7 +146,7 @@ export const POST: RequestHandler = async ({ platform, cookies, request }) => {
 	}
 
 	const id = generateId();
-	const selectedPackages = normalizePackages(packages || [], snapshot?.packages, false);
+	const selectedPackages = normalizePackages(packages || [], snapshot?.packages, packages === undefined);
 
 	try {
 		await createConfig(env.DB, {

src/routes/api/configs/[slug]/+server.ts

@@ -187,7 +187,7 @@ export const PUT: RequestHandler = async ({ platform, cookies, params, request }
 
 	let snapshotToSave = snapshot;
 	let selectedPackages: ReturnType<typeof normalizePackages> | undefined;
-	if (packages !== undefined) {
+	if (packages !== undefined && packages !== null) {
 		let previousSnapshot = null;
 		if (snapshot === undefined && existing.snapshot) {
 			try {

src/routes/api/configs/[slug]/server.test.ts

@@ -425,3 +425,14 @@ describe('package source save round-trip', () => {
 		expect(empty.config.packages).toEqual([]);
 	});
 });
+
+describe('optional package updates', () => {
+	it('retains the software selection when packages is null', async () => {
+		await seed(db, { users: [userRow()], configs: [mockConfig], api_tokens: [mockApiToken] });
+		const updated = await call(PUT, callOpts({ method: 'PUT', token: mockApiToken.token, body: { packages: null } }));
+		expect(updated.status).toBe(200);
+		const read = await call(GET, callOpts({ token: mockApiToken.token }));
+		const data = (await read.json()) as { config: { packages: unknown[] } };
+		expect(data.config.packages).toEqual(JSON.parse(mockConfig.packages));
+	});
+});

src/routes/api/configs/server.test.ts

@@ -302,3 +302,22 @@ describe('snapshot source normalization', () => {
 		]);
 	});
 });
+
+describe('snapshot-only config creation', () => {
+	it('preserves sources when the software selection is omitted', async () => {
+		await seed(db, { users: [userRow()], api_tokens: [mockApiToken] });
+		const response = await call(POST, {
+			url: baseUrl,
+			method: 'POST',
+			token: mockApiToken.token,
+			body: { name: 'Sources only', snapshot: { packages: { taps: ['example/tools'] } } }
+		});
+		expect(response.status).toBe(201);
+		const created = (await response.json()) as { slug: string };
+		const list = await call(GET, { url: baseUrl, token: mockApiToken.token });
+		const data = (await list.json()) as { configs: { slug: string; packages: { name: string; type: string }[] }[] };
+		expect(data.configs.find((config) => config.slug === created.slug)?.packages).toEqual([
+			{ name: 'example/tools', type: 'tap' }
+		]);
+	});
+});