Skip to content

LinkCreate is poorly named #345

Description

@andrewjstone

The api endpoint link_create takes a LinkCreate struct as a parameter. This is also included inside LinkSettings and used all over the place internally. However, looking at what this struct contains, it's clear, that this is a container for the layer 1, physical properties of the links.

I suggest renaming this to PhysicalLinkProps or something similar to clarify the code and APIs.

This will require an API version bump.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions