From 579301bbe7112e37b1cbbd500cce5d9769d8b748 Mon Sep 17 00:00:00 2001 From: Rebecca Alpert Date: Wed, 17 Jun 2026 15:12:30 -0400 Subject: [PATCH 1/2] fix(AngleUpIcon): Replace AngleUpIcon with RhMicronsCaretUpIcon Co-authored-by: Cursor --- .../components/SearchInput/SearchInput.tsx | 4 +- .../__snapshots__/SearchInput.test.tsx.snap | 40 ++++--------------- 2 files changed, 10 insertions(+), 34 deletions(-) diff --git a/packages/react-core/src/components/SearchInput/SearchInput.tsx b/packages/react-core/src/components/SearchInput/SearchInput.tsx index 8cc1f77266f..6f5dc048d4d 100644 --- a/packages/react-core/src/components/SearchInput/SearchInput.tsx +++ b/packages/react-core/src/components/SearchInput/SearchInput.tsx @@ -3,7 +3,7 @@ import { css } from '@patternfly/react-styles'; import { Button, ButtonVariant } from '../Button'; import { Badge } from '../Badge'; import { Icon } from '../Icon'; -import AngleUpIcon from '@patternfly/react-icons/dist/esm/icons/angle-up-icon'; +import RhMicronsCaretUpIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-up-icon'; import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon'; import RhMicronsSearchIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-search-icon'; import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; @@ -332,7 +332,7 @@ const SearchInputBase: React.FunctionComponent = ({ aria-label={previousNavigationButtonAriaLabel} isDisabled={isDisabled || isPreviousNavigationButtonDisabled} onClick={onPreviousClick} - icon={} + icon={} /> @@ -859,24 +847,12 @@ exports[`SearchInput simple search input 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + From 9b83a069c462e125613fd5326c2933d3754db36c Mon Sep 17 00:00:00 2001 From: Rebecca Alpert Date: Wed, 8 Jul 2026 13:12:59 -0400 Subject: [PATCH 2/2] Address feedback and Figma updates --- .../src/components/SearchInput/SearchInput.tsx | 7 ++++--- .../__snapshots__/SearchInput.test.tsx.snap | 14 +++++++------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/packages/react-core/src/components/SearchInput/SearchInput.tsx b/packages/react-core/src/components/SearchInput/SearchInput.tsx index 6f5dc048d4d..a0f71c06fed 100644 --- a/packages/react-core/src/components/SearchInput/SearchInput.tsx +++ b/packages/react-core/src/components/SearchInput/SearchInput.tsx @@ -6,7 +6,8 @@ import { Icon } from '../Icon'; import RhMicronsCaretUpIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-up-icon'; import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon'; import RhMicronsSearchIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-search-icon'; -import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; +import RhMicronsArrowRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-arrow-right-icon'; +import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; import { AdvancedSearchMenu } from './AdvancedSearchMenu'; import { TextInputGroup, TextInputGroupMain, TextInputGroupUtilities } from '../TextInputGroup'; @@ -339,7 +340,7 @@ const SearchInputBase: React.FunctionComponent = ({ aria-label={nextNavigationButtonAriaLabel} isDisabled={isDisabled || isNextNavigationButtonDisabled} onClick={onNextClick} - icon={} + icon={} /> )} @@ -478,7 +479,7 @@ const SearchInputBase: React.FunctionComponent = ({ isDisabled={isDisabled} icon={ - + } /> diff --git a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap index 77b42f196e8..3d7348cd8cb 100644 --- a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap +++ b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap @@ -129,7 +129,7 @@ exports[`SearchInput advanced search 1`] = ` width="1em" > @@ -272,7 +272,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = ` width="1em" > @@ -605,7 +605,7 @@ exports[`SearchInput renders search input in strict mode 1`] = ` width="1em" > @@ -714,7 +714,7 @@ exports[`SearchInput search input with hint 1`] = ` width="1em" > @@ -773,7 +773,7 @@ exports[`SearchInput search input with hint 1`] = ` width="1em" > @@ -874,7 +874,7 @@ exports[`SearchInput simple search input 1`] = ` width="1em" > @@ -933,7 +933,7 @@ exports[`SearchInput simple search input 1`] = ` width="1em" >