Skip to content

sapi_cli_server_send_headers does not check return value of php_cli_server_client_send_through #23425

Description

@Sjord

Description

php_cli_server_client_send_through can fail without bailing out, if ignore_user_abort=1. sapi_cli_server_send_headers then fails, but it returns SAPI_HEADER_SENT_SUCCESSFULLY.

In sapi/cli/php_cli_server.c:

	php_cli_server_client_send_through(client, ZSTR_VAL(buffer.s), ZSTR_LEN(buffer.s));

	smart_str_free(&buffer);
	return SAPI_HEADER_SENT_SUCCESSFULLY;
}

PHP Version

master

Operating System

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions