[3.14] gh-159864: Fix syslog.openlog() crash with concurrent sys.argv changes (GH-159884)

syslog_get_argv() took sys.argv[0] with PyList_GetItem() and increfed it
only afterwards, so on the free-threaded build a concurrent replacement of
sys.argv[0] could free it in between. Use PyList_GetItemRef() instead.
(cherry picked from commit e5e0748)

Co-authored-by: Junhyung Lee <70549809+espressolee@users.noreply.github.com>
Co-authored-by: Lazizbek Ergashev <20501725+lazerg@users.noreply.github.com>

Author: 2 people

Lib/test/test_syslog.py

@@ -52,6 +52,29 @@ def test_openlog_noargs(self):
         syslog.openlog()
         syslog.syslog('test message from python test_syslog')
 
+    @threading_helper.requires_working_threading()
+    def test_racing_openlog_argv(self):
+        # gh-159864: openlog() without an ident reads sys.argv[0] while
+        # another thread replaces it.
+        argv = ["prog"]
+        nthreads = 32
+
+        def opener():
+            for _ in range(1000):
+                syslog.openlog()
+
+        def writer():
+            for i in range(1000):
+                argv[0] = f"prog-{i}"
+
+        with support.swap_attr(sys, "argv", argv):
+            try:
+                threading_helper.run_concurrently(
+                    worker_func=[opener] * (nthreads - 1) + [writer],
+                )
+            finally:
+                syslog.closelog()
+
     @threading_helper.requires_working_threading()
     def test_syslog_threaded(self):
         start = threading.Event()

Misc/NEWS.d/next/Library/2026-10-20-12-30-00.gh-issue-159864.4FZ6MR.rst

@@ -0,0 +1,2 @@
+Fix a crash in :func:`syslog.openlog` under the free-threaded build when
+:data:`sys.argv` is modified concurrently.

Modules/syslogmodule.c

@@ -107,8 +107,7 @@ syslog_get_argv(void)
         return NULL;
     }
 
-    scriptobj = PyList_GetItem(argv, 0);
-    Py_XINCREF(scriptobj);
+    scriptobj = PyList_GetItemRef(argv, 0);
     Py_DECREF(argv);
     if (scriptobj == NULL) {
         PyErr_Clear();