Repository navigation
Commit 08fd98b
`struct.pack_into()` can use the same bytearray as both the destination and an `s` or `p` value. The copy then passes overlapping regions to `memcpy`, which is undefined in C and can produce platform-dependent results or a sanitizer abort. `memmove` makes the overlapping copy defined.
(cherry picked from commit 31a7d99)
Co-authored-by: Jelle Zijlstra <jelle@openai.com>
1 parent b25122e commit 08fd98b
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2366 | 2366 | | |
2367 | 2367 | | |
2368 | 2368 | | |
2369 | | - | |
| 2369 | + | |
2370 | 2370 | | |
2371 | 2371 | | |
2372 | 2372 | | |
| |||
2392 | 2392 | | |
2393 | 2393 | | |
2394 | 2394 | | |
2395 | | - | |
| 2395 | + | |
2396 | 2396 | | |
2397 | 2397 | | |
2398 | 2398 | | |
| |||
0 commit comments