[3.14] gh-160326: Raise ValueError for a NaN timeout in Condition.wait() (GH-160327) (#160417)

gh-160326: Raise ValueError for a NaN timeout in Condition.wait() (GH-160327)

A NaN timeout was treated as zero, which made the deadline loops built
on Condition.wait(), such as Queue.get() and Semaphore.acquire(), spin
without ever timing out.
(cherry picked from commit 3387b19)

Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>

Author: miss-islington

Lib/test/lock_tests.py

@@ -557,6 +557,10 @@ def f():
         for r, dt in results2:
             self.assertTrue(r)
 
+    def test_nan_timeout(self):
+        evt = self.eventtype()
+        self.assertRaises(ValueError, evt.wait, float('nan'))
+
     def test_set_and_clear(self):
         # gh-57711: check that wait() returns true even when the event is
         # cleared before the waiting thread is woken up.
@@ -755,6 +759,14 @@ def f():
             # In practice, this implementation has no spurious wakeups.
             self.assertFalse(result)
 
+    def test_nan_timeout(self):
+        cond = self.condtype()
+        nan = float('nan')
+        with cond:
+            self.assertRaises(ValueError, cond.wait, nan)
+            self.assertRaises(ValueError, cond.wait_for, lambda: False, nan)
+            self.assertEqual(len(cond._waiters), 0)
+
     def test_waitfor(self):
         cond = self.condtype()
         state = 0

Lib/threading.py

@@ -369,10 +369,11 @@ def wait(self, timeout=None):
                 waiter.acquire()
                 gotit = True
             else:
-                if timeout > 0:
-                    gotit = waiter.acquire(True, timeout)
-                else:
+                if timeout <= 0:
                     gotit = waiter.acquire(False)
+                else:
+                    # A NaN timeout is rejected by acquire().
+                    gotit = waiter.acquire(True, timeout)
             return gotit
         finally:
             self._acquire_restore(saved_state)

Misc/NEWS.d/next/Library/2026-10-22-18-30-00.gh-issue-160326.nAn7Tq.rst

@@ -0,0 +1,5 @@
+Raise :exc:`ValueError` for a NaN *timeout* in
+:meth:`threading.Condition.wait` and the blocking calls built on it, such as
+:meth:`threading.Event.wait`, :meth:`threading.Semaphore.acquire` and
+:meth:`queue.Queue.get`, instead of returning at once or looping without ever
+timing out.