[3.14] gh-156078: Prevent ZipFile.mkdir() during an active write (GH-156079) (#160478)

Fix `ZipFile.mkdir()` so that it raises `ValueError` when another writable
member handle returned by `ZipFile.open(..., mode="w")` is still open.
(cherry picked from commit dc78afe)

Co-authored-by: Pengyu Lee <lipengyu@kylinos.cn>
Co-authored-by: Stan Ulbrych <stan@python.org>

Author: 3 people

Lib/test/test_zipfile/test_core.py

@@ -2447,6 +2447,8 @@ def test_open_conflicting_handles(self):
                     zipf.writestr('str', 'abcde')
                 with self.assertRaises(ValueError):
                     zipf.write(__file__, 'file')
+                with self.assertRaises(ValueError):
+                    zipf.mkdir('directory')
                 with self.assertRaises(ValueError):
                     zipf.close()
                 w1.write(msg2)
@@ -3476,6 +3478,9 @@ def test_mkdir(self):
             zf.extractall(target)
             self.assertEqual(set(os.listdir(target)), {"directory", "directory2", "directory3", "directory4"})
 
+        with self.assertRaises(ValueError):
+            zf.mkdir("closed")
+
     def test_create_directory_with_write(self):
         with zipfile.ZipFile(TESTFN, "w") as zf:
             zf.writestr(zipfile.ZipInfo('directory/'), '')

Lib/zipfile/__init__.py

@@ -2082,6 +2082,15 @@ def mkdir(self, zinfo_or_directory_name, mode=511):
         else:
             raise TypeError("Expected type str or ZipInfo")
 
+        if not self.fp:
+            raise ValueError(
+                "Attempt to write to ZIP archive that was already closed"
+            )
+        if self._writing:
+            raise ValueError(
+                "Can't write to ZIP archive while an open writing handle exists."
+            )
+
         with self._lock:
             if self._seekable:
                 self.fp.seek(self.start_dir)

Misc/NEWS.d/next/Library/2026-08-20-09-56-45.gh-issue-156078.-E7gZc.rst

@@ -0,0 +1,2 @@
+:meth:`zipfile.ZipFile.mkdir` now raises :exc:`ValueError` when the archive
+is closed or when a writable member handle is open.