Skip to content

Commit 7ce4da3

Browse files
itamaroclaude
andcommitted
Apply review suggestions to test_build_details
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y2CKGDURpDRVEHD7FfWnps
1 parent 5f35442 commit 7ce4da3

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎Lib/test/test_build_details.py‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,10 @@ def test_libpython_static(self):
184184
if 'static' not in value:
185185
self.skipTest("No static libpython")
186186

187-
# Skip check if installation is relocated
188187
if sysconfig._installation_is_relocated():
189188
self.skipTest("Installation is relocated")
190189

191-
# The path must name an installed static library (an ar archive).
190+
# The path must name an installed static library (an 'ar' archive).
192191
with open(value['static'], 'rb') as f:
193192
self.assertEqual(f.read(8), b'!<arch>\n')
194193

@@ -256,7 +255,7 @@ def test_round_trip(self):
256255
generate_build_details is None,
257256
"Failed to import generate-build-details"
258257
)
259-
@unittest.skipIf(os.name != 'posix', 'Feature only implemented on POSIX right now')
258+
@unittest.skipIf(os.name != 'posix', 'Feature only implemented on POSIX')
260259
@unittest.skipIf(is_wasm32, 'Feature not available on WebAssembly builds')
261260
class BuildDetailsLibpythonTests(unittest.TestCase):
262261
LIBDIR = '/prefix/lib'

0 commit comments

Comments
 (0)