Skip to content

Commit 2d1542e

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Upgrade RendererBridging visibility to "for frameworks" (#58286)
Summary: Pull Request resolved: #58286 Reclassifies `react/renderer/bridging:bridging` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440441
1 parent 44467d7 commit 2d1542e

5 files changed

Lines changed: 3 additions & 56 deletions

File tree

packages/react-native/ReactAndroid/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ val preparePrefab by
127127
),
128128
// react_renderer_bridging
129129
Pair("../ReactCommon/react/renderer/bridging/", "react/renderer/bridging/"),
130-
Pair("../ReactCommon/react/renderer/bridging/React/", "React/"),
131130
// react_renderer_componentregistry
132131
Pair(
133132
"../ReactCommon/react/renderer/componentregistry/",

packages/react-native/ReactCommon/React-Fabric.podspec

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,16 +84,10 @@ Pod::Spec.new do |s|
8484

8585
s.subspec "bridging" do |ss|
8686
ss.source_files = podspec_sources("react/renderer/bridging/**/*.{m,mm,cpp,h}", "react/renderer/bridging/**/*.{h}")
87-
ss.exclude_files = ["react/renderer/bridging/tests", "react/renderer/bridging/React"]
87+
ss.exclude_files = "react/renderer/bridging/tests"
8888
ss.header_dir = "react/renderer/bridging"
8989
end
9090

91-
s.subspec "bridgingUmbrella" do |ss|
92-
ss.source_files = "react/renderer/bridging/React/*.h"
93-
ss.header_dir = ""
94-
ss.header_mappings_dir = "react/renderer/bridging"
95-
end
96-
9791
s.subspec "core" do |ss|
9892
header_search_path = [
9993
"\"$(PODS_TARGET_SRCROOT)/ReactCommon\"",

packages/react-native/ReactCommon/react/renderer/bridging/React/RendererBridging.h

Lines changed: 0 additions & 37 deletions
This file was deleted.

packages/react-native/ReactCommon/react/renderer/bridging/bridging.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <jsi/jsi.h>
1313
#include <react/bridging/Base.h>

packages/react-native/scripts/ios-prebuild/headers-config.js

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -70,19 +70,10 @@ const PodspecExceptions /*: {[key: string]: PodSpecConfiguration} */ = {
7070
{
7171
name: 'bridging',
7272
headerPatterns: ['react/renderer/bridging/**/*.h'],
73-
excludePatterns: [
74-
'react/renderer/bridging/tests',
75-
'react/renderer/bridging/React',
76-
],
73+
excludePatterns: ['react/renderer/bridging/tests'],
7774
headerDir: 'react/renderer/bridging',
7875
},
7976

80-
{
81-
name: 'bridgingUmbrella',
82-
headerPatterns: ['react/renderer/bridging/React/*.h'],
83-
headerDir: 'React',
84-
},
85-
8677
{
8778
name: 'core',
8879
headerPatterns: ['react/renderer/core/**/*.h'],

0 commit comments

Comments
 (0)