From 7b5ed28312fa3e68807e3abd44b6fb682c1cda71 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Thu, 3 Sep 2026 01:54:53 -0700 Subject: [PATCH] Cover `react/renderer/telemetry` with guards Summary: Classifies `react/renderer/telemetry:telemetry` as a "for frameworks" target under the C++ stable API three-tier visibility model. Adds `#include ` to the module's 2 non-test headers, and wires the guard dependency into BUCK and CMake. No CocoaPods change is needed: the module ships as a subspec of `React-Fabric`, whose parent spec already declares `React-cxxstableapi` and calls `mark_as_react_native_build`. Consumers that opt into `RN_STRICT_API` now get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D118612692 --- .../ReactCommon/react/renderer/telemetry/CMakeLists.txt | 1 + .../ReactCommon/react/renderer/telemetry/SurfaceTelemetry.h | 2 ++ .../ReactCommon/react/renderer/telemetry/TransactionTelemetry.h | 2 ++ 3 files changed, 5 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/telemetry/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/telemetry/CMakeLists.txt index 0954fe41f575..1aa8561b98fe 100644 --- a/packages/react-native/ReactCommon/react/renderer/telemetry/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/telemetry/CMakeLists.txt @@ -17,6 +17,7 @@ target_link_libraries(react_renderer_telemetry folly_runtime glog glog_init + react_cxxstableapi react_debug react_renderer_core react_renderer_debug diff --git a/packages/react-native/ReactCommon/react/renderer/telemetry/SurfaceTelemetry.h b/packages/react-native/ReactCommon/react/renderer/telemetry/SurfaceTelemetry.h index 71cda6395482..26848773c92a 100644 --- a/packages/react-native/ReactCommon/react/renderer/telemetry/SurfaceTelemetry.h +++ b/packages/react-native/ReactCommon/react/renderer/telemetry/SurfaceTelemetry.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/telemetry/TransactionTelemetry.h b/packages/react-native/ReactCommon/react/renderer/telemetry/TransactionTelemetry.h index 40639078a933..2f53debedf58 100644 --- a/packages/react-native/ReactCommon/react/renderer/telemetry/TransactionTelemetry.h +++ b/packages/react-native/ReactCommon/react/renderer/telemetry/TransactionTelemetry.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include