Skip to content

Request abortion does not work #6

Description

@rubengees

Hi! I am using this module transitively through https://github.com/nuxt-alt/http and request cancellation using an AbortController is not working since version 1.0.15.

This is because the signal is getting overriden by the one this lib uses to implement timeouts from what it looks like:

// index.mjs:268
dispatchRequest_fn = async function(config) {
  const controller = new AbortController();
  const timeoutSignal = config.timeout ? setTimeout(() => controller.abort(), config.timeout) : void 0;
  const $ofetch = this.getFetch();
  let response;
  config = config.timeout ? { ...config, signal: controller.signal } : config;
  config = __privateMethod(this, _addXSRFHeader, addXSRFHeader_fn).call(this, config);
  ...
}

My code:

const abortController = new AbortController()
abortController.abort()
await $http.$get("/", { signal: abortController.signal })

In version 1.0.14 this is getting cancelled as expected, starting from version 1.0.15 it is not.

Thanks for looking.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions