Merge remote-tracking branch 'origin/master' into nd-dot-ix2

# Conflicts:
#	src/indexes.rs
#	src/iterators/mod.rs

Author: EbrahimEldesoky

.github/workflows/latest-deps.yaml

@@ -1,12 +1,9 @@
 name: Check Latest Dependencies
 on:
   schedule:
-    # Chosen so that it runs right before the international date line experiences the weekend.
-    # Since we're open source, that means globally we should be aware of it right when we have the most
-    # time to fix it.
-    #
-    # Sorry if this ruins your weekend, future maintainer...
-    - cron: '0 12 * * FRI'
+    # Daily, so that new Rust releases (lints, deprecations) or dependency releases that break
+    # the build are caught before they show up as failures on unrelated PRs.
+    - cron: '0 12 * * *'
   workflow_dispatch: # For running manually
   pull_request:
     paths:
@@ -20,6 +17,24 @@ env:
   MSRV: 1.87.0
 
 jobs:
+  latest_clippy_stable:
+    runs-on: ubuntu-latest
+    name: Check Clippy with Latest Dependencies on Stable
+    steps:
+      - name: Check Out Repo
+        uses: actions/checkout@v4
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: stable
+          components: clippy
+      - name: Setup Rust Cache
+        uses: Swatinem/rust-cache@v2
+      - name: Ensure latest dependencies
+        run: cargo update
+      - name: Run Clippy
+        run: cargo clippy -F "$FEATURES"
+
   latest_deps_stable:
     runs-on: ubuntu-latest
     name: Check Latest Dependencies on Stable

Cargo.lock

@@ -46,7 +46,7 @@ rayon = { version = "1.10.0", optional = true }
 cblas-sys = { workspace = true, optional = true }
 libc = { version = "0.2.82", optional = true }
 
-matrixmultiply = { version = "0.3.2", default-features = false, features=["cgemm"] }
+matrixmultiply = { version = "0.3.11", default-features = false, features=["avx512", "cgemm"] }
 
 serde = { version = "1.0", optional = true, default-features = false, features = ["alloc"] }
 rawpointer = { version = "0.2" }
@@ -105,8 +105,8 @@ num-complex = { version = "0.4", default-features = false }
 approx = { version = "0.5", default-features = false }
 quickcheck = { version = "1.0", default-features = false }
 proptest = { version = "1.3.1" }
-rand = { version = "0.9.0", features = ["small_rng"] }
-rand_distr = { version = "0.5.0" }
+rand = { version = "0.10.0" }
+rand_distr = { version = "0.6.0" }
 itertools = { version = "0.13.0", default-features = false, features = ["use_std"] }
 cblas-sys = { version = "0.1.4", default-features = false }
 

Cargo.toml

@@ -108,7 +108,6 @@ Basic operations on arrays are all element-wise; you need to use specific method
 ```rust
 use ndarray::prelude::*;
 use ndarray::Array;
-use std::f64::INFINITY as inf;
 
 fn main() {
     let a = array![
@@ -119,7 +118,7 @@ fn main() {
     assert_eq!(&a + &b, array![[10., 21., 32., 43.,]]);  // Allocates a new array. Note the explicit `&`.
     assert_eq!(&a - &b, array![[10., 19., 28., 37.,]]);
     assert_eq!(&a * &b, array![[0., 20., 60., 120.,]]);
-    assert_eq!(&a / &b, array![[inf, 20., 15., 13.333333333333334,]]);
+    assert_eq!(&a / &b, array![[f64::INFINITY, 20., 15., 13.333333333333334,]]);
 }
 ```
 
@@ -306,7 +305,7 @@ use std::iter::FromIterator;
 
 fn main() {
     // Or you may use ndarray_rand crate to generate random arrays
-    // let a = Array::random((2, 5), Uniform::new(0., 10.));
+    // let a = Array::random((2, 5), Uniform::new(0., 10.).unwrap());
 
     let a = array![
         [3., 7., 3., 4.],

README-quick-start.md

@@ -10,7 +10,7 @@ use std::fmt;
 
 use ndarray_rand::RandomExt;
 use rand::rngs::SmallRng;
-use rand::{Rng, SeedableRng};
+use rand::{RngExt, SeedableRng};
 
 use ndarray::linalg::general_mat_mul;
 use ndarray::prelude::*;
@@ -86,7 +86,7 @@ where
 #[test]
 fn accurate_eye_f32()
 {
-    let rng = &mut SmallRng::from_os_rng();
+    let rng = &mut SmallRng::from_rng(&mut rand::rng());
     for i in 0..20 {
         let eye = Array::eye(i);
         for j in 0..20 {
@@ -114,7 +114,7 @@ fn accurate_eye_f32()
 #[test]
 fn accurate_eye_f64()
 {
-    let rng = &mut SmallRng::from_os_rng();
+    let rng = &mut SmallRng::from_rng(&mut rand::rng());
     let abs_tol = 1e-15;
     for i in 0..20 {
         let eye = Array::eye(i);
@@ -209,7 +209,7 @@ where
     A: fmt::Debug,
 {
     // pick a few random sizes
-    let mut rng = SmallRng::from_os_rng();
+    let mut rng = SmallRng::from_rng(&mut rand::rng());
     for i in 0..20 {
         let (c, reference) = random_matrix_mul(&mut rng, i > 10, use_general, gen::<A, _>);
 
@@ -241,7 +241,7 @@ where
     A: fmt::Debug,
 {
     // pick a few random sizes
-    let mut rng = SmallRng::from_os_rng();
+    let mut rng = SmallRng::from_rng(&mut rand::rng());
     for i in 0..20 {
         let (c, reference) = random_matrix_mul(&mut rng, i > 10, true, gen_complex::<A, _>);
 
@@ -259,7 +259,7 @@ where
 fn accurate_mul_with_column_f64()
 {
     // pick a few random sizes
-    let rng = &mut SmallRng::from_os_rng();
+    let rng = &mut SmallRng::from_rng(&mut rand::rng());
     for i in 0..10 {
         let m = rng.random_range(1..128);
         let k = rng.random_range(1..350);

crates/numeric-tests/tests/accuracy.rs

@@ -1,6 +1,6 @@
 [package]
 name = "ndarray-rand"
-version = "0.16.0"
+version = "0.17.0"
 edition = "2018"
 authors = ["bluss"]
 license = "MIT OR Apache-2.0"
@@ -29,7 +29,7 @@ rand_distr = { workspace = true }
 quickcheck = { workspace = true, optional = true }
 
 [dev-dependencies]
-rand_isaac = "0.4.0"
+rand_isaac = "0.5.0"
 quickcheck = { workspace = true }
 
 [package.metadata.release]

ndarray-rand/Cargo.toml

@@ -15,7 +15,7 @@ use ndarray_rand::RandomExt;
 use ndarray_rand::rand_distr::Uniform;
 
 fn main() {
-    let a = Array::random((2, 5), Uniform::new(0., 10.));
+    let a = Array::random((2, 5), Uniform::new(0., 10.).unwrap());
     println!("{:8.4}", a);
     // Example Output:
     // [[  8.6900,   6.9824,   3.8922,   6.5861,   2.4890],

ndarray-rand/README.md

@@ -1,6 +1,10 @@
 Recent Changes
 --------------
 
+- 0.17.0
+
+  - Bump `rand` to 0.10.0 and `rand_distr` to 0.6.0
+
 - 0.16.0
 
   - Require ndarray 0.17.1

ndarray-rand/RELEASES.md

@@ -12,16 +12,16 @@
 //!
 //! ## Note
 //!
-//! `ndarray-rand` depends on [`rand` 0.9][rand].
+//! `ndarray-rand` depends on [`rand` 0.10][rand].
 //!
 //! [`rand`][rand] and [`rand_distr`][rand_distr]
 //! are re-exported as sub-modules, [`ndarray_rand::rand`](rand)
 //! and [`ndarray_rand::rand_distr`](rand_distr) respectively.
 //! You can use these submodules for guaranteed version compatibility or
 //! convenience.
 //!
-//! [rand]: https://docs.rs/rand/0.9
-//! [rand_distr]: https://docs.rs/rand_distr/0.5
+//! [rand]: https://docs.rs/rand/0.10
+//! [rand_distr]: https://docs.rs/rand_distr/0.6
 //!
 //! If you want to use a random number generator or distribution from another crate
 //! with `ndarray-rand`, you need to make sure that the other crate also depends on the

ndarray-rand/src/lib.rs

@@ -375,18 +375,24 @@ pub trait Dimension:
         IxDyn(self.slice())
     }
 
+    /// Creates a dimension of this type from a slice of axis lengths.
+    ///
+    /// Returns `None` if the slice length is incompatible with this
+    /// dimension type's dimensionality
+    fn from_slice(ix: &[Ix]) -> Option<Self>
+    {
+        if Self::NDIM.is_some_and(|n| n != ix.len()) {
+            return None;
+        }
+        let mut s = Self::zeros(ix.len());
+        s.slice_mut().copy_from_slice(ix);
+        Some(s)
+    }
+
     #[doc(hidden)]
     fn from_dimension<D2: Dimension>(d: &D2) -> Option<Self>
     {
-        let mut s = Self::default();
-        if s.ndim() == d.ndim() {
-            for i in 0..d.ndim() {
-                s[i] = d[i];
-            }
-            Some(s)
-        } else {
-            None
-        }
+        Self::from_slice(d.slice())
     }
 
     #[doc(hidden)]
@@ -584,15 +590,6 @@ impl Dimension for Dim<[Ix; 1]>
     {
         self.remove_axis(axis)
     }
-
-    fn from_dimension<D2: Dimension>(d: &D2) -> Option<Self>
-    {
-        if 1 == d.ndim() {
-            Some(Ix1(d[0]))
-        } else {
-            None
-        }
-    }
     private_impl! {}
 }
 
@@ -1003,9 +1000,9 @@ impl Dimension for IxDyn
         }
     }
 
-    fn from_dimension<D2: Dimension>(d: &D2) -> Option<Self>
+    fn from_slice(ix: &[Ix]) -> Option<Self>
     {
-        Some(IxDyn(d.slice()))
+        Some(IxDyn(ix))
     }
 
     fn into_dyn(self) -> IxDyn