Skip to content

Commit 2c5da98

Browse files
Address review: preserve run-test exit and cite OTE backports
Capture run-test failure across junit synthesis, and document the openstack-test backport PRs alongside #303. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 8e482d6 commit 2c5da98

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

collection/stages/roles/openstack_test/tasks/run_openstack_test.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
openstack_test_junit_path: >-
1515
{{ openstack_test_results_dir }}/junit_e2e_openstack.xml
1616
# Upstream dropped make openstack-tests on release-4.20+ (OTE migration,
17-
# openshift/openstack-test#303 / OSASINFRA-4375). Older release branches
18-
# still ship the legacy target.
17+
# openshift/openstack-test#303 / OSASINFRA-4375; backports #306/#307/#308).
18+
# Older release branches still ship the legacy target.
1919
openstack_test_use_ote: "{{ discovered_openshift_release is version('4.20', '>=') }}"
2020

2121
- name: Set openstack-test executable path for OTE
@@ -147,7 +147,7 @@
147147
ansible.builtin.shell: |
148148
set -o pipefail
149149
cat {{ tests_to_run_path }} | {{ openstack_test_executable }} run-test \
150-
> {{ openstack_test_log_path }}
150+
> {{ openstack_test_log_path }} || run_exit=$?
151151
python3 - {{ openstack_test_log_path }} {{ openstack_test_junit_path }} <<'PY'
152152
import json
153153
import sys
@@ -200,6 +200,7 @@
200200
)
201201
ET.ElementTree(suite).write(junit_path, encoding="utf-8", xml_declaration=True)
202202
PY
203+
exit ${run_exit:-0}
203204
environment:
204205
OS_CLOUD: "{{ user_cloud }}"
205206
KUBECONFIG: "{{ kubeconfig }}"

0 commit comments

Comments
 (0)