Correct the live specs against what the stack actually does

Seed: a usage limit, chat modes and transcripts, search history, a connected administrator. Sessions persist across Playwright's worker restarts so the sign-in rate limit is not the failure. Specs: not-found is a streamed 200, the login callback is the zone root as on legacy, account deletion is blocked for a member, and a withheld directory comes from the default group. Adds Home's connected-account states and a parity audit.

Author: waleedlatif1

.github/scripts/http-e2e.sh

@@ -202,7 +202,6 @@ platform_live_environment() {
   export PLATFORM_LIVE_CONNECTED_EMAIL=cory@platform-live.test
   export PLATFORM_LIVE_ROLE_TARGET_EMAIL=rae@platform-live.test
   export PLATFORM_LIVE_REMOVABLE_EMAIL=remy@platform-live.test
-  export PLATFORM_LIVE_NO_DIRECTORY_EMAIL=noor@platform-live.test
   export PLATFORM_LIVE_REFUSED_INVITE_EMAIL=otto@platform-live.test
   export PLATFORM_LIVE_ORCHESTRATOR=1
   bun --no-env-file scripts/platform-live-seed.ts

apps/sim/platform/checks/live/chat.spec.ts

@@ -24,8 +24,9 @@ test('A chat outside the viewer’s access is not found rather than an empty cha
   page,
 }) => {
   await signInAsAdmin(page, '/org/home')
-  const response = await page.goto('/org/chat/00000000-0000-4000-8000-000000000000')
-  expect(response?.status()).toBe(404)
+  await page.goto('/org/chat/00000000-0000-4000-8000-000000000000')
+  await expect(page.getByRole('heading', { name: 'Page not found' })).toBeVisible()
+  await expect(page.getByRole('region', { name: 'Conversation' })).toHaveCount(0)
 })
 
 test('A resource in the URL survives a reload of the chat route', async ({ page }) => {

apps/sim/platform/checks/live/home.spec.ts

@@ -1,5 +1,11 @@
-import { expect, test } from '@playwright/test'
-import { organizationId, signInAsAdmin } from '@/platform/checks/live/session'
+import { expect, type Page, test } from '@playwright/test'
+import {
+  memberEmail,
+  organizationId,
+  requireEnv,
+  signIn,
+  signInAsAdmin,
+} from '@/platform/checks/live/session'
 
 test.describe('Home on real data', () => {
   test.beforeEach(async ({ page }) => {
@@ -83,3 +89,222 @@ test.describe('Home on real data', () => {
     await expect(email).toBeVisible()
   })
 })
+
+test('a member who cannot build lands on Search, not an error', async ({ page }) => {
+  await signIn(page, memberEmail(), '/org/home')
+  await expect(page).toHaveURL(/\/org\/search/)
+  await expect(page.getByRole('textbox', { name: 'Search' })).toBeVisible()
+})
+
+test.describe('Home for the seeded administrator', () => {
+  test('greets the member by first name', async ({ page }) => {
+    await signInAsAdmin(page, '/org/home')
+    await expect(page.getByRole('heading', { level: 1 })).toContainText(/, Ada$/)
+  })
+
+  test('Recents list the viewer’s real history and × removes it for good', async ({ page }) => {
+    await signInAsAdmin(page, '/org/home')
+    const recents = page.getByRole('region', { name: 'Recents', exact: true })
+    await expect(recents.getByRole('link', { name: 'Onboarding guide' })).toBeVisible()
+    const renewal = recents.getByRole('link', { name: 'Renewal terms' })
+    await renewal.hover()
+    await recents.getByRole('button', { name: 'Remove Renewal terms from recents' }).click()
+    await expect(renewal).toHaveCount(0)
+    await page.reload()
+    await expect(recents.getByRole('link', { name: 'Onboarding guide' })).toBeVisible()
+    await expect(renewal).toHaveCount(0)
+  })
+
+  test('an unread chat needs attention and opens from there', async ({ page }) => {
+    await signInAsAdmin(page, '/org/home')
+    const attention = page.getByRole('region', { name: 'Needs your attention', exact: true })
+    await expect(attention.getByText('Vendor renewals')).toBeVisible()
+    await expect(attention.getByText('Quarterly review')).toHaveCount(0)
+    await attention.getByText('Vendor renewals').click()
+    await expect(page).toHaveURL(/\/org\/search\/chat\/22222222-/)
+    await expect(page.getByText('Here is what I found about Vendor renewals.')).toBeVisible()
+  })
+
+  test('Search mode drops the activity chart and offers Search’s Get started', async ({ page }) => {
+    await signInAsAdmin(page, '/org/home')
+    await expect(page.getByRole('region', { name: 'Tasks run', exact: true })).toBeVisible()
+    await page.getByRole('radio', { name: 'Search' }).click()
+    await expect(page.getByRole('region', { name: 'Tasks run', exact: true })).toHaveCount(0)
+    await expect(page.getByRole('region', { name: 'Searches', exact: true })).toHaveCount(0)
+  })
+
+  test('connecting Gmail starts the provider’s real authorization', async ({ page, context }) => {
+    await context.route('https://accounts.google.com/**', (route) =>
+      route.fulfill({ status: 200, contentType: 'text/html', body: 'Google stand-in' })
+    )
+    await signInAsAdmin(page, '/org/home')
+    const authorization = page.waitForRequest((request) =>
+      request.url().startsWith('https://accounts.google.com/')
+    )
+    await page
+      .getByRole('region', { name: 'Email', exact: true })
+      .getByRole('button', { name: 'Gmail', exact: true })
+      .click()
+    const url = new URL((await authorization).url())
+    expect(url.searchParams.get('client_id')).toBe(process.env.GOOGLE_CLIENT_ID)
+    expect(url.searchParams.get('redirect_uri')).toContain('/api/')
+  })
+})
+
+/**
+ * The seeded member holds real Gmail and Calendar grants with fixture tokens. Google cannot honor
+ * those, so these replace the widget reads at the browser's network boundary: they prove what Home
+ * does with each answer. `home-widgets.integration.ts` proves the reads behind them.
+ */
+test.describe('Home with connected accounts', () => {
+  const GRANT = 'platform-live-grant-gmail'
+  const CALENDAR_GRANT = 'platform-live-grant-google-calendar'
+
+  function account(credentialId: string, state: string) {
+    return {
+      credentialId,
+      displayName: requireEnv('PLATFORM_LIVE_CONNECTED_EMAIL'),
+      state,
+    }
+  }
+
+  const THREADS = [
+    {
+      id: 'thread-1',
+      credentialId: GRANT,
+      sender: 'Grace Hopper',
+      subject: 'Compiler review',
+      excerpt: 'The draft is ready',
+      receivedAt: new Date(Date.now() - 3_600_000).toISOString(),
+      messageCount: 3,
+      url: 'https://mail.google.com/mail/u/0/#inbox/thread-1',
+    },
+  ]
+
+  function calendarFor(date: string) {
+    const startAt = `${date}T15:00:00.000Z`
+    return {
+      accounts: [account(CALENDAR_GRANT, 'ready')],
+      window: { startAt: `${date}T00:00:00.000Z`, endAt: `${date}T23:59:59.000Z` },
+      events: [
+        {
+          id: `event-${date}`,
+          credentialId: CALENDAR_GRANT,
+          title: `Standup ${date}`,
+          allDay: false,
+          startAt,
+          endAt: `${date}T15:30:00.000Z`,
+          people: [{ name: 'Grace Hopper' }],
+        },
+      ],
+    }
+  }
+
+  async function serveWidgets(page: Page) {
+    await page.route('**/home/email', (route) =>
+      route.fulfill({ json: { accounts: [account(GRANT, 'ready')], threads: THREADS } })
+    )
+    await page.route('**/home/calendar?*', (route) => {
+      const date = new URL(route.request().url()).searchParams.get('date') as string
+      return route.fulfill({ json: calendarFor(date) })
+    })
+  }
+
+  const open = (page: Page) =>
+    signIn(page, requireEnv('PLATFORM_LIVE_CONNECTED_EMAIL'), '/org/home')
+
+  test('a connected member reads their mail, opens a thread, and keeps a chosen day', async ({
+    page,
+    context,
+  }) => {
+    await serveWidgets(page)
+    await context.route('https://mail.google.com/**', (route) =>
+      route.fulfill({ status: 200, contentType: 'text/html', body: 'Gmail stand-in' })
+    )
+    await open(page)
+    const email = page.getByRole('region', { name: 'Email', exact: true })
+    await expect(email.getByText('Grace Hopper')).toBeVisible()
+    await expect(email.getByText('Compiler review')).toBeVisible()
+    const opened = context.waitForEvent('page')
+    await email.getByText('Grace Hopper').click()
+    expect((await opened).url()).toContain('mail.google.com/mail/u/0/#inbox/thread-1')
+
+    const calendar = page.getByRole('region', { name: 'Calendar', exact: true })
+    await expect(calendar.getByText(/^Standup \d{4}-\d{2}-\d{2}$/)).toBeVisible()
+    const next = page.waitForRequest((request) => request.url().includes('/home/calendar?'))
+    await calendar.getByRole('button', { name: 'Next day' }).click()
+    const chosen = new URL((await next).url()).searchParams.get('date') as string
+    await expect(page).toHaveURL(new RegExp(`day=${chosen}`))
+    await expect(calendar.getByText(`Standup ${chosen}`)).toBeVisible()
+    await page.reload()
+    await expect(calendar.getByText(`Standup ${chosen}`)).toBeVisible()
+  })
+
+  test('a failed read offers a retry that recovers, with nothing else on Home affected', async ({
+    page,
+  }) => {
+    let failing = true
+    await serveWidgets(page)
+    await page.route('**/home/email', (route) =>
+      failing
+        ? route.fulfill({ status: 500, json: { error: 'Provider down' } })
+        : route.fulfill({ json: { accounts: [account(GRANT, 'ready')], threads: THREADS } })
+    )
+    await open(page)
+    const email = page.getByRole('region', { name: 'Email', exact: true })
+    await expect(email.getByText('Your email could not load')).toBeVisible({ timeout: 30_000 })
+    await expect(
+      page.getByRole('region', { name: 'Calendar', exact: true }).getByText(/^Standup /)
+    ).toBeVisible()
+    failing = false
+    await email.getByRole('button', { name: 'Retry' }).click()
+    await expect(email.getByText('Grace Hopper')).toBeVisible()
+  })
+
+  test('an account Google stopped honoring asks to reconnect, here and in attention', async ({
+    page,
+  }) => {
+    await serveWidgets(page)
+    await page.route('**/home/email', (route) =>
+      route.fulfill({ json: { accounts: [account(GRANT, 'needs_reauth')], threads: [] } })
+    )
+    await open(page)
+    await expect(
+      page
+        .getByRole('region', { name: 'Email', exact: true })
+        .getByText('Reconnect your email', { exact: true })
+    ).toBeVisible()
+    await expect(
+      page.getByRole('region', { name: 'Needs your attention', exact: true }).getByText(/Reconnect/)
+    ).toBeVisible()
+  })
+
+  test('a connected member with an empty mailbox sees that, not a prompt to connect', async ({
+    page,
+  }) => {
+    await serveWidgets(page)
+    await page.route('**/home/email', (route) =>
+      route.fulfill({ json: { accounts: [account(GRANT, 'ready')], threads: [] } })
+    )
+    await open(page)
+    const email = page.getByRole('region', { name: 'Email', exact: true })
+    await expect(email.getByText('No email yet', { exact: true })).toBeVisible()
+    await expect(email.getByText('Connect your email', { exact: true })).toHaveCount(0)
+  })
+
+  test('disconnecting removes the account for real and returns to the connect prompt', async ({
+    page,
+  }) => {
+    await serveWidgets(page)
+    await open(page)
+    const email = page.getByRole('region', { name: 'Email', exact: true })
+    await email.getByRole('button', { name: 'Email options' }).click()
+    await page.getByRole('menuitem', { name: 'Disconnect Email' }).click()
+    const dialog = page.getByRole('dialog', { name: 'Disconnect Email?' })
+    await dialog.getByRole('button', { name: 'Disconnect', exact: true }).click()
+    await expect(dialog).toBeHidden()
+    await expect(email.getByText('Connect your email', { exact: true })).toBeVisible()
+    await page.reload()
+    await expect(email.getByText('Connect your email', { exact: true })).toBeVisible()
+  })
+})

apps/sim/platform/checks/live/members.spec.ts

@@ -22,6 +22,7 @@ async function signInAsAdmin(page: Page) {
 function memberRow(page: Page, email: string) {
   return page
     .getByText(email)
+    .first()
     .locator('xpath=ancestor::div[.//button[starts-with(@aria-label, "Actions for")]][1]')
 }
 
@@ -49,26 +50,38 @@ test('a partial invite failure keeps only the refused address, with its reason',
 test('a role change persists and a failed one is reported', async ({ page }) => {
   await signInAsAdmin(page)
   const target = requireEnv('PLATFORM_LIVE_ROLE_TARGET_EMAIL')
-  await memberRow(page, target).getByRole('combobox').click()
+  await memberRow(page, target)
+    .getByRole('combobox', { name: /^Role for/ })
+    .click()
   await page.getByRole('option', { name: 'Admin' }).click()
   await page.reload()
-  await expect(memberRow(page, target).getByRole('combobox')).toHaveText(/Admin/)
+  await expect(memberRow(page, target).getByRole('combobox', { name: /^Role for/ })).toHaveText(
+    /Admin/
+  )
 
   await page.route('**/api/organizations/*/members/*', (route) =>
     route.request().method() === 'PUT'
       ? route.fulfill({ status: 500, json: { error: 'Refused by the live check' } })
       : route.continue()
   )
-  await memberRow(page, target).getByRole('combobox').click()
+  await memberRow(page, target)
+    .getByRole('combobox', { name: /^Role for/ })
+    .click()
   await page.getByRole('option', { name: 'Member' }).click()
   await expect(page.getByText("Couldn't change the role")).toBeVisible()
-  await expect(memberRow(page, target).getByRole('combobox')).toHaveText(/Admin/)
+  await expect(memberRow(page, target).getByRole('combobox', { name: /^Role for/ })).toHaveText(
+    /Admin/
+  )
   await page.unroute('**/api/organizations/*/members/*')
 
-  await memberRow(page, target).getByRole('combobox').click()
+  await memberRow(page, target)
+    .getByRole('combobox', { name: /^Role for/ })
+    .click()
   await page.getByRole('option', { name: 'Member' }).click()
   await page.reload()
-  await expect(memberRow(page, target).getByRole('combobox')).toHaveText(/Member/)
+  await expect(memberRow(page, target).getByRole('combobox', { name: /^Role for/ })).toHaveText(
+    /Member/
+  )
 })
 
 test('removal holds on its disclosure, keeps the dialog on failure, then removes', async ({

apps/sim/platform/checks/live/people.spec.ts

@@ -1,11 +1,13 @@
 import { expect, test } from '@playwright/test'
-import { adminEmail, requireEnv, signIn, signInAsAdmin } from '@/platform/checks/live/session'
+import {
+  adminEmail,
+  memberEmail,
+  organizationId,
+  signIn,
+  signInAsAdmin,
+} from '@/platform/checks/live/session'
 
-/**
- * `PLATFORM_LIVE_EMAIL` is an administrator in an organization with the `people` flag on.
- * `PLATFORM_LIVE_NO_DIRECTORY_EMAIL` belongs to a permission group withholding
- * `organization.member_directory`.
- */
+/** `PLATFORM_LIVE_EMAIL` is an administrator in an organization with the `people` flag on. */
 
 test('the directory filters, pages and opens a profile that returns to the same view', async ({
   page,
@@ -36,10 +38,26 @@ test('the chart reads without a canvas and an unknown focus says so', async ({ p
 
 test('a member withheld the directory gets no People, from the sidebar or a saved link', async ({
   page,
+  browser,
+  baseURL,
 }) => {
-  await signIn(page, requireEnv('PLATFORM_LIVE_NO_DIRECTORY_EMAIL'), '/org')
-  await expect(page.getByRole('button', { name: 'Organization menu' })).toBeVisible()
-  await expect(page.getByRole('link', { name: 'People', exact: true })).toHaveCount(0)
-  const response = await page.goto('/org/people')
-  expect(response?.status()).toBe(404)
+  await signInAsAdmin(page, '/org/home')
+  const groups = `/api/organizations/${organizationId()}/permission-groups`
+  const created = await page.request.post(groups, {
+    data: { name: 'Withhold directory', isDefault: true, config: { hideOrgMemberDirectory: true } },
+  })
+  expect(created.status(), await created.text()).toBeLessThan(300)
+  const { id } = (await created.json()) as { id: string }
+  const context = await browser.newContext({ baseURL })
+  try {
+    const member = await context.newPage()
+    await signIn(member, memberEmail(), '/org')
+    await expect(member.getByRole('button', { name: 'Organization menu' })).toBeVisible()
+    await expect(member.getByRole('link', { name: 'People', exact: true })).toHaveCount(0)
+    await member.goto('/org/people')
+    await expect(member.getByRole('heading', { name: 'Page not found' })).toBeVisible()
+  } finally {
+    await context.close()
+    expect((await page.request.delete(`${groups}/${id}`)).ok()).toBe(true)
+  }
 })

apps/sim/platform/checks/live/playwright.config.ts

@@ -19,6 +19,7 @@ export default defineConfig({
   outputDir: path.join(path.dirname(report), 'artifacts'),
   use: {
     baseURL: process.env.PLATFORM_LIVE_ORIGIN ?? 'http://localhost:3000',
+    actionTimeout: 20_000,
     screenshot: 'only-on-failure',
     trace: 'retain-on-failure',
   },