fix(webhooks): type blank Plane tokens and non-string Airtable IDs as config errors, dedupe resume refusal logs

Author: waleedlatif1

apps/sim/lib/webhooks/providers/airtable.ts

@@ -1,6 +1,7 @@
 import { db } from '@sim/db'
 import { account, webhook } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
+import { toStringOrNull } from '@sim/utils/coerce'
 import { toRecord } from '@sim/utils/object'
 import { eq } from 'drizzle-orm'
 import { validateAirtableId } from '@/lib/core/security/input-validation'
@@ -436,12 +437,12 @@ export const airtableHandler: WebhookProviderHandler = {
   }: SubscriptionContext): Promise<SubscriptionResult | undefined> {
     try {
       const config = getProviderConfig(webhookRecord)
-      const { baseId, tableId, includeCellValuesInFieldIds, credentialId } = config as {
-        baseId?: string
-        tableId?: string
+      const { includeCellValuesInFieldIds, credentialId } = config as {
         includeCellValuesInFieldIds?: string
         credentialId?: string
       }
+      const baseId = toStringOrNull(config.baseId)
+      const tableId = toStringOrNull(config.tableId)
 
       if (!baseId || !tableId) {
         logger.warn(`[${requestId}] Missing baseId or tableId for Airtable webhook creation.`, {

apps/sim/lib/webhooks/providers/errors.ts

@@ -1,5 +1,5 @@
 export class WebhookDeploymentConfigurationError extends Error {
-  constructor(message: string) {
+  constructor(message?: string) {
     super(message)
     this.name = 'WebhookDeploymentConfigurationError'
   }

apps/sim/lib/webhooks/providers/plane.ts

@@ -41,7 +41,13 @@ async function planeWebhookRequest(
 ) {
   const slug = config.triggerWorkspaceSlug
   const apiKey = config.triggerApiKey
-  if (typeof slug !== 'string' || !slug.trim() || typeof apiKey !== 'string') {
+  if (
+    typeof slug !== 'string' ||
+    !slug.trim() ||
+    typeof apiKey !== 'string' ||
+    !apiKey.trim() ||
+    /[\r\n]/.test(apiKey.trim())
+  ) {
     throw new WebhookDeploymentConfigurationError(
       'Plane workspace slug and API token are required for automatic registration'
     )

apps/sim/lib/workflows/executor/resume-execution.ts

@@ -8,6 +8,7 @@ import {
 } from '@/lib/billing/core/attribution'
 import { getJobQueue, shouldExecuteInline } from '@/lib/core/async-jobs'
 import type { AsyncExecutionCorrelation } from '@/lib/core/async-jobs/types'
+import { logFailureOnce, markFailureKind } from '@/lib/core/errors/failure-log'
 import { toTriggerMaxDurationSeconds } from '@/lib/core/execution-limits'
 import type { OrchestrationRequestContext } from '@/lib/core/orchestration/types'
 import { generateRequestId } from '@/lib/core/utils/request'
@@ -436,16 +437,12 @@ export async function executeResumeWorkflow({
     if (error instanceof ResumeWorkflowExecutionError) throw error
     const statusCode =
       isRecordLike(error) && typeof error.statusCode === 'number' ? error.statusCode : undefined
-    const diagnostics = projectResolvedSecretDiagnosticError(error, undefined, {
-      workflowId,
+    if (statusCode !== undefined && statusCode < 500) markFailureKind(error, 'user')
+    logFailureOnce(logger, 'Resume request failed', error, {
       executionId,
-      contextId,
+      metadata: () =>
+        projectResolvedSecretDiagnosticError(error, undefined, { workflowId, contextId }),
     })
-    if (statusCode !== undefined && statusCode < 500) {
-      logger.warn('Resume request refused', diagnostics)
-    } else {
-      logger.error('Resume request failed', diagnostics)
-    }
     if (statusCode !== undefined) {
       throw new ResumeWorkflowExecutionError(statusCode, toError(error).message, statusCode < 500)
     }