fix(desktop): declare per-platform node-pty prebuilds as optional

electron-builder's dependency collector fails on a missing production
dependency but skips a missing optional one, and bun installs only the
host platform's prebuild, so each OS was failing on the other's packages.

Author: waleedlatif1

apps/desktop/package.json

@@ -33,10 +33,6 @@
   },
   "dependencies": {
     "@lydell/node-pty": "1.2.0-beta.12",
-    "@lydell/node-pty-darwin-arm64": "1.2.0-beta.12",
-    "@lydell/node-pty-darwin-x64": "1.2.0-beta.12",
-    "@lydell/node-pty-win32-arm64": "1.2.0-beta.12",
-    "@lydell/node-pty-win32-x64": "1.2.0-beta.12",
     "@sim/browser-protocol": "workspace:*",
     "@sim/desktop-bridge": "workspace:*",
     "@sim/logger": "workspace:*",
@@ -50,6 +46,12 @@
     "pdf-lib": "1.17.1",
     "@sim/auth-ui": "workspace:*"
   },
+  "optionalDependencies": {
+    "@lydell/node-pty-darwin-arm64": "1.2.0-beta.12",
+    "@lydell/node-pty-darwin-x64": "1.2.0-beta.12",
+    "@lydell/node-pty-win32-arm64": "1.2.0-beta.12",
+    "@lydell/node-pty-win32-x64": "1.2.0-beta.12"
+  },
   "devDependencies": {
     "@electron/fuses": "1.8.0",
     "@playwright/test": "1.61.1",

apps/desktop/src/main/browser-agent/keyboard.test.ts

@@ -189,7 +189,7 @@ describe('dispatchKeyCombo', () => {
       .mockRejectedValueOnce(new Error('key-up response lost'))
       .mockRejectedValueOnce(new Error('cleanup unavailable'))
 
-    const dispatch = dispatchKeyCombo(contents, parseKeyCombo('Cmd+A', 'darwin'))
+    const dispatch = dispatchKeyCombo(contents, parseKeyCombo('Mod+A'))
 
     await expect(dispatch).rejects.toEqual(
       expect.objectContaining({
@@ -202,7 +202,7 @@ describe('dispatchKeyCombo', () => {
     const keyEvents = vi
       .mocked(contents.debugger.sendCommand)
       .mock.calls.filter(([method]) => method === 'Input.dispatchKeyEvent')
-    // Meta down, A down, A up (lost), then cleanup re-releases A and releases the held Meta.
+    // Mod down, A down, A up (lost), then cleanup re-releases A and releases the held Mod.
     expect(keyEvents).toHaveLength(5)
     expect(keyEvents[2]).toEqual(keyEvents[3])
     expect(keyEvents[2]).toEqual([
@@ -211,7 +211,10 @@ describe('dispatchKeyCombo', () => {
     ])
     expect(keyEvents[4]).toEqual([
       'Input.dispatchKeyEvent',
-      expect.objectContaining({ type: 'keyUp', key: 'Meta' }),
+      expect.objectContaining({
+        type: 'keyUp',
+        key: process.platform === 'darwin' ? 'Meta' : 'Control',
+      }),
     ])
     expect(contents.setIgnoreMenuShortcuts).toHaveBeenNthCalledWith(1, true)
     expect(contents.setIgnoreMenuShortcuts).toHaveBeenNthCalledWith(2, false)