fix(video-generator): retain empty controls and isolate CI scenarios

Author: waleedlatif1

apps/sim/lib/internal/video/client.test.ts

@@ -38,30 +38,52 @@ describe('Video provider client', () => {
   })
 
   it.each([
-    { model: 'gen4.5', limit: 1000 },
-    { model: 'klingO3_4k', limit: 2500 },
-    { model: 'kling_4', limit: 26000 },
+    { provider: 'runway' as const, model: 'gen4.5', limit: 1000 },
+    { provider: 'runway' as const, model: 'klingO3_4k', limit: 2500 },
+    { provider: 'runway' as const, model: 'kling_4', limit: 26000 },
+    { provider: 'luma' as const, model: 'ray-3.2', limit: 6000 },
+    { provider: 'minimax' as const, model: 'MiniMax-H3', limit: 7000 },
   ])(
     'accepts the published prompt limit for $model and rejects overflow before submission',
-    async ({ model, limit }) => {
+    async ({ provider, model, limit }) => {
       const mockFetch = vi
         .fn<typeof fetch>()
         .mockResolvedValueOnce(jsonResponse({ id: 'job' }))
         .mockResolvedValueOnce(
-          jsonResponse({ status: 'SUCCEEDED', output: ['data:video/mp4;base64,dmlkZW8='] })
+          jsonResponse(
+            provider === 'luma'
+              ? {
+                  state: 'completed',
+                  output: [{ type: 'video', url: 'data:video/mp4;base64,dmlkZW8=' }],
+                }
+              : provider === 'minimax'
+                ? {
+                    task: {
+                      status: 'succeeded',
+                      content: { url: 'data:video/mp4;base64,dmlkZW8=' },
+                    },
+                  }
+                : { status: 'SUCCEEDED', output: ['data:video/mp4;base64,dmlkZW8='] }
+          )
         )
       vi.stubGlobal('fetch', mockFetch)
       storageServiceMockFns.mockUploadFile.mockResolvedValue({
         path: '/api/files/video.mp4',
         size: 5,
       })
-      const input = { provider: 'runway' as const, model, apiKey: 'key', prompt: 'a'.repeat(limit) }
+      const input = { provider, model, apiKey: 'key', prompt: 'a'.repeat(limit) }
       const context = { requestId: 'prompt-boundary', userId: 'user', headers: new Headers() }
       const completion = expect(executeVideoOperation(input, context)).resolves.toMatchObject({
         model,
       })
       await Promise.all([completion, vi.advanceTimersByTimeAsync(5000)])
-      expect(JSON.parse(String(mockFetch.mock.calls[0]?.[1]?.body)).promptText).toBe(input.prompt)
+      expect(JSON.parse(String(mockFetch.mock.calls[0]?.[1]?.body))).toMatchObject(
+        provider === 'runway'
+          ? { promptText: input.prompt }
+          : provider === 'luma'
+            ? { prompt: input.prompt }
+            : { content: [{ type: 'text', text: input.prompt }] }
+      )
 
       mockFetch.mockClear()
       await expect(
@@ -271,6 +293,32 @@ describe('Video provider client', () => {
     })
   })
 
+  it.each([null, '', false, 0])(
+    'ignores an empty camera control (%s) when submitting a Luma job',
+    async (cameraControl) => {
+      const fetchMock = vi
+        .fn<typeof fetch>()
+        .mockResolvedValueOnce(jsonResponse({ id: 'job' }))
+        .mockResolvedValueOnce(
+          jsonResponse({ state: 'completed', assets: { video: 'data:video/mp4;base64,dmlkZW8=' } })
+        )
+      vi.stubGlobal('fetch', fetchMock)
+      const result = generateVideo(
+        {
+          provider: 'luma',
+          model: 'ray-2',
+          apiKey: 'key',
+          prompt: 'A cinematic sunrise',
+          cameraControl,
+        },
+        { requestId: 'empty-camera' }
+      )
+      const completion = expect(result).resolves.toMatchObject({ buffer: Buffer.from('video') })
+      await Promise.all([completion, vi.advanceTimersByTimeAsync(5000)])
+      expect(JSON.parse(String(fetchMock.mock.calls[0]?.[1]?.body))).not.toHaveProperty('concepts')
+    }
+  )
+
   it('rejects malformed camera controls before submitting a paid Luma job', async () => {
     const fetchMock = vi.fn(() => {
       throw new Error('Unexpected paid request')

apps/sim/lib/internal/video/direct-request.ts

@@ -63,8 +63,11 @@ export function buildDirectVideoRequest(input: VideoGenerationInput) {
       `${model.label} does not support camera controls; describe camera motion in the prompt`
     )
 
-  const concepts =
-    typeof input.cameraControl === 'string' ? [{ key: input.cameraControl }] : input.cameraControl
+  const concepts = input.cameraControl
+    ? typeof input.cameraControl === 'string'
+      ? [{ key: input.cameraControl }]
+      : input.cameraControl
+    : undefined
   if (
     concepts !== undefined &&
     (!Array.isArray(concepts) ||

apps/sim/lib/media/direct-video-catalog.ts

@@ -46,6 +46,7 @@ export const directVideoModels: readonly DirectVideoModel[] = [
     label: 'Ray 3.2',
     protocol: 'luma',
     text: {
+      maxPromptLength: 6000,
       durations: [5, 10],
       aspectRatios: ratios,
       resolutions: ['360p', '540p', '720p', '1080p'],
@@ -73,6 +74,7 @@ export const directVideoModels: readonly DirectVideoModel[] = [
       label: id.replace('MiniMax-', 'MiniMax '),
       protocol: 'minimax-v2',
       text: {
+        maxPromptLength: 7000,
         durations: range(id === 'MiniMax-H3-Max' ? 5 : 4, 15),
         aspectRatios: ratios,
         resolutions: id === 'MiniMax-H3' ? ['768P', '2K'] : ['480P', '768P'],

apps/sim/scripts/test-browser-extension-e2e.ts

@@ -1546,15 +1546,24 @@ try {
         if (enabled) await expect(globe).toHaveText('Current page')
         else await expect(globe).not.toHaveText('Current page')
       }
-      try {
+      const openScenario = async (target: string) => {
+        // A rejected send can recover from this tab's session after navigation.
+        await shell.close()
+        panel = await openPanel()
+        shell = panel
         await setPanelViewport(320, 844)
+        await shell.goto(`chrome-extension://${extensionId}/sidepanel.html`)
+        await observeCaptureReceipts()
+        await navigate(base.origin + target)
+        await setReference(true)
+      }
+      try {
         for (const org of [false, true]) {
           const target = org ? `/extension/o/${organizationId}` : `/extension/${alphaId}`
           const input = () =>
             frame().getByRole('textbox', { name: org ? 'Ask Sim' : 'Message', exact: true })
-          await navigate(base.origin + target)
+          await openScenario(target)
           await expect(input()).toBeVisible()
-          await setReference(true)
           await input().fill('Summarize the current page')
           const submit = frame().getByRole('button', {
             name: org ? 'Send' : 'Send message',
@@ -1575,7 +1584,7 @@ try {
             org ? organizationId : alphaId
           )
 
-          await navigate(base.origin + target)
+          await openScenario(target)
           await expect(input()).toBeVisible()
           await capture()
           await second.bringToFront()
@@ -1587,7 +1596,7 @@ try {
           assert.equal(manual.length, 1)
           assert(manual[0].text.includes('ORCHID-482') && !manual[0].text.includes('JADE-231'))
 
-          await navigate(base.origin + target)
+          await openScenario(target)
           await expect(input()).toBeVisible()
           await restricted.bringToFront()
           const draft = 'Keep this draft if access is unavailable'