chore(desktop): drop the unreachable foreground-read catch

Author: waleedlatif1

apps/desktop/src/main/terminal/index.ts

@@ -30,7 +30,6 @@ import {
   type TerminalToolArgs,
   type TerminalToolResponse,
 } from '@sim/terminal-protocol'
-import { getErrorMessage } from '@sim/utils/errors'
 import { sleep } from '@sim/utils/helpers'
 import type { BrowserWindow, WebContents } from 'electron'
 import {
@@ -219,7 +218,6 @@ const STOP_ESCALATION_MS = 2_000
 export class TerminalService {
   /** Insertion-ordered, which is also the tab order the user sees. */
   private readonly sessions = new Map<string, TerminalSession>()
-  private foregroundReadFailureLogged = false
   private activeId: string | null = null
   private readonly pendingCloseConfirmations = new Set<string>()
   private agentActiveId: string | null = null
@@ -308,26 +306,16 @@ export class TerminalService {
   /**
    * The command line holding each busy terminal's foreground, `''` when unannounced. A shell
    * without integration (fish, sh) announces nothing, so the OS's foreground process group
-   * answers for it; a failed read counts as idle so a restart is never held by a stale guess.
+   * answers for it; an unreadable group (null) counts as idle.
    */
   async runningCommands(): Promise<string[]> {
     const groups = this.options.processGroups ?? OS_PROCESS_GROUPS
     const commands = await Promise.all(
       [...this.sessions.values()].map(async (session) => {
         if (session.isBusy) return [session.foreground ?? '']
         if (session.hasShellIntegration) return []
-        try {
-          const pgid = await groups.foreground(session.pid)
-          return pgid !== null && pgid !== session.pid ? [''] : []
-        } catch (error) {
-          if (!this.foregroundReadFailureLogged) {
-            this.foregroundReadFailureLogged = true
-            logger.warn('Could not read a terminal foreground process group', {
-              error: getErrorMessage(error),
-            })
-          }
-          return []
-        }
+        const pgid = await groups.foreground(session.pid)
+        return pgid !== null && pgid !== session.pid ? [''] : []
       })
     )
     return commands.flat()

apps/desktop/src/main/terminal/service.test.ts

@@ -515,11 +515,6 @@ describe('running work before a restart', () => {
 
     read = async () => session.pid
     await expect(terminal.runningCommands()).resolves.toEqual([])
-
-    read = async () => {
-      throw new Error('ps is unavailable')
-    }
-    await expect(terminal.runningCommands()).resolves.toEqual([])
   })
 })