fix(sim-links): hand off a departing member's links to the successor

Author: waleedlatif1

apps/sim/lib/billing/organizations/resource-handoff.ts

@@ -2,6 +2,7 @@ import {
   knowledgeBase,
   member,
   permissionGroup,
+  simLink,
   ssoProvider,
   user,
   workspaceFiles,
@@ -103,6 +104,10 @@ export async function reassignOrganizationSharedResourcesTx(
         eq(permissionGroup.createdBy, departingUserId)
       )
     )
+  await tx
+    .update(simLink)
+    .set({ createdBy: userId, updatedAt })
+    .where(and(eq(simLink.organizationId, organizationId), eq(simLink.createdBy, departingUserId)))
   await tx
     .update(ssoProvider)
     .set({ userId })

apps/sim/lib/workspaces/access/shared-resource-handoff.integration.ts

@@ -13,6 +13,7 @@ import {
   permissionGroup,
   permissions,
   project,
+  simLink,
   ssoProvider,
   user,
   userStats,
@@ -1264,6 +1265,75 @@ describe('shared resource retention across workspace departure and account erasu
     await assertRetained(fixture)
   })
 
+  it("hands a removed member's Sim links to the owner and leaves another organization's links", async () => {
+    const fixture = await seedResources(false, false)
+    const [organizationId, otherOrganizationId] = [generateId(), generateId()]
+    const memberId = generateId()
+    const [linkId, otherLinkId] = [generateId(), generateId()]
+    organizationIds.push(organizationId, otherOrganizationId)
+    await db.insert(organization).values(
+      [organizationId, otherOrganizationId].map((id) => ({
+        id,
+        name: 'Sim link organization',
+        slug: id,
+        createdAt: new Date(),
+      }))
+    )
+    await db.insert(member).values([
+      {
+        id: generateId(),
+        organizationId,
+        userId: fixture.ownerId,
+        role: 'owner',
+        createdAt: new Date(),
+      },
+      {
+        id: memberId,
+        organizationId,
+        userId: fixture.departingId,
+        role: 'member',
+        createdAt: new Date(),
+      },
+    ])
+    await db.insert(simLink).values(
+      [
+        { id: linkId, organizationId },
+        { id: otherLinkId, organizationId: otherOrganizationId },
+      ].map(({ id, organizationId: linkOrganizationId }) => ({
+        id,
+        organizationId: linkOrganizationId,
+        name: 'docs',
+        normalizedName: 'docs',
+        url: 'https://example.test/docs',
+        unlisted: true,
+        restrictEdit: true,
+        createdBy: fixture.departingId,
+      }))
+    )
+    expect(
+      (
+        await removeUserFromOrganization({
+          organizationId,
+          userId: fixture.departingId,
+          memberId,
+          skipBillingLogic: true,
+          onError: 'throw',
+        })
+      ).success
+    ).toBe(true)
+    expect(
+      await db
+        .select({ id: simLink.id, createdBy: simLink.createdBy })
+        .from(simLink)
+        .where(inArray(simLink.id, [linkId, otherLinkId]))
+    ).toEqual(
+      expect.arrayContaining([
+        { id: linkId, createdBy: fixture.ownerId },
+        { id: otherLinkId, createdBy: fixture.departingId },
+      ])
+    )
+  })
+
   it('refuses organization-only retention without an owner successor', async () => {
     const fixture = await seedResources(false, false)
     const organizationId = generateId()