Apply the review of the live suite

Moves the build env and inputs to apps/sim/turbo.json, where @sim/app reads them: its own override discarded the root edit, so the zone and no-zone builds hashed alike. Reads the proxy's mode from the one resolver, makes ActionMenu's icon required so a row menu cannot silently become a text button, wraps property values rather than labels, moves platformOrgUi off navFlags, and tidies the seed, specs and parity audit.

Author: waleedlatif1

.github/scripts/ci-plan.gql

@@ -1,24 +1,59 @@
-query($base: String!, $head: String!) {
-  packages { items { name path } }
-  affectedTasks(base: $base, head: $head, tasks: [
-    "test", "build", "type-check", "ci:integration", "ci:desktop-live",
-    "ci:e2e-scim", "ci:e2e-cli", "ci:e2e-stop-after", "ci:e2e-desktop-inbox",
-    "ci:e2e-assistant-actions", "ci:e2e-organization-search",
-    "ci:e2e-docs-platform",
-    "ci:e2e-browser-extension", "ci:e2e-project-files", "ci:e2e-mobile", "ci:e2e-seo"
-  ]) {
+query ($base: String!, $head: String!) {
+  packages {
+    items {
+      name
+      path
+    }
+  }
+  affectedTasks(
+    base: $base
+    head: $head
+    tasks: [
+      "test"
+      "build"
+      "type-check"
+      "ci:integration"
+      "ci:desktop-live"
+      "ci:e2e-scim"
+      "ci:e2e-cli"
+      "ci:e2e-stop-after"
+      "ci:e2e-desktop-inbox"
+      "ci:e2e-assistant-actions"
+      "ci:e2e-organization-search"
+      "ci:e2e-docs-platform"
+      "ci:e2e-browser-extension"
+      "ci:e2e-project-files"
+      "ci:e2e-mobile"
+      "ci:e2e-seo"
+    ]
+  ) {
     items {
       name
       fullName
-      package { name }
+      package {
+        name
+      }
       reason {
         __typename
-        ... on TaskFileChanged { filePath }
-        ... on TaskGlobalFileChanged { filePath }
-        ... on TaskGlobalDepsChanged { filePath }
-        ... on TaskDependencyTaskChanged { taskName packageName }
-        ... on TaskPackageDependencyChanged { packageName }
-        ... on TaskAllChanged { description }
+        ... on TaskFileChanged {
+          filePath
+        }
+        ... on TaskGlobalFileChanged {
+          filePath
+        }
+        ... on TaskGlobalDepsChanged {
+          filePath
+        }
+        ... on TaskDependencyTaskChanged {
+          taskName
+          packageName
+        }
+        ... on TaskPackageDependencyChanged {
+          packageName
+        }
+        ... on TaskAllChanged {
+          description
+        }
       }
     }
   }

.github/scripts/http-e2e.sh

@@ -207,12 +207,11 @@ platform_live_environment() {
   bun --no-env-file scripts/platform-live-seed.ts
 }
 
-# run_platform_live <project> <report-name> [playwright args...]
+# run_platform_live <project> <report-name>
 run_platform_live() {
   local project=$1 name=$2
-  shift 2
   PLATFORM_LIVE_REPORT_PATH="$report_dir/$name/report.json" \
-    bun run test:platform:live --project="$project" ${PLATFORM_LIVE_GREP:+--grep "$PLATFORM_LIVE_GREP"} "$@"
+    bun run test:platform:live --project="$project" ${PLATFORM_LIVE_GREP:+--grep "$PLATFORM_LIVE_GREP"}
 }
 
 # wait_ready <pid> <health-url> <label>

.github/workflows/platform-design.yml

@@ -4,6 +4,8 @@ on:
   pull_request:
     paths:
       - 'apps/sim/platform/**'
+      - '!apps/sim/platform/docs/**'
+      - '!apps/sim/platform/README.md'
       - 'apps/sim/package.json'
       - 'scripts/check-platform-design*'
       - 'scripts/platform-variant-usage.ts'
@@ -130,6 +132,7 @@ jobs:
         with:
           provider: ${{ vars.CI_PROVIDER }}
           turbo-cache-key: turbo-cache-platform-live-${{ matrix.topology }}
+      - run: bun run check:platform-parity
       - name: Provision the database through migrations
         working-directory: packages/db
         run: bun run db:migrate
@@ -159,7 +162,7 @@ jobs:
       - name: Hold the parity ledger to this run
         if: always() && matrix.topology == 'zone'
         run: >-
-          bun run scripts/check-platform-parity.ts
+          bun run check:platform-parity
           --report "$RUNNER_TEMP/e2e/platform-live/report.json"
           --report "$RUNNER_TEMP/e2e/platform-live-flag-off/report.json"
       - uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2

apps/sim/lib/api/contracts/organization.ts

@@ -554,10 +554,10 @@ const organizationSurfaceResponseSchema = z.object({
     selfHosted: z.record(z.string(), z.boolean().optional()),
   }),
   deployment: deploymentShapeSchema,
+  /** Whether the Platform zone is open to this organization at all. */
+  platformOrgUi: z.boolean(),
   /** Which destinations the viewer's navigation lists; none of these authorizes the page behind it. */
   navFlags: z.object({
-    /** Whether the Platform zone is open to this organization at all. */
-    platformOrgUi: z.boolean(),
     people: z.boolean(),
     simLinks: z.boolean(),
     benchmark: z.boolean(),

apps/sim/lib/organizations/application/surface.ts

@@ -73,8 +73,8 @@ export const readOrganizationSurface: OperationUseCase<
       connectedAccountsAvailable: context.connectedAccountsAvailable,
       settingsFeatures: context.settingsFeatures,
       deployment: context.deployment,
+      platformOrgUi,
       navFlags: {
-        platformOrgUi,
         people,
         simLinks,
         benchmark: benchmarkEnabled,

apps/sim/platform/app/(shell)/_components/live-shell/live-shell.tsx

@@ -27,7 +27,7 @@ export async function LiveShell({ children }: { children: ReactNode }) {
 
   const { organization } = surface
   // Deployed, the zone exists only for an organization the rollout has reached.
-  if (process.env.NEXT_PUBLIC_SIM_PLATFORM_BASE_PATH && !organization.navFlags.platformOrgUi) {
+  if (process.env.NEXT_PUBLIC_SIM_PLATFORM_BASE_PATH && !organization.platformOrgUi) {
     notFound()
   }
   const cookieStore = await cookies()

apps/sim/platform/app/(shell)/_components/sidebar/help-menu.tsx

@@ -89,7 +89,7 @@ export function HelpMenu({ iconOnly, help = SESSION_HELP }: HelpMenuProps) {
       <ActionMenu
         label='Help'
         triggerSize='row'
-        icon={iconOnly ? 'I047' : undefined}
+        icon={iconOnly ? 'I047' : null}
         actions={actions}
       />
       {support.submit && contacting && (

apps/sim/platform/checks/live/flag-off/legacy-surface.spec.ts

@@ -1,5 +1,5 @@
 import { expect, type Page, test } from '@playwright/test'
-import { adminEmail, organizationId, signIn } from '@/platform/checks/live/session'
+import { organizationId, signInAsAdmin } from '@/platform/checks/live/session'
 
 /**
  * Runs twice: built with no `SIM_PLATFORM_ORIGIN`, with the flag on; and built with the zone, with
@@ -19,21 +19,21 @@ async function expectLegacySurface(page: Page, route: string) {
 
 for (const route of LEGACY_ROUTES) {
   test(`/o/[id]/${route} renders the legacy surface with no redirect`, async ({ page }) => {
-    await signIn(page, adminEmail(), `/o/${organizationId()}/${route}`)
+    await signInAsAdmin(page, `/o/${organizationId()}/${route}`)
     await expectLegacySurface(page, route)
   })
 }
 
 test('a client navigation stays on the legacy surface too', async ({ page }) => {
-  await signIn(page, adminEmail(), `/o/${organizationId()}/home`)
+  await signInAsAdmin(page, `/o/${organizationId()}/home`)
   await page.getByRole('link', { name: 'People', exact: true }).first().click()
   await expect(page).toHaveURL(new RegExp(`/o/${organizationId()}/people`))
   await expect(page.locator('[data-platform-ui]')).toHaveCount(0)
 })
 
 test('/org is absent', async ({ page }) => {
+  await signInAsAdmin(page, `/o/${organizationId()}/home`)
   for (const path of ['/org', '/org/home', '/org/settings/members']) {
-    await signIn(page, adminEmail(), `/o/${organizationId()}/home`)
     const response = await page.goto(path)
     expect(response?.status(), path).toBe(404)
     await expect(page.getByRole('button', { name: 'Organization menu' })).toHaveCount(0)

apps/sim/platform/checks/live/flows.spec.ts

@@ -1,13 +1,13 @@
 import { expect, type Page, test } from '@playwright/test'
-import { adminEmail, signIn, signInAsAdmin } from '@/platform/checks/live/session'
+import { escapeRegExp } from '@sim/utils/string'
+import { adminEmail, requireEnv, signInAsAdmin } from '@/platform/checks/live/session'
 
 /** What a member does day to day beyond each section's own spec, against the real API. */
 const chats = (page: Page) => page.getByRole('region', { name: 'Chats', exact: true })
 const workspaces = (page: Page) => page.getByRole('region', { name: 'Workspaces', exact: true })
 
 test('a chat pins and marks unread, and both survive a reload', async ({ page }) => {
-  await signInAsAdmin(page, '/org/settings/members')
-  await page.goto('/org/home')
+  await signInAsAdmin(page, '/org/home')
   const list = chats(page)
   await list.getByRole('button', { name: 'Actions for Quarterly review' }).click()
   await page.getByRole('menuitem', { name: 'Pin', exact: true }).click()
@@ -112,10 +112,10 @@ test('member search lives in the URL and narrows the roster', async ({ page }) =
   await page.getByRole('searchbox', { name: /Search members/ }).fill(adminEmail())
   await expect(page).toHaveURL(/search=/)
   await expect(page.getByText(adminEmail()).first()).toBeVisible()
-  await expect(page.getByText(process.env.PLATFORM_LIVE_OWNER_EMAIL as string)).toHaveCount(0)
+  await expect(page.getByText(requireEnv('PLATFORM_LIVE_OWNER_EMAIL'))).toHaveCount(0)
   await page.reload()
   await expect(page.getByRole('searchbox', { name: /Search members/ })).toHaveValue(adminEmail())
-  await expect(page.getByText(process.env.PLATFORM_LIVE_OWNER_EMAIL as string)).toHaveCount(0)
+  await expect(page.getByText(requireEnv('PLATFORM_LIVE_OWNER_EMAIL'))).toHaveCount(0)
 })
 
 test('a notification preference writes and survives a reload', async ({ page }) => {
@@ -152,7 +152,7 @@ test('a permission group created in the form opens, saves its name and deletes',
   await dialog.getByText('Make this the organization default group').click()
   await dialog.getByRole('button', { name: 'Create', exact: true }).click()
   await expect(dialog).toBeHidden()
-  await page.getByRole('button', { name: new RegExp(`^${name}`) }).click()
+  await page.getByRole('button', { name: new RegExp(`^${escapeRegExp(name)}`) }).click()
   await expect(page).toHaveURL(/group-id=/)
   await page.reload()
   await expect(page.getByRole('textbox', { name: 'Name' })).toHaveValue(name)
@@ -172,6 +172,6 @@ test('Requests opens for an administrator and switches views in the URL', async
 })
 
 test('an unknown settings section is not found, inside the shell', async ({ page }) => {
-  await signIn(page, adminEmail(), '/org/settings/not-a-section')
+  await signInAsAdmin(page, '/org/settings/not-a-section')
   await expect(page.getByRole('heading', { name: 'Page not found' })).toBeVisible()
 })

apps/sim/platform/checks/live/home.spec.ts

@@ -200,10 +200,13 @@ test.describe('Home with connected accounts', () => {
     }
   }
 
-  async function serveWidgets(page: Page) {
-    await page.route('**/home/email', (route) =>
-      route.fulfill({ json: { accounts: [account(GRANT, 'ready')], threads: THREADS } })
-    )
+  const READY_MAIL = { accounts: [account(GRANT, 'ready')], threads: THREADS }
+
+  async function serveWidgets(
+    page: Page,
+    mail: { status?: number; json: unknown } = { json: READY_MAIL }
+  ) {
+    await page.route('**/home/email', (route) => route.fulfill(mail))
     await page.route('**/home/calendar?*', (route) => {
       const date = new URL(route.request().url()).searchParams.get('date') as string
       return route.fulfill({ json: calendarFor(date) })
@@ -248,7 +251,7 @@ test.describe('Home with connected accounts', () => {
     await page.route('**/home/email', (route) =>
       failing
         ? route.fulfill({ status: 500, json: { error: 'Provider down' } })
-        : route.fulfill({ json: { accounts: [account(GRANT, 'ready')], threads: THREADS } })
+        : route.fulfill({ json: READY_MAIL })
     )
     await open(page)
     const email = page.getByRole('region', { name: 'Email', exact: true })
@@ -264,10 +267,7 @@ test.describe('Home with connected accounts', () => {
   test('an account Google stopped honoring asks to reconnect, here and in attention', async ({
     page,
   }) => {
-    await serveWidgets(page)
-    await page.route('**/home/email', (route) =>
-      route.fulfill({ json: { accounts: [account(GRANT, 'needs_reauth')], threads: [] } })
-    )
+    await serveWidgets(page, { json: { accounts: [account(GRANT, 'needs_reauth')], threads: [] } })
     await open(page)
     await expect(
       page
@@ -282,10 +282,7 @@ test.describe('Home with connected accounts', () => {
   test('a connected member with an empty mailbox sees that, not a prompt to connect', async ({
     page,
   }) => {
-    await serveWidgets(page)
-    await page.route('**/home/email', (route) =>
-      route.fulfill({ json: { accounts: [account(GRANT, 'ready')], threads: [] } })
-    )
+    await serveWidgets(page, { json: { accounts: [account(GRANT, 'ready')], threads: [] } })
     await open(page)
     const email = page.getByRole('region', { name: 'Email', exact: true })
     await expect(email.getByText('No email yet', { exact: true })).toBeVisible()