|
| 1 | +/** @vitest-environment node */ |
| 2 | +import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest' |
| 3 | +import { FileSearchAdmission } from '@/lib/workspace-files/search/admission' |
| 4 | +import { WorkspaceFileSearchUnavailableError } from '@/lib/workspace-files/search/errors' |
| 5 | + |
| 6 | +describe('FileSearchAdmission', () => { |
| 7 | + beforeEach(() => vi.useFakeTimers()) |
| 8 | + afterEach(() => vi.useRealTimers()) |
| 9 | + |
| 10 | + function createAdmission(concurrency = 1, maxPending = 3, maxPendingPerWorkspace = maxPending) { |
| 11 | + return new FileSearchAdmission({ |
| 12 | + concurrency, |
| 13 | + maxPending, |
| 14 | + maxPendingPerWorkspace, |
| 15 | + timeoutMs: 5000, |
| 16 | + }) |
| 17 | + } |
| 18 | + |
| 19 | + it('queues a burst without exceeding the active budget and releases each slot once', async () => { |
| 20 | + const admission = createAdmission(2) |
| 21 | + const first = await admission.acquire('a') |
| 22 | + const second = await admission.acquire('a') |
| 23 | + const granted = vi.fn() |
| 24 | + const waiting = admission.acquire('a').then((release) => { |
| 25 | + granted() |
| 26 | + return release |
| 27 | + }) |
| 28 | + await vi.advanceTimersByTimeAsync(1) |
| 29 | + expect(granted).not.toHaveBeenCalled() |
| 30 | + first() |
| 31 | + const third = await waiting |
| 32 | + first() |
| 33 | + const fourthGranted = vi.fn() |
| 34 | + const fourth = admission.acquire('b').then((release) => { |
| 35 | + fourthGranted() |
| 36 | + return release |
| 37 | + }) |
| 38 | + await vi.advanceTimersByTimeAsync(1) |
| 39 | + expect(fourthGranted).not.toHaveBeenCalled() |
| 40 | + second() |
| 41 | + ;(await fourth)() |
| 42 | + third() |
| 43 | + expect(vi.getTimerCount()).toBe(0) |
| 44 | + }) |
| 45 | + |
| 46 | + it('rotates waiting workspaces instead of draining one burst first', async () => { |
| 47 | + const admission = createAdmission() |
| 48 | + const first = await admission.acquire('a') |
| 49 | + const order: string[] = [] |
| 50 | + const request = (workspace: string) => |
| 51 | + admission.acquire(workspace).then((release) => { |
| 52 | + order.push(workspace) |
| 53 | + release() |
| 54 | + }) |
| 55 | + const waiting = [request('a'), request('a'), request('b')] |
| 56 | + first() |
| 57 | + await Promise.all(waiting) |
| 58 | + expect(order).toEqual(['a', 'b', 'a']) |
| 59 | + }) |
| 60 | + |
| 61 | + it('rejects overflow and recovers when the queue drains', async () => { |
| 62 | + const admission = createAdmission(1, 1) |
| 63 | + const first = await admission.acquire('a') |
| 64 | + const waiting = admission.acquire('a') |
| 65 | + await expect(admission.acquire('b')).rejects.toBeInstanceOf(WorkspaceFileSearchUnavailableError) |
| 66 | + first() |
| 67 | + ;(await waiting)() |
| 68 | + ;(await admission.acquire('b'))() |
| 69 | + expect(vi.getTimerCount()).toBe(0) |
| 70 | + }) |
| 71 | + |
| 72 | + it('expires waiting requests without executing them or leaking queue capacity', async () => { |
| 73 | + const admission = createAdmission(1, 1) |
| 74 | + const first = await admission.acquire('a') |
| 75 | + const waiting = expect(admission.acquire('b')).rejects.toBeInstanceOf( |
| 76 | + WorkspaceFileSearchUnavailableError |
| 77 | + ) |
| 78 | + await vi.advanceTimersByTimeAsync(5000) |
| 79 | + await waiting |
| 80 | + const next = admission.acquire('c') |
| 81 | + first() |
| 82 | + ;(await next)() |
| 83 | + expect(vi.getTimerCount()).toBe(0) |
| 84 | + }) |
| 85 | + |
| 86 | + it('checks expiry when granting even if a busy event loop has delayed the timer', async () => { |
| 87 | + const admission = createAdmission() |
| 88 | + const first = await admission.acquire('a') |
| 89 | + const waiting = expect(admission.acquire('b')).rejects.toBeInstanceOf( |
| 90 | + WorkspaceFileSearchUnavailableError |
| 91 | + ) |
| 92 | + vi.setSystemTime(Date.now() + 5000) |
| 93 | + first() |
| 94 | + await waiting |
| 95 | + ;(await admission.acquire('c'))() |
| 96 | + expect(vi.getTimerCount()).toBe(0) |
| 97 | + }) |
| 98 | + |
| 99 | + it('removes cancelled waiters and their listeners without consuming a connection', async () => { |
| 100 | + const admission = createAdmission(1, 1) |
| 101 | + const first = await admission.acquire('a') |
| 102 | + const controller = new AbortController() |
| 103 | + const remove = vi.spyOn(controller.signal, 'removeEventListener') |
| 104 | + const reason = new Error('cancelled') |
| 105 | + const waiting = expect(admission.acquire('b', controller.signal)).rejects.toBe(reason) |
| 106 | + controller.abort(reason) |
| 107 | + await waiting |
| 108 | + expect(remove).toHaveBeenCalledWith('abort', expect.any(Function)) |
| 109 | + expect(vi.getTimerCount()).toBe(0) |
| 110 | + const next = admission.acquire('c') |
| 111 | + first() |
| 112 | + ;(await next)() |
| 113 | + }) |
| 114 | + |
| 115 | + it('rejects an already cancelled caller without occupying a slot', async () => { |
| 116 | + const admission = createAdmission() |
| 117 | + const reason = new Error('cancelled') |
| 118 | + await expect(admission.acquire('a', AbortSignal.abort(reason))).rejects.toBe(reason) |
| 119 | + ;(await admission.acquire('b'))() |
| 120 | + }) |
| 121 | + |
| 122 | + it('does not recycle an active slot on cancellation until the database work settles', async () => { |
| 123 | + const admission = createAdmission() |
| 124 | + const controller = new AbortController() |
| 125 | + const first = await admission.acquire('a', controller.signal) |
| 126 | + controller.abort() |
| 127 | + const granted = vi.fn() |
| 128 | + const next = admission.acquire('b').then((release) => { |
| 129 | + granted() |
| 130 | + release() |
| 131 | + }) |
| 132 | + await vi.advanceTimersByTimeAsync(1) |
| 133 | + expect(granted).not.toHaveBeenCalled() |
| 134 | + first() |
| 135 | + await next |
| 136 | + }) |
| 137 | + it('leaves waiting capacity for another workspace when one burst hits its own cap', async () => { |
| 138 | + const admission = createAdmission(1, 4, 2) |
| 139 | + const release = await admission.acquire('hot') |
| 140 | + const hot = [admission.acquire('hot'), admission.acquire('hot')] |
| 141 | + await expect(admission.acquire('hot')).rejects.toBeInstanceOf( |
| 142 | + WorkspaceFileSearchUnavailableError |
| 143 | + ) |
| 144 | + const quiet = admission.acquire('quiet') |
| 145 | + release() |
| 146 | + ;(await hot[0])() |
| 147 | + ;(await quiet)() |
| 148 | + ;(await hot[1])() |
| 149 | + ;(await admission.acquire('hot'))() |
| 150 | + expect(vi.getTimerCount()).toBe(0) |
| 151 | + }) |
| 152 | + |
| 153 | + it.each(['timeout', 'abort'] as const)( |
| 154 | + 'keeps a stalled operation counted after caller %s until the operation settles', |
| 155 | + async (reason) => { |
| 156 | + const admission = createAdmission() |
| 157 | + const controller = new AbortController() |
| 158 | + const dependency = Promise.withResolvers<void>() |
| 159 | + const lateWork = vi.fn() |
| 160 | + const running = admission.run( |
| 161 | + 'a', |
| 162 | + async (signal) => { |
| 163 | + await dependency.promise |
| 164 | + signal.throwIfAborted() |
| 165 | + lateWork() |
| 166 | + }, |
| 167 | + controller.signal |
| 168 | + ) |
| 169 | + const rejected = expect(running).rejects.toThrow( |
| 170 | + reason === 'timeout' ? /timed out/ : /cancelled/ |
| 171 | + ) |
| 172 | + await vi.advanceTimersByTimeAsync(1) |
| 173 | + if (reason === 'timeout') await vi.advanceTimersByTimeAsync(15000) |
| 174 | + else controller.abort(new Error('cancelled')) |
| 175 | + await rejected |
| 176 | + const nextWork = vi.fn().mockResolvedValue('done') |
| 177 | + const next = admission.run('b', nextWork) |
| 178 | + await vi.advanceTimersByTimeAsync(1) |
| 179 | + expect(nextWork).not.toHaveBeenCalled() |
| 180 | + dependency.resolve() |
| 181 | + await expect(next).resolves.toBe('done') |
| 182 | + expect(lateWork).not.toHaveBeenCalled() |
| 183 | + expect(vi.getTimerCount()).toBe(0) |
| 184 | + } |
| 185 | + ) |
| 186 | + |
| 187 | + it('releases a lease after an operation throws synchronously', async () => { |
| 188 | + const admission = createAdmission() |
| 189 | + await expect( |
| 190 | + admission.run('a', () => { |
| 191 | + throw new Error('operation failed') |
| 192 | + }) |
| 193 | + ).rejects.toThrow('operation failed') |
| 194 | + await expect(admission.run('b', async () => 'done')).resolves.toBe('done') |
| 195 | + expect(vi.getTimerCount()).toBe(0) |
| 196 | + }) |
| 197 | + |
| 198 | + it('does not start an operation cancelled while waiting', async () => { |
| 199 | + const admission = createAdmission() |
| 200 | + const release = await admission.acquire('a') |
| 201 | + const controller = new AbortController() |
| 202 | + const operation = vi.fn() |
| 203 | + const waiting = expect(admission.run('b', operation, controller.signal)).rejects.toThrow( |
| 204 | + 'cancelled' |
| 205 | + ) |
| 206 | + controller.abort(new Error('cancelled')) |
| 207 | + await waiting |
| 208 | + release() |
| 209 | + expect(operation).not.toHaveBeenCalled() |
| 210 | + expect(vi.getTimerCount()).toBe(0) |
| 211 | + }) |
| 212 | +}) |
0 commit comments