Skip to content

Commit 72cea20

Browse files
test(ci): require cutover checks for every ECS target
1 parent d7dd8f6 commit 72cea20

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

.github/scripts/test-trigger-deploy.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,14 @@ def poll(self, updates=None, since='1000'):
9898
return self.run_script('wait-for-ecs-cutover.sh', ['app-pipeline', DIGEST, since], responses)
9999

100100
def test_waits_for_every_target(self):
101-
result, calls = self.poll({'get-deployment-target:target-two': [
102-
{'text': 'InProgress'}, {'text': 'Succeeded'}]})
103-
self.assertEqual(result.returncode, 0, result.stderr)
104-
self.assertEqual(calls.count('--target-id target-two'), 2)
101+
targets = ('target-one', 'target-two')
102+
for pending_target in targets:
103+
with self.subTest(pending_target=pending_target):
104+
result, calls = self.poll({f'get-deployment-target:{pending_target}': [
105+
{'text': 'InProgress'}, {'text': 'Succeeded'}]})
106+
self.assertEqual(result.returncode, 0, result.stderr)
107+
for target in targets:
108+
self.assertEqual(calls.count(f'--target-id {target}'), 2)
105109

106110
def test_rejects_stale_execution_inside_former_clock_skew_window(self):
107111
result, calls = self.poll({'list-pipeline-executions': {'json': [execution(start=999)]}})

0 commit comments

Comments
 (0)