Skip to content

Commit 85e2fd8

Browse files
authored
fix(logs): keep retryable resume refusals internal and log deploy-path config rejections at warn (#9691)
1 parent 550fe32 commit 85e2fd8

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎apps/sim/lib/webhooks/deploy.ts‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1105,7 +1105,13 @@ export async function saveTriggerWebhooksForDeploy({
11051105
externalSubscriptionCreated: result.externalSubscriptionCreated,
11061106
})
11071107
} catch (error: unknown) {
1108-
logger.error(`[${requestId}] Failed to create external subscription for ${block.id}`, error)
1108+
if (error instanceof WebhookDeploymentConfigurationError) {
1109+
logger.warn(`[${requestId}] Rejected webhook trigger configuration for ${block.id}`, {
1110+
error: error.message,
1111+
})
1112+
} else {
1113+
logger.error(`[${requestId}] Failed to create external subscription for ${block.id}`, error)
1114+
}
11091115
await pendingVerificationTracker.clearAll()
11101116
let cleanupFailure: unknown
11111117
for (const sub of createdSubscriptions) {

‎apps/sim/lib/workflows/executor/resume-execution.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,8 @@ export async function executeResumeWorkflow({
439439
if (error instanceof ResumeWorkflowExecutionError) throw error
440440
const statusCode =
441441
isRecordLike(error) && typeof error.statusCode === 'number' ? error.statusCode : undefined
442-
if (statusCode !== undefined && statusCode < 500) markFailureKind(error, 'user')
442+
const retryable = isRecordLike(error) && error.retryable === true
443+
if (statusCode !== undefined && statusCode < 500 && !retryable) markFailureKind(error, 'user')
443444
logFailureOnce(logger, 'Resume request failed', error, {
444445
executionId,
445446
metadata: () =>

0 commit comments

Comments
 (0)