fix(mothership): keep a long code call's upload bindings for its whole lifetime

Author: waleedlatif1

apps/sim/lib/mothership/tools/sandbox-project-files.ts

@@ -17,6 +17,7 @@ import {
 } from '@/lib/mothership/tools/sandbox-callback'
 import {
   recordSandboxResourceEffects,
+  SANDBOX_SCOPE_STATE_TTL_SECONDS,
   type SandboxResourceScope,
 } from '@/lib/mothership/tools/sandbox-resources'
 import { chatSandboxSessionKey } from '@/lib/mothership/tools/sandbox-session-key'
@@ -66,10 +67,11 @@ export async function proxySandboxProjectFileRequest(
     uploadBinding: {
       async record(uploadId) {
         await redis().eval(
-          "redis.call('SADD', KEYS[1], ARGV[1]); redis.call('EXPIRE', KEYS[1], 600); return 1",
+          "redis.call('SADD', KEYS[1], ARGV[1]); redis.call('EXPIRE', KEYS[1], ARGV[2]); return 1",
           1,
           bindingKey,
-          uploadId
+          uploadId,
+          SANDBOX_SCOPE_STATE_TTL_SECONDS
         )
       },
       async contains(uploadId) {

apps/sim/lib/mothership/tools/sandbox-resources.test.ts

@@ -200,7 +200,10 @@ describe('sandbox resource ownership and publication', () => {
   it('keeps the callback scope live for a call that outlasts its expiry, and revokes it after', async () => {
     vi.useFakeTimers()
     try {
-      const finish = Promise.withResolvers<void>()
+      let release = () => {}
+      const finished = new Promise<void>((resolve) => {
+        release = resolve
+      })
       let token = ''
       const call = withSandboxResourceScope(
         identity,
@@ -210,12 +213,12 @@ describe('sandbox resource ownership and publication', () => {
           token =
             (await sandboxResourceEndpoint('https://sim.test', args, 'secret')).split('/').at(-1) ??
             ''
-          await finish.promise
+          await finished
         }
       )
       await vi.advanceTimersByTimeAsync(15 * 60_000)
       expect(await readSandboxResourceScope(token, 'secret')).not.toBeNull()
-      finish.resolve()
+      release()
       await vi.advanceTimersByTimeAsync(1_000)
       await call
       expect(await readSandboxResourceScope(token, 'secret')).toBeNull()

apps/sim/lib/mothership/tools/sandbox-resources.ts

@@ -18,6 +18,11 @@ const logger = createLogger('MothershipSandboxResources')
 const CONTEXT_TTL_SECONDS = 600
 /** A running call renews its scope well inside the TTL; the TTL only bounds a crashed owner. */
 const CONTEXT_RENEW_MS = (CONTEXT_TTL_SECONDS * 1000) / 3
+/**
+ * Outlives the longest code call (15 minutes plus its settle margin). State keyed by a scope token
+ * is reachable only through that token's live context, so outliving the context widens nothing.
+ */
+export const SANDBOX_SCOPE_STATE_TTL_SECONDS = 20 * 60
 const POLL_MS = 200
 const scopeSchema = z
   .object({