fix(favicons): keep the presenter's 204 literal and read only a 200 body before one classification

Author: waleedlatif1

apps/sim/app/api/favicon/route.ts

@@ -32,7 +32,7 @@ export const GET = defineInternalBinaryRoute({
           },
         }
       : {
-          status: 204,
+          status: 204 as const,
           headers: {
             'Cache-Control': favicon.kind === 'miss' ? 'private, max-age=3600' : 'no-store',
           },

apps/sim/lib/favicon/hosts.ts

@@ -6,7 +6,7 @@ const HOST_SHAPE = /^[^\s/?#@\\]+$/
 /**
  * Hosts to ask a favicon provider about, most specific first. A private tenant such as
  * `acme.atlassian.net` is invisible to providers, but its platform is not, so each parent
- * domain follows, stopping before the ICANN public suffix (`gitlab.io` is a valid last step;
+ * domain follows — at most three, stopping before the ICANN public suffix (`gitlab.io` is a valid last step;
  * `io` and `co.uk` are not). Internal hosts — IP literals, single labels, and names outside
  * the public DNS — yield nothing, so they never leave the server, and neither does a name with
  * characters DNS can't hold, which could otherwise reshape a provider's URL.

apps/sim/lib/favicon/resolve.server.ts

@@ -78,11 +78,9 @@ async function askProvider(url: string, signal: AbortSignal): Promise<FaviconRes
       signal,
       headers: { Accept: 'image/png,image/x-icon,image/jpeg,image/gif,image/webp' },
     })
-    if (response.status !== 200) {
-      await response.body?.cancel().catch(() => {})
-      return classifyProviderResponse(response.status, new Uint8Array())
-    }
-    const bytes = Buffer.from(await response.arrayBuffer())
+    let bytes = Buffer.alloc(0)
+    if (response.status === 200) bytes = Buffer.from(await response.arrayBuffer())
+    else await response.body?.cancel().catch(() => {})
     const result = classifyProviderResponse(response.status, bytes)
     return result.kind === 'hit' ? { ...result, bytes } : result
   } catch (error) {