Skip to content

Commit be28666

Browse files
committed
improvement(org): follow the design and drop Suggested actions from Home
1 parent 5192fe3 commit be28666

6 files changed

Lines changed: 7 additions & 21 deletions

File tree

‎apps/sim/app/o/[organizationId]/components/organization-conversation.tsx‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ export interface OrganizationSummaryRequest {
8282
export interface OrganizationLandingSlot {
8383
requestMode: ChatRequestMode
8484
composer: ReactNode
85-
shortcuts: ReactNode
8685
}
8786

8887
const serializeSearchConversation = createSerializer({
@@ -581,7 +580,7 @@ function OrganizationConversationContent({
581580
<ComposerScrollArea className='px-3 pb-3'>{composer}</ComposerScrollArea>
582581
</>
583582
) : landing ? (
584-
landing.render({ requestMode, composer, shortcuts })
583+
landing.render({ requestMode, composer })
585584
) : (
586585
<OrganizationLanding
587586
heading={

‎apps/sim/platform/app/(shell)/home/_components/home-dashboard/home-dashboard-skeleton.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ export function HomeDashboardSkeleton({ requestMode }: HomeDashboardSkeletonProp
2323
<RedesignSurface>
2424
<div className={styles.composer}>
2525
<div className={styles.placeholderComposer} data-mode={requestMode} />
26-
{requestMode === 'agent' && <div className={styles.placeholderSuggestedActions} />}
2726
</div>
2827
</RedesignSurface>
2928
<RedesignSurface>

‎apps/sim/platform/app/(shell)/home/_components/home-dashboard/home-dashboard.module.css‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,7 @@
9393
.placeholderGreeting,
9494
.placeholderWordmark,
9595
.placeholderComposer,
96-
.placeholderGetStarted,
97-
.placeholderSuggestedActions {
96+
.placeholderGetStarted {
9897
border-radius: var(--ui-control-radius);
9998
background: var(--control-muted-fill);
10099
}
@@ -109,10 +108,6 @@
109108
.placeholderGetStarted {
110109
block-size: var(--spacing-132);
111110
}
112-
.placeholderSuggestedActions {
113-
block-size: var(--spacing-132);
114-
margin-block-start: var(--ui-product-section-gap);
115-
}
116111
/* The real composer's first-paint heights: the Assistant's pill, the agent's field and toolbar. */
117112
.placeholderComposer {
118113
block-size: 2.875rem;

‎apps/sim/platform/app/(shell)/home/_components/home-dashboard/home-dashboard.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ interface HomeDashboardProps {
3636
view: HomeView
3737
actions: HomeActions
3838
requestMode: ChatRequestMode
39-
/** The real composer and its shortcuts. They sit between surfaces: legacy chrome never renders inside one. */
39+
/** The real composer. It sits between surfaces: legacy chrome never renders inside one. */
4040
composer: ReactNode
4141
}
4242

‎apps/sim/platform/app/(shell)/home/_components/live-home/live-home.tsx‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,9 @@ const LiveDashboard = memo(function LiveDashboard({
2626
)
2727
})
2828

29-
export function LiveHome({ requestMode, composer, shortcuts }: OrganizationLandingSlot) {
29+
export function LiveHome({ requestMode, composer }: OrganizationLandingSlot) {
3030
return (
31-
<ComposerSlot.Provider
32-
value={
33-
<>
34-
{composer}
35-
{requestMode !== 'assistant' && shortcuts}
36-
</>
37-
}
38-
>
31+
<ComposerSlot.Provider value={composer}>
3932
<LiveDashboard requestMode={requestMode} />
4033
</ComposerSlot.Provider>
4134
)

‎apps/sim/scripts/test-org-redesign-e2e.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1508,7 +1508,7 @@ async function homeChecks() {
15081508

15091509
section('3 Home: admin')
15101510
await check(
1511-
'the agent composer with its tools, Suggested actions, and the Tasks run chart',
1511+
'the agent composer with its tools and the Tasks run chart, without Suggested actions',
15121512
async () => {
15131513
await withSession(ADMIN, async ({ page }) => {
15141514
await page.goto(orgUrl('/home'))
@@ -1518,7 +1518,7 @@ async function homeChecks() {
15181518
await expect(page.getByRole('button', { name: 'Add resources' })).toBeVisible()
15191519
await expect(page.getByRole('button', { name: 'Attach file' })).toBeVisible()
15201520
await expect(page.getByRole('button', { name: /Skills/ }).first()).toBeVisible()
1521-
await expect(page.getByText('Suggested actions', { exact: true })).toBeVisible()
1521+
await expect(page.getByText('Suggested actions', { exact: true })).toHaveCount(0)
15221522
await expect(homeRegion(page, 'Tasks run')).toBeVisible()
15231523
await expect(page.getByRole('button', { name: 'Send', exact: true })).toBeDisabled()
15241524
})

0 commit comments

Comments
 (0)