fix(people): refresh published charts and isolate sync retries

Author: waleedlatif1

apps/docs/content/docs/search/people.mdx.draft

@@ -48,7 +48,7 @@ People keeps the last published chart visible until the full replacement passes
 
 SCIM user changes queue a refresh for the next scheduler pass, including changes that arrive while a refresh is running. Sim reads locally provisioned profiles together and publishes their reporting lines in one update. When SCIM deactivates or removes someone, their directory-managed profile is hidden immediately.
 
-After a failure, check the status for the cause. Correct invalid or duplicate email addresses and reporting loops in the source. Check credentials and directory permissions for an access failure, then select **Retry sync** when available.
+After a failure, check the status for the cause. Correct invalid or duplicate email addresses and reporting loops in the source. Check credentials and directory permissions for an access failure. The status shows when Sim will retry automatically. After correcting a source error you can select **Retry sync** immediately. For a provider cooldown, the button becomes available when the cooldown ends.
 
 To stop syncing, select **Disconnect**. This removes directory-only profiles and source-managed details. Existing Sim members and their manual profile data remain. Disconnect the current source before changing providers or tenants.
 

apps/sim/app/o/[organizationId]/people/directory-sync-modal.tsx

@@ -49,11 +49,12 @@ interface SyncStatusProps {
   sync: PeopleSyncStatus
 }
 function SyncStatus({ sync }: SyncStatusProps) {
-  const { label, variant } = sync.retryAt
-    ? { label: 'Waiting to retry', variant: 'amber' as const }
-    : sync.progress && sync.state === 'queued'
-      ? { label: 'Refresh in progress', variant: 'blue' as const }
-      : STATES[sync.state]
+  const { label, variant } =
+    sync.retryBlocked && sync.state !== 'syncing'
+      ? { label: 'Waiting to retry', variant: 'amber' as const }
+      : sync.progress && sync.state === 'queued'
+        ? { label: 'Refresh in progress', variant: 'blue' as const }
+        : STATES[sync.state]
   const { progress } = sync
   const dates = [
     ['Last attempted', sync.lastAttemptAt],
@@ -155,7 +156,7 @@ export function DirectorySyncModal({ organizationId, onClose }: DirectorySyncMod
     )
   const title = 'Directory sync'
   const syncing = sync?.state === 'syncing' || actions.pending
-  const waitingToRetry = Boolean(sync?.retryAt)
+  const waitingToRetry = Boolean(sync?.retryBlocked)
   return (
     <ChipModal open onOpenChange={(open) => !open && onClose()} srTitle={title}>
       <ChipModalHeader onClose={onClose}>{title}</ChipModalHeader>

apps/sim/app/o/[organizationId]/people/people-directory.tsx

@@ -8,6 +8,7 @@ import { useQueryStates } from 'nuqs'
 import { EmptyState } from '@/components/empty-state/empty-state'
 import type { PersonSummary } from '@/lib/api/contracts/people'
 import { organizationRoutes } from '@/lib/navigation/paths'
+import { PEOPLE_SEARCH_MAX_LENGTH } from '@/lib/people/validation'
 import { SEARCH_DEBOUNCE_MS } from '@/lib/url-state'
 import { PEOPLE_COLUMNS, PEOPLE_SEARCH_PLACEHOLDER } from '@/app/o/[organizationId]/people/columns'
 import { LoadingStatus } from '@/app/o/[organizationId]/people/loading-status'
@@ -68,12 +69,7 @@ export function PeopleDirectory({ organizationId }: PeopleProps) {
   const [departmentSearch, setDepartmentSearch] = useState('')
   const [departmentsOpen, setDepartmentsOpen] = useState(false)
   const departmentTerm = useSearchFilterValue(departmentSearch, SEARCH_DEBOUNCE_MS).trim()
-  const searchTooLong = departmentSearch.trim().length > 200
-  const departments = useDepartments(
-    organizationId,
-    departmentTerm,
-    departmentsOpen && !searchTooLong && departmentTerm.length <= 200
-  )
+  const departments = useDepartments(organizationId, departmentTerm, departmentsOpen)
   const departmentWaiting = departmentSearch.trim() !== departmentTerm
   const changingFilter = people.isPlaceholderData || query !== search.trim()
 
@@ -111,6 +107,7 @@ export function PeopleDirectory({ organizationId }: PeopleProps) {
 
   const searchConfig: SearchConfig = {
     value: search,
+    maxLength: PEOPLE_SEARCH_MAX_LENGTH,
     onChange: setSearch,
     onClearAll: () => setSearch(''),
     placeholder: PEOPLE_SEARCH_PLACEHOLDER,
@@ -147,7 +144,7 @@ export function PeopleDirectory({ organizationId }: PeopleProps) {
                 <ChipCombobox
                   options={[
                     { value: ALL_DEPARTMENTS, label: 'All' },
-                    ...(departmentWaiting || searchTooLong
+                    ...(departmentWaiting
                       ? []
                       : (departments.data?.pages.flatMap((page) => page.departments) ?? [])
                     ).map(({ name, count, departmentKey: key }) => ({
@@ -160,23 +157,20 @@ export function PeopleDirectory({ organizationId }: PeopleProps) {
                   overlayContent={departmentLabel || 'All'}
                   overlayLabel={departmentLabel || 'All'}
                   searchable
+                  searchMaxLength={PEOPLE_SEARCH_MAX_LENGTH}
                   searchMode='server'
                   onSearchChange={setDepartmentSearch}
                   onOpenChange={setDepartmentsOpen}
-                  hasMore={!searchTooLong && !departmentWaiting && departments.hasNextPage}
+                  hasMore={!departmentWaiting && departments.hasNextPage}
                   onLoadMore={() => void departments.fetchNextPage()}
                   isLoadingMore={departments.isFetchingNextPage}
-                  isLoading={!searchTooLong && (departmentWaiting || departments.isPending)}
-                  error={
-                    searchTooLong
-                      ? 'Search using up to 200 characters from the department name.'
-                      : departments.error?.message
-                  }
+                  isLoading={departmentWaiting || departments.isPending}
+                  error={departments.error?.message}
                   searchPlaceholder='Search departments...'
                   emptyMessage='No departments match'
                   className='w-full'
                 />
-                {!searchTooLong && departments.isError && (
+                {departments.isError && (
                   <Chip
                     disabled={departments.isFetching}
                     onClick={() => void departments.refetch()}

apps/sim/app/o/[organizationId]/people/search-params.ts

@@ -1,12 +1,22 @@
-import { createSerializer, parseAsInteger, parseAsString, parseAsStringLiteral } from 'nuqs/server'
+import { truncateAtCodePoint } from '@sim/utils/string'
+import {
+  createParser,
+  createSerializer,
+  parseAsInteger,
+  parseAsString,
+  parseAsStringLiteral,
+} from 'nuqs/server'
+import { PEOPLE_SEARCH_MAX_LENGTH } from '@/lib/people/validation'
+
+const boundedSearch = (value: string) => truncateAtCodePoint(value, PEOPLE_SEARCH_MAX_LENGTH, '')
 
 /** `search` matches name, email, title, department, or location; `department` narrows to one. */
 export const peopleParsers = {
   view: parseAsStringLiteral(['chart', 'directory'] as const),
   panel: parseAsStringLiteral(['sync'] as const),
   focus: parseAsString.withDefault(''),
   page: parseAsInteger.withDefault(1),
-  search: parseAsString.withDefault(''),
+  search: createParser({ parse: boundedSearch, serialize: boundedSearch }).withDefault(''),
   department: parseAsString.withDefault(''),
   departmentKey: parseAsString.withDefault(''),
 } as const

apps/sim/app/o/[organizationId]/people/use-people-picker.tsx

@@ -1,5 +1,6 @@
 import { useState } from 'react'
 import { Avatar } from '@sim/emcn'
+import { PEOPLE_SEARCH_MAX_LENGTH } from '@/lib/people/validation'
 import { SEARCH_DEBOUNCE_MS } from '@/lib/url-state'
 import { usePeople } from '@/hooks/queries/people'
 import { useDebounce } from '@/hooks/use-debounce'
@@ -26,6 +27,7 @@ export function usePeoplePicker(
     people,
     pickerProps: {
       searchable: true,
+      searchMaxLength: PEOPLE_SEARCH_MAX_LENGTH,
       searchMode: 'server' as const,
       onSearchChange: setSearch,
       onOpenChange: setOpen,

apps/sim/app/workspace/[workspaceId]/components/resource/components/resource-options/resource-options.tsx

@@ -64,6 +64,7 @@ export interface SearchTag {
 
 export interface SearchConfig {
   value: string
+  maxLength?: number
   onChange: (value: string) => void
   placeholder?: string
   inputRef?: React.RefObject<HTMLInputElement | null>
@@ -280,6 +281,7 @@ const SearchSection = memo(function SearchSection({ search }: { search: SearchCo
           ref={search.inputRef}
           type='text'
           value={search.value}
+          maxLength={search.maxLength}
           onChange={(e) => search.onChange(e.target.value)}
           onKeyDown={search.onKeyDown}
           onFocus={search.onFocus}

apps/sim/hooks/queries/people-sync.ts

@@ -1,7 +1,8 @@
 import { useRef } from 'react'
-import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
+import { type QueryClient, useMutation, useQuery, useQueryClient } from '@tanstack/react-query'
 import { isApiClientError } from '@/lib/api/client/errors'
 import { requestJson } from '@/lib/api/client/request'
+import type { ContractJsonResponse } from '@/lib/api/contracts'
 import {
   configurePeopleSyncContract,
   disconnectPeopleSyncContract,
@@ -20,11 +21,27 @@ const syncKeys = {
   organization: (organizationId: string) => [...syncKeys.all, organizationId] as const,
 }
 
+type SyncResult = ContractJsonResponse<typeof getPeopleSyncContract>
+
+function refreshPublishedPeople(client: QueryClient, organizationId: string, result: SyncResult) {
+  const previous = client.getQueryData<SyncResult>(syncKeys.organization(organizationId))
+  if ((previous?.sync?.lastSuccessAt ?? null) !== (result.sync?.lastSuccessAt ?? null)) {
+    return client.invalidateQueries({ queryKey: peopleKeys.organization(organizationId) })
+  }
+}
+
 export function usePeopleSyncStatus(organizationId: string) {
+  const client = useQueryClient()
   return useQuery({
     queryKey: syncKeys.organization(organizationId),
-    queryFn: ({ signal }) =>
-      requestJson(getPeopleSyncContract, { params: { id: organizationId }, signal }),
+    queryFn: async ({ signal }) => {
+      const result = await requestJson(getPeopleSyncContract, {
+        params: { id: organizationId },
+        signal,
+      })
+      if (!signal.aborted) void refreshPublishedPeople(client, organizationId, result)
+      return result
+    },
     staleTime: SYNC_STATUS_STALE_TIME,
     refetchInterval: (query) => {
       const sync = query.state.data?.sync
@@ -62,11 +79,13 @@ export function usePeopleSyncActions(organizationId: string) {
       if (!body) throw new Error('Choose a directory connection')
       return requestJson(configurePeopleSyncContract, { params, body })
     },
-    onSuccess: () =>
-      Promise.all([
-        client.invalidateQueries({ queryKey: syncKeys.organization(organizationId) }),
-        client.invalidateQueries({ queryKey: peopleKeys.organization(organizationId) }),
-      ]),
+    onSuccess: async (result) => {
+      const queryKey = syncKeys.organization(organizationId)
+      await client.cancelQueries({ queryKey })
+      const refreshed = refreshPublishedPeople(client, organizationId, result)
+      client.setQueryData(queryKey, result)
+      await refreshed
+    },
     onError: () => client.invalidateQueries({ queryKey: syncKeys.organization(organizationId) }),
     onSettled: () => {
       busy.current = false

apps/sim/lib/api/contracts/people-sync.ts

@@ -49,6 +49,7 @@ const status = z.object({
     })
     .nullable(),
   retryAt: z.iso.datetime().nullable(),
+  retryBlocked: z.boolean(),
 })
 export type PeopleSyncStatus = z.infer<typeof status>
 

apps/sim/lib/api/contracts/people.ts

@@ -5,7 +5,11 @@ import {
   defineRouteContract,
 } from '@/lib/api/contracts'
 import { organizationIdSchema } from '@/lib/api/contracts/primitives'
-import { DIRECTORY_TEXT_MAX_LENGTH, memberProfileFieldsSchema } from '@/lib/people/validation'
+import {
+  DIRECTORY_TEXT_MAX_LENGTH,
+  memberProfileFieldsSchema,
+  PEOPLE_SEARCH_MAX_LENGTH,
+} from '@/lib/people/validation'
 
 /** Rows one import may carry; larger organizations import in several files. */
 export const PEOPLE_IMPORT_MAX_ROWS = 10_000
@@ -48,7 +52,7 @@ export const listPeopleContract = defineRouteContract({
   params,
   query: z.object({
     scope: z.enum(['roots', 'members']).optional(),
-    search: z.string().max(200).optional(),
+    search: z.string().max(PEOPLE_SEARCH_MAX_LENGTH).optional(),
     department: z.string().max(DIRECTORY_TEXT_MAX_LENGTH).optional(),
     departmentKey: departmentKey.optional(),
     cursor: z.string().min(1).max(1024).optional(),
@@ -68,7 +72,7 @@ export const listDepartmentsContract = defineRouteContract({
   path: '/api/organizations/[id]/people/departments',
   params,
   query: z.object({
-    search: z.string().max(200).optional(),
+    search: z.string().max(PEOPLE_SEARCH_MAX_LENGTH).optional(),
     cursor: z.string().min(1).max(1024).optional(),
   }),
   response: {

apps/sim/lib/people/repository.ts

@@ -42,7 +42,7 @@ export type PersonRecord = Omit<Person, 'joinedAt' | 'departmentKey'> & { joined
 const ACTIVE_USER = isNull(user.suspendedAt)
 const SUMMARY_FIELDS = sql`p.id AS "memberId", p.user_id AS "userId", p.name, p.email, p.image, p.title`
 
-/** Retire SCIM identities in the same commit as provisioning, before a later snapshot reclaims the row. */
+/** Hide retired SCIM identities immediately while the previous snapshot awaits cleanup. */
 function visibleDirectoryEntry(organizationId: string) {
   return sql`(d.source <> 'scim' OR EXISTS (
     SELECT 1 FROM ${scimUser} su JOIN ${user} account ON account.id = su.user_id