fix(search): remove the extra assistant tools gate

Author: waleedlatif1

.github/scripts/http-e2e.sh

@@ -205,7 +205,6 @@ case "$group" in
     export COPILOT_TOOL_PERMISSIONS_ENABLED=true
     export KNOWLEDGE_MEMBER_ACCESS=true CREDENTIAL_GROUPS=true ACCESS_CONTROL_ENABLED=true
     export NEXT_PUBLIC_ACCESS_CONTROL_ENABLED=true NEXT_PUBLIC_ORGANIZATIONS_ENABLED=true
-    export MSHIP_SEARCH_INTEGRATION_TOOLS=true
     bunx --no-install playwright install --with-deps chromium
     export INTERNAL_API_SECRET=desktop-inbox-http-ci-local-secret-at-least-32-characters
     export DB_TX_TRIPWIRE=throw

apps/docs/content/docs/platform/self-hosting/environment-variables.mdx

@@ -188,7 +188,6 @@ Plain JavaScript without imports runs in isolated-vm within Node child workers i
 | Variable | Description |
 |----------|-------------|
 | `COPILOT_API_KEY` | API key for the default Sim service. Required for Chat, the Sim Chat workflow block, and Inbox operations that use that service |
-| `MSHIP_SEARCH_INTEGRATION_TOOLS` | Opt in to personal-account reads and reviewed actions in Search Assistant. Off by default. Applies when AppConfig is disabled or no feature-flags document is available; an available AppConfig document takes precedence. Requires organization account setup and configured provider credentials. Tool permissions and source restrictions still apply. See [Connect your account](/search/connect-your-account) |
 | `NEXT_PUBLIC_CHAT_DISABLED` | Set to `true` to hide the Chat module: the workspace lands on your first workflow, with no chats list or editor Chat panel. Chat is shown when unset; `bunx sim-setup` sets it for you if you skip the chat key |
 | `PII_URL` | Base URL of the Presidio service backing PII detection and redaction. The Helm chart wires it to its own `pii` Service when `pii.enabled`; on Compose point it at the PII service on your network. Local development and the Helm fallback use `http://localhost:5001`; that address works only when the service is reachable there. Point production at a running service to use redaction |
 | `ADMIN_API_KEY` | Admin API key for GitOps operations and organization provisioning |

apps/docs/content/docs/search/ask-questions.mdx

@@ -125,7 +125,7 @@ Copy the reviewed draft into another app, or ask Assistant to create it using yo
 
 ## Review actions
 
-When integration actions are enabled, Assistant can answer questions and take supported actions in the same conversation. For example, ask it to draft an email in Gmail or create a Jira issue using your own connected account.
+Assistant can answer questions and take supported actions in the same conversation. For example, ask it to draft an email in Gmail or create a Jira issue using your own connected account.
 
 Reads run without a prompt by default. Writes wait for review by default. Each proposal appears inline in the conversation with its app, account, destination, and proposed content. Select **Edit** to change supported fields, then choose **Allow** or **Cancel** for each action. After several proposals, **Allow N shown** or **Cancel N shown** applies your choice to that displayed batch. You can approve individual actions first, then cancel the remaining batch.
 

apps/docs/content/docs/search/connect-your-account.mdx

@@ -46,7 +46,7 @@ Creating Jira sprints requires the Jira sprint permission. If your account was c
 
 ## Tool permissions
 
-When Assistant integration actions are enabled, open the app in **Integrations** and select your account. Tool permissions appear in its details when the app has supported Assistant tools available to you. Set a preference for each operation or use the **Read-only tools** and **Write tools** group controls:
+Open the app in **Integrations** and select your account. Tool permissions appear in its details when the app has supported Assistant tools available to you. Set a preference for each operation or use the **Read-only tools** and **Write tools** group controls:
 
 | Preference | Behavior |
 | --- | --- |

apps/sim/lib/assistant-actions/catalog.ts

@@ -7,7 +7,6 @@ import { projectIntegrationToolsForViewer } from '@/lib/integrations/tool-projec
 import { requireOrganizationSearchApproval } from '@/lib/knowledge/search/integration-policy'
 import { projectAssistantConnectedAccountTool } from '@/lib/mothership/assistant/connected-account-tool'
 import { isAssistantIntegrationTool } from '@/lib/mothership/assistant/tool-policy'
-import { isSearchIntegrationToolsEnabled } from '@/lib/mothership/feature-flags'
 import { getUserPermissionConfigForOrganization } from '@/lib/permission-groups/resolve.server'
 import { requiresScopedRetrieval } from '@/lib/sim-search/live/policy-schema'
 import { livePolicyFor, loadLiveSearchPolicies } from '@/lib/sim-search/live/policy-store'
@@ -17,17 +16,16 @@ export async function loadAssistantIntegrationTools(
   scope: { organizationId: string; userId: string },
   executor?: DbOrTx
 ) {
-  const [visibility, config, enabled] = await Promise.all([
+  const [visibility, config] = await Promise.all([
     getBlockVisibility({ userId: scope.userId, orgId: scope.organizationId }),
     getUserPermissionConfigForOrganization(scope.organizationId, executor),
-    isSearchIntegrationToolsEnabled(),
   ])
   const tools = projectIntegrationToolsForViewer(visibility, config)
     .tools.map((entry) => ({
       ...entry,
       config: projectAssistantConnectedAccountTool(entry.config),
     }))
-    .filter(({ config: tool }) => enabled && isAssistantIntegrationTool(tool) && tool.oauth)
+    .filter(({ config: tool }) => isAssistantIntegrationTool(tool) && tool.oauth)
   const providers = [
     ...new Set(
       tools.flatMap(({ config: tool }) => {

apps/sim/lib/assistant-actions/tool-permissions.integration.ts

@@ -74,7 +74,6 @@ import { getToolMetadata } from '@/tools/metadata'
 
 vi.hoisted(() => {
   Object.assign(process.env, {
-    MSHIP_SEARCH_INTEGRATION_TOOLS: 'true',
     JIRA_CLIENT_ID: 'assistant-fixture-client',
     JIRA_CLIENT_SECRET: 'assistant-fixture-client-secret',
     GOOGLE_CLIENT_ID: 'assistant-google-fixture-client',

apps/sim/lib/core/config/env.ts

@@ -606,7 +606,6 @@ export const env = createEnv({
     DASHBOARDS: z.boolean().optional(),
     PROJECTS:                              z.boolean().optional(),                 // Fallback for the `projects` feature flag off AppConfig
     MSHIP_COMPUTER_USE: z.boolean().optional(),
-    MSHIP_SEARCH_INTEGRATION_TOOLS: z.boolean().optional(),
     WORKFLOW_TESTS:                        z.boolean().optional(),                 // Fallback for the `workflow-tests` feature flag off AppConfig
     CHANGELOG:                             z.boolean().optional(),                 // Fallback for the `changelog` feature flag off AppConfig
     MSHIP_MODEL_SELECTOR: z.boolean().optional(),

apps/sim/lib/core/config/feature-flags.ts

@@ -57,11 +57,6 @@ const FEATURE_FLAGS = {
       'personal workspaces follow the global switch. Each device must also opt in.',
     fallback: 'MSHIP_COMPUTER_USE',
   },
-  'mothership-search-integration-tools': {
-    description:
-      'Enable personal-account integration reads and reviewed actions in Search Assistant. Global rollout with MSHIP_SEARCH_INTEGRATION_TOOLS fallback when AppConfig is unavailable; disabled by default.',
-    fallback: 'MSHIP_SEARCH_INTEGRATION_TOOLS',
-  },
   'workflow-tests': {
     description:
       'Enable workflow tests: the workspace Tests page, tests/<name>.test.js files, and the Sim tests tool. Supports global and organization rollout; disabled by default.',

apps/sim/lib/mothership/chat/payload.test.ts

@@ -44,25 +44,17 @@ const {
   mockDashboardAvailability,
   mockSecretNames,
   mockComputerUseAvailable,
-  mockSearchIntegrationToolsEnabled,
 } = vi.hoisted(() => ({
   mockDashboardAvailability: vi.fn(async () => false),
   mockComputerUseAvailable: vi.fn(async () => false),
   mockCreateUserToolSchema: vi.fn(() => ({ type: 'object', properties: {} })),
   mockSecretNames: vi.fn(async () => ({ names: [] as string[] })),
-  mockSearchIntegrationToolsEnabled: vi.fn(async () => true),
 }))
 
 vi.mock('@/lib/computer-use/application/availability', () => ({
   isComputerUseAvailableFor: mockComputerUseAvailable,
 }))
 
-vi.mock('@/lib/mothership/feature-flags', () => ({
-  isSearchIntegrationToolsEnabled: mockSearchIntegrationToolsEnabled,
-}))
-
-beforeEach(() => mockSearchIntegrationToolsEnabled.mockResolvedValue(true))
-
 // The inventory reads nine application worlds; these suites exercise the request shape, not the reads.
 vi.mock('@/lib/mothership/application/execute-organization-secret-use-case', () => ({
   executeOrganizationSecretUseCase: mockSecretNames,
@@ -948,49 +940,32 @@ describe('desktop request capabilities', () => {
   })
 })
 
-it('carries only enabled MCP IDs without eager catalog discovery while preserving desktop capabilities', async () => {
-  const { getBlockVisibilityForCopilot } = await import('@/lib/mothership/block-visibility')
-  vi.mocked(getBlockVisibilityForCopilot).mockClear()
-  const principal = createSessionPrincipal({ userId: 'user-org' })
-  const payload = await buildCopilotRequestPayload({
-    message: 'Use my tools',
-    userId: 'user-org',
-    userMessageId: 'message-org',
-    organizationId: 'org-catalog',
-    chatId: 'chat-org',
-    principal,
-    mode: 'agent',
-    model: '',
-    mcpServerIds: ['server-a', 'server-b'],
-    browser: true,
-    terminalCapable: true,
-  })
-  expect(getBlockVisibilityForCopilot).not.toHaveBeenCalled()
-  expect(payload.integrationCatalog).toEqual({ mcpServerIds: ['server-a', 'server-b'] })
-  expect(payload).not.toHaveProperty('integrationTools')
-  expect(payload).not.toHaveProperty('mothershipTools')
-  expect(payload.desktop).toMatchObject({ browser: true, terminal: true })
-})
-
-/** The worker derives both its gateway tools and prompt instructions from this capability. */
-it.each([{ organizationId: 'org-1' }, { workspaceId: 'ws-1' }])(
-  'switches Search integration capability per turn while preserving Build for %j',
-  async (scope) => {
-    for (const enabled of [true, false, true]) {
-      mockSearchIntegrationToolsEnabled.mockResolvedValue(enabled)
-      for (const mode of ['assistant', 'agent', 'plan']) {
-        const payload = await buildCopilotRequestPayload({
-          message: 'Find a person',
-          userId: 'person',
-          userMessageId: 'message',
-          mode,
-          model: '',
-          ...scope,
-        })
-        expect(payload.integrationCatalog).toEqual(
-          mode === 'assistant' && !enabled ? undefined : { mcpServerIds: [] }
-        )
-      }
-    }
+it.each(['assistant', 'agent', 'plan'] as const)(
+  'advertises the integration gateway while isolating MCP and desktop capabilities in %s mode',
+  async (mode) => {
+    const { getBlockVisibilityForCopilot } = await import('@/lib/mothership/block-visibility')
+    vi.mocked(getBlockVisibilityForCopilot).mockClear()
+    const principal = createSessionPrincipal({ userId: 'user-org' })
+    const payload = await buildCopilotRequestPayload({
+      message: 'Use my tools',
+      userId: 'user-org',
+      userMessageId: 'message-org',
+      organizationId: 'org-catalog',
+      chatId: 'chat-org',
+      principal,
+      mode,
+      model: '',
+      mcpServerIds: ['server-a', 'server-b'],
+      browser: true,
+      terminalCapable: true,
+    })
+    expect(getBlockVisibilityForCopilot).not.toHaveBeenCalled()
+    expect(payload.integrationCatalog).toEqual({
+      mcpServerIds: mode === 'assistant' ? [] : ['server-a', 'server-b'],
+    })
+    expect(payload).not.toHaveProperty('integrationTools')
+    expect(payload).not.toHaveProperty('mothershipTools')
+    if (mode === 'assistant') expect(payload.desktop).toBeUndefined()
+    else expect(payload.desktop).toMatchObject({ browser: true, terminal: true })
   }
 )

apps/sim/lib/mothership/chat/payload.ts

@@ -32,7 +32,6 @@ import type { AssistantImageContent } from '@/lib/mothership/chat/assistant-imag
 import { buildUploadedFileContext } from '@/lib/mothership/chat/upload-context'
 import { buildWorkspaceInventory } from '@/lib/mothership/chat/workspace-inventory'
 import { computeEntitlements } from '@/lib/mothership/entitlements'
-import { isSearchIntegrationToolsEnabled } from '@/lib/mothership/feature-flags'
 import type { AssistantSearchLevel } from '@/lib/mothership/generated/assistant'
 import {
   type ChatRequest,
@@ -388,7 +387,6 @@ export async function buildCopilotRequestPayload(params: BuildPayloadParams): Pr
     params.principal !== undefined &&
     computerUseOwner !== null &&
     (await isComputerUseAvailableFor(params.principal, computerUseOwner))
-  const integrationGateway = !isAssistant || (await isSearchIntegrationToolsEnabled())
 
   // Track uploaded files in the DB and build context tags instead of base64 inlining.
   // Tracking writes `workspace_files` rows, so it needs the same write grant the
@@ -539,13 +537,9 @@ export async function buildCopilotRequestPayload(params: BuildPayloadParams): Pr
     messageId: userMessageId,
     ...(chatId ? { chatId } : {}),
     ...(allContexts.length > 0 ? { context: allContexts } : {}),
-    ...(integrationGateway
-      ? {
-          integrationCatalog: {
-            mcpServerIds: isAssistant ? [] : [...new Set(params.mcpServerIds ?? [])],
-          },
-        }
-      : {}),
+    integrationCatalog: {
+      mcpServerIds: isAssistant ? [] : [...new Set(params.mcpServerIds ?? [])],
+    },
     ...(params.userTimezone ? { userTimezone: params.userTimezone } : {}),
     ...(params.effort ? { effort: params.effort } : {}),
     ...(params.modelSelection ? { modelSelection: params.modelSelection } : {}),