fix(cli): refuse an empty entry in a joined file-reference list

Author: waleedlatif1

packages/sim-cli/src/runtime/file-references.test.ts

@@ -40,6 +40,15 @@ describe('files batch-delete reads the references a caller writes', () => {
     expect(await sentFileIds(['wf_a,wf_b'])).toEqual([['wf_a', 'wf_b']])
   })
 
+  it('refuses a JSON array or comma-joined run with an empty entry, before any request', async () => {
+    for (const value of ['["wf_a",""]', 'wf_a,,wf_b', 'wf_a,']) {
+      const result = await run(['files', 'batch-delete', '--ids', value, '--yes'])
+      expect(result.exitCode).toBe(1)
+      expect(result.stderr).toContain('--file-ids values cannot be empty')
+      expect(result.bodies).toEqual([])
+    }
+  })
+
   it('keeps a comma inside a path, so one file is never read as two', async () => {
     expect(await sentFileIds(['--paths', 'files/qc/a,b.png', 'files/c.png'])).toEqual([
       ['files/qc/a,b.png', 'files/c.png'],

packages/sim-cli/src/runtime/request.ts

@@ -285,13 +285,18 @@ export async function readArgumentSource(
  * ids, or the value itself. See {@link FlagSpec.fileReferences} for why neither reading can
  * misread a single id or path.
  */
-function fileReferenceEntries(value: string): string[] {
+function fileReferenceEntries(value: string, flagName: string): string[] {
   const entries = value.startsWith('[')
     ? jsonStringArray(value)
     : value.includes(',') && !value.includes('/')
       ? value.split(',')
       : undefined
-  return entries ? entries.map((entry) => entry.trim()).filter(Boolean) : [value]
+  if (!entries) return [value]
+  const trimmed = entries.map((entry) => entry.trim())
+  if (trimmed.some((entry) => !entry)) {
+    throw new SimApiError(`--${flagName} values cannot be empty: ${value}`, 0)
+  }
+  return trimmed
 }
 
 function jsonStringArray(value: string): string[] | undefined {
@@ -473,9 +478,11 @@ export async function coerce(
    */
   if (flag.list) {
     const listed = await readListValues(raw, flagName, flag.manifest === true)
-    const values = (flag.fileReferences ? listed.flatMap(fileReferenceEntries) : listed).map(
-      (value) => (flag.folderPath ? encodeFolderPath(value) : value)
-    )
+    const values = (
+      flag.fileReferences
+        ? listed.flatMap((value) => fileReferenceEntries(value, flagName))
+        : listed
+    ).map((value) => (flag.folderPath ? encodeFolderPath(value) : value))
     // Encoding first is also what keeps the comma-joined form unambiguous: a
     // folder name containing a comma leaves here as `%2C`, so the route's split
     // cannot cut one path in half.